Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Miklos Szeredi
Starting review in the middle, because this is the part I'm most familiar with. New addres_space_operations methods are added: int swapfile(struct address_space *, int); Separate -swapon() and -swapoff() methods would be so much cleaner IMO. Also is there a reason why 'struct file *' cannot

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Peter Zijlstra
On Tue, 2008-02-26 at 13:45 +0100, Miklos Szeredi wrote: Starting review in the middle, because this is the part I'm most familiar with. New addres_space_operations methods are added: int swapfile(struct address_space *, int); Separate -swapon() and -swapoff() methods would be so