[PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page

2007-04-11 Thread Nate Diller
Replace jffs2_gc_fetch_page() and jffs2_gc_release_page() using the read_cache_page() and put_kmapped_page() calls, and update the call site accordingly. Explicit calls to kmap()/kunmap() make the code more clear. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2

Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page

2007-04-12 Thread Phillip Lougher
Nate Diller wrote: + page = read_cache_page(OFNI_EDONI_2SFFJ(f)->i_mapping, + start >> PAGE_CACHE_SHIFT, + (void *)jffs2_do_readpage_unlock, + OFNI_EDONI_2SFFJ(f)); - if (IS_ERR(pg_ptr)) { +

Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page

2007-04-12 Thread Nate Diller
On 4/12/07, Phillip Lougher <[EMAIL PROTECTED]> wrote: Nate Diller wrote: > + page = read_cache_page(OFNI_EDONI_2SFFJ(f)->i_mapping, > + start >> PAGE_CACHE_SHIFT, > + (void *)jffs2_do_readpage_unlock, > + OF

Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page

2007-04-12 Thread Phillip Lougher
Nate Diller wrote: wow, you're right. I was sure I compile-tested this ... oh, "depends on MTD". oops. thanks for reviewing. does it look OK to you otherwise? Yes.. NATE - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PRO

Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page

2007-04-15 Thread David Woodhouse
On Wed, 2007-04-11 at 19:49 -0700, Nate Diller wrote: > Replace jffs2_gc_fetch_page() and jffs2_gc_release_page() using the > read_cache_page() and put_kmapped_page() calls, and update the call site > accordingly. Explicit calls to kmap()/kunmap() make the code more clear. > > Signed-off-by: Nate