Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd

2007-09-27 Thread Davide Libenzi
On Thu, 27 Sep 2007, Andrew Morton wrote: > On Thu, 27 Sep 2007 10:56:09 -0700 (PDT) Davide Libenzi <[EMAIL PROTECTED]> > wrote: > > > Open coded atomic_inc()? Hmm, dunno... > > box:/usr/src/25> grep 'atomic_inc.*->i_count' */*.c > fs/block_dev.c: atomic_inc(&bdev->bd_inode->i_count); >

Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 10:56:09 -0700 (PDT) Davide Libenzi <[EMAIL PROTECTED]> wrote: > Open coded atomic_inc()? Hmm, dunno... box:/usr/src/25> grep 'atomic_inc.*->i_count' */*.c fs/block_dev.c: atomic_inc(&bdev->bd_inode->i_count); fs/block_dev.c: atomic_inc(&bdev->bd_inode

Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd

2007-09-27 Thread Davide Libenzi
On Thu, 27 Sep 2007, Andrew Morton wrote: > On Thu, 27 Sep 2007 09:54:47 -0700 (PDT) Davide Libenzi <[EMAIL PROTECTED]> > wrote: > > > On Thu, 27 Sep 2007, Davide Libenzi wrote: > > > > > On Wed, 26 Sep 2007, Andrew Morton wrote: > > > > > > > On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <[E

Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 09:54:47 -0700 (PDT) Davide Libenzi <[EMAIL PROTECTED]> wrote: > On Thu, 27 Sep 2007, Davide Libenzi wrote: > > > On Wed, 26 Sep 2007, Andrew Morton wrote: > > > > > On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <[EMAIL PROTECTED]> wrote: > > > > > > > Hello, > > > > > >

Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd

2007-09-27 Thread Davide Libenzi
On Thu, 27 Sep 2007, Davide Libenzi wrote: > On Wed, 26 Sep 2007, Andrew Morton wrote: > > > On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <[EMAIL PROTECTED]> wrote: > > > > > Hello, > > > > > > igrab return NULL on error. > > > > > > Signed-off-by: Yan Zheng<[EMAIL PROTECTED]> > > > --- > >

Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd

2007-09-27 Thread Davide Libenzi
On Wed, 26 Sep 2007, Andrew Morton wrote: > On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > igrab return NULL on error. > > > > Signed-off-by: Yan Zheng<[EMAIL PROTECTED]> > > --- > > diff -ur linux-2.6.23-rc8/fs/anon_inodes.c linux/fs/anon_inodes.

Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd

2007-09-26 Thread Andrew Morton
On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <[EMAIL PROTECTED]> wrote: > Hello, > > igrab return NULL on error. > > Signed-off-by: Yan Zheng<[EMAIL PROTECTED]> > --- > diff -ur linux-2.6.23-rc8/fs/anon_inodes.c linux/fs/anon_inodes.c > --- linux-2.6.23-rc8/fs/anon_inodes.c 2007-09-27 10:05:07

[patch]anon_inodes.c: fix error check in anon_inode_getfd

2007-09-26 Thread Yan Zheng
Hello, igrab return NULL on error. Signed-off-by: Yan Zheng<[EMAIL PROTECTED]> --- diff -ur linux-2.6.23-rc8/fs/anon_inodes.c linux/fs/anon_inodes.c --- linux-2.6.23-rc8/fs/anon_inodes.c 2007-09-27 10:05:07.0 +0800 +++ linux/fs/anon_inodes.c 2007-09-27 10:18:26.0 +0800 @@ -