> > Also add minor fix: when parsing the "mode" option, mask with
> > S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the
> > mask.
>
> umode_t is 16 bits, so it doesn't. The change is still good, of course.
We still use 16 bit types? Strange ;)
>
> > + if (config.mode != DEVP
Miklos Szeredi wrote:
Also add minor fix: when parsing the "mode" option, mask with
S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the
mask.
umode_t is 16 bits, so it doesn't. The change is still good, of course.
+ if (config.mode != DEVPTS_DEFAULT_MODE)
+
From: Miklos Szeredi <[EMAIL PROTECTED]>
Add a .show_options super operation to devpts.
Also add minor fix: when parsing the "mode" option, mask with
S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the
mask.
Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]>
---
Index: linux/fs/dev
