Re: NULL f_ops

2001-03-12 Thread Trond Myklebust
> " " == Alexander Viro <[EMAIL PROTECTED]> writes: > Umm... Let's make it pure copy-on-write cache a-la 4.4 and if > pthreads folks need this craziness with thread-group-wide > credentials change - let them pay upon changing credentials. I > really don't see any point in

Re: NULL f_ops

2001-03-12 Thread Matthew Wilcox
On Mon, Mar 12, 2001 at 10:58:29AM -0500, Alexander Viro wrote: > What I mean is quite simple - objects in cred.cache can be > shared, but to change the contents of object you need to make sure > that you are the sole owner of that object. I.e. > > modify_cred(cred, ...) > { > if ((*c

Re: NULL f_ops

2001-03-12 Thread Alexander Viro
On Mon, 12 Mar 2001, Trond Myklebust wrote: > > " " == Alexander Viro <[EMAIL PROTECTED]> writes: > > > Aye. It's certainly 2.5 stuff, but I'll include that into > > namespace-patch for testing. We probably need to sort the API > > issues out - I suspect that net/sunrpc will

Re: NULL f_ops

2001-03-12 Thread Trond Myklebust
> " " == Alexander Viro <[EMAIL PROTECTED]> writes: > Aye. It's certainly 2.5 stuff, but I'll include that into > namespace-patch for testing. We probably need to sort the API > issues out - I suspect that net/sunrpc will cause most of the > pain and you definitely know th

Re: NULL f_ops

2001-03-12 Thread Alexander Viro
On 12 Mar 2001, Trond Myklebust wrote: > All that is needed is to unify all the disparate credential info we > already have at the VFS level. Just look at the ridiculous number of > different places in which we currently try to save the exact same > info: 10 fields in task structure + 2-3 field

Re: NULL f_ops

2001-03-12 Thread Trond Myklebust
> " " == Alexander Viro <[EMAIL PROTECTED]> writes: > Check the archives - basically, it took major efforts on part > of Trond to make the thing stay. I'm also not happy about that > ugliness... > We will need credentials cache and now we've got some of the > silline

Re: NULL f_ops

2001-03-09 Thread Roman Zippel
Daniel Phillips wrote: > I would like to see the (struct file *) in ->readpage go away. I don't > think there is a technical obstacle to doing that, since the same > parameter was removed from ->writepage without much fuss. The code > impact is in samba, coda and nfs. All block filesystems just

RE: NULL f_ops

2001-03-08 Thread Lever, Charles
AIL PROTECTED] > Subject: NULL f_ops > > > > Someone tell me if my chain of reasoning is wrong here... > > (1) The only way to get a `struct file' is to call get_empty_filp() > (2) All callers of get_empty_filp() set ->f_ops to a non-NULL val

Re: NULL f_ops

2001-03-08 Thread Alexander Viro
On Thu, 8 Mar 2001, Daniel Phillips wrote: > I would like to see the (struct file *) in ->readpage go away. I don't > think there is a technical obstacle to doing that, since the same > parameter was removed from ->writepage without much fuss. The code > impact is in samba, coda and nfs. All

Re: NULL f_ops

2001-03-08 Thread Daniel Phillips
On Thu, 08 Mar 2001, Matthew Wilcox wrote: > On Thu, Mar 08, 2001 at 11:16:10AM -0500, Alexander Viro wrote: > > I'm not sure on your #2. In principle, ->i_fop can be NULL. It may be > > a good thing to declare that it should never happens, but right now it's > > not guaranteed. > > > > Besides,

Re: NULL f_ops

2001-03-08 Thread Ben LaHaise
On Thu, 8 Mar 2001, Andi Kleen wrote: > There is code that creates private struct files without calling get_empty_filp() > NFS comes to mind, but there is other too. Now of course these could > be changed, but I think the change would cause much more work for debugging/ > fixing than you think ;

Re: NULL f_ops

2001-03-08 Thread Andi Kleen
On Thu, Mar 08, 2001 at 03:48:08PM +, Matthew Wilcox wrote: > > Someone tell me if my chain of reasoning is wrong here... > > (1) The only way to get a `struct file' is to call get_empty_filp() There is code that creates private struct files without calling get_empty_filp() NFS comes to mi

Re: NULL f_ops

2001-03-08 Thread Matthew Wilcox
On Thu, Mar 08, 2001 at 11:16:10AM -0500, Alexander Viro wrote: > I'm not sure on your #2. In principle, ->i_fop can be NULL. It may be > a good thing to declare that it should never happens, but right now it's > not guaranteed. > > Besides, revoke-like thing in proc/generic.c _does_ set f_op to

Re: NULL f_ops

2001-03-08 Thread Alexander Viro
On Thu, 8 Mar 2001, Matthew Wilcox wrote: > > Someone tell me if my chain of reasoning is wrong here... > > (1) The only way to get a `struct file' is to call get_empty_filp() > (2) All callers of get_empty_filp() set ->f_ops to a non-NULL value > (3) All checks for f_ops being NULL can be

NULL f_ops

2001-03-08 Thread Matthew Wilcox
Someone tell me if my chain of reasoning is wrong here... (1) The only way to get a `struct file' is to call get_empty_filp() (2) All callers of get_empty_filp() set ->f_ops to a non-NULL value (3) All checks for f_ops being NULL can be removed -- Revolutions do not require corporate suppor