irq_domain_add_legacy() returns NULL on error, it doesn't return error
pointers.
Fixes: 384ca3c6a28d ('gpio: pxa: change the interrupt management')
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index c2d1a47..415852d
There is a signedness bug here so the loop will never exit.
Fixes: 8bfcbbbcabe0 ('pinctrl: nsp: add gpio-a driver support for Broadcom NSP
SoC')
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
b/drivers/pinctrl/bcm/pinctrl-nsp-
IRQ pending.
> > Change the -EINVAL to 0.
>
> Is there any more source code clean-up needed around the comment "FIXME"
> in the affected function?
Delete the FIXME comment.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsu
This introduces a compile warning. These functions are supposed to
return 1 if there is an IRQ pending. Change the -EINVAL to 0.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majord...@vger.kernel.org
More
We were returning with "chip->lock" held by mistake. It's safe to
move the return to before we take the spinlock.
Fixes: 1dbf7f299f90 ('gpio: pl061: detail IRQ trigger handling')
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
diff --git a/drivers/gpio/gpio-pl061.c
checkpatch.pl these days complains
that the allocation failed printks aren't needed so I removed them.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos5440.c
b/drivers/pinctrl/samsung/pinctrl-exynos5440.c
index f5619fb..f804a61c 100644
semicolon
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-gpio in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
/
~/smatch/smatch_scripts/kchecker drivers/pinctrl/pinctrl-amd.c
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-gpio in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-gpio in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
This causes a double free. You can just leave it out since devm_
pointers are freed automatically.
1253 chip_error:
1254 gpiochip_remove(pctl-chip);
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-gpio in
the body of a message to majord
If kstrdup() fails then we should return -ENOMEM but instead the current
code returns success.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/gpio/gpio-ge.c b/drivers/gpio/gpio-ge.c
index 6ea9303..07e9b39 100644
--- a/drivers/gpio/gpio-ge.c
+++ b/drivers/gpio/gpio
gc-ngpio is a number between 1 and GRGPIO_MAX_NGPIO. If offset is
GRGPIO_MAX_NGPIO then we're going one step beyond the end of the
priv-lirqs[] array.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
index 09daaf2
On Mon, Mar 31, 2014 at 03:05:25PM +0300, Mika Westerberg wrote:
On Fri, Mar 28, 2014 at 11:37:32AM +0300, Dan Carpenter wrote:
Hello Mika Westerberg,
The patch 473ed7be0da0: gpio / ACPI: Add support for ACPI GPIO
operation regions from Mar 14, 2014, leads to the following static
On Mon, Mar 31, 2014 at 04:45:57PM +0300, Mika Westerberg wrote:
On Mon, Mar 31, 2014 at 03:11:33PM +0300, Dan Carpenter wrote:
On Mon, Mar 31, 2014 at 03:05:25PM +0300, Mika Westerberg wrote:
On Fri, Mar 28, 2014 at 11:37:32AM +0300, Dan Carpenter wrote:
Hello Mika Westerberg
There is a bug in mvebu_gpio_probe() where we do:
mvchip-irqbase = irq_alloc_descs(-1, 0, ngpios, -1);
if (mvchip-irqbase 0) {
The problem is that mvchip-irqbase is unsigned so the error handling
doesn't work. I have changed it to be a regular int.
Signed-off-by: Dan Carpenter
There is a missing unlock on error here.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 0eb9cba..3c01782 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1783,7 +1783,8 @@ static int gpiod_set_debounce
16 matches
Mail list logo