Re: [PATCH] gpio: mxs: Use PIN2IRQ register to mask interrupts

2015-01-13 Thread Shawn Guo
On Tue, Jan 13, 2015 at 07:34:31AM +0100, Linus Walleij wrote: On Mon, Dec 15, 2014 at 11:28 AM, Robin van der Gracht ro...@protonic.nl wrote: The PIN2IRQ register should be used to mask an interrupt. Clearing a No, PIN2IRQ implements a function select, not a mask. bit in the IRQEN

[PATCH] gpio: mxs: Use PIN2IRQ register to mask interrupts

2014-12-15 Thread Robin van der Gracht
The PIN2IRQ register should be used to mask an interrupt. Clearing a bit in the IRQEN register only prevents the interrupt from propagating but still allows hardware to set the status bit when triggered. So when unmasking the interrupt, it will immediately re-trigger if an interrupt condition