[Linux-ha-dev] pgsql RA improvements

2007-02-23 Thread Keisuke MORI
Hi, We have found a several problems with pgsql RA through our testing. It 'fails to failover' in some scenarios. I'm proposing a patch to fix them. Problem description: 1) The first 'monitor' may fail even if the postmaster was successfully launched. This is because 'start' of the pgsql

Re: [Linux-ha-dev] pgsql RA improvements

2007-02-23 Thread Lars Marowsky-Bree
On 2007-02-23T19:07:19, Keisuke MORI [EMAIL PROTECTED] wrote: Thanks a lot for your enhancements! They all look good. Merged. ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page:

Re: [Linux-ha-dev] pgsql RA improvements

2007-02-23 Thread Andrew Beekhof
On 2/23/07, Keisuke MORI [EMAIL PROTECTED] wrote: Hi, We have found a several problems with pgsql RA through our testing. It 'fails to failover' in some scenarios. I'm proposing a patch to fix them. Problem description: 1) The first 'monitor' may fail even if the postmaster was

Re: [Linux-ha-dev] pgsql RA improvements

2007-02-23 Thread Serge Dubrouski
I like the idea of the patch, but honestly I don't like how it's implemented. It shall call (as Andrew suggested) monitor function to check that pgsql is up or down instead of spreading the same code all around the script. I'd like to review the idea and prepare another patch if everybody is

Re: [Linux-ha-dev] pgsql RA improvements

2007-02-23 Thread Serge Dubrouski
And I don't like the idea of removing PID in start function. The standard approach if to remove it after stopping application. Other way it could lead to attempt of starting a second copy of application. On 2/23/07, Serge Dubrouski [EMAIL PROTECTED] wrote: I like the idea of the patch, but

Re: [Linux-ha-dev] pgsql RA improvements

2007-02-23 Thread Serge Dubrouski
Attached is the patch in the way that I like it to be. On 2/23/07, Serge Dubrouski [EMAIL PROTECTED] wrote: And I don't like the idea of removing PID in start function. The standard approach if to remove it after stopping application. Other way it could lead to attempt of starting a second copy

Re: [Linux-ha-dev] cl_make_realtime() used by too few processes?

2007-02-23 Thread Alan Robertson
Lars Marowsky-Bree wrote: On 2007-02-22T20:30:10, Alan Robertson [EMAIL PROTECTED] wrote: Of course, that'd effectively mean needing to lock everything into memory, which is clearly infeasible and there's more work here to fix the theoretical deadlock issue. But, with the same argument,

Re: [Linux-ha-dev] pgsql RA improvements

2007-02-23 Thread Serge Dubrouski
Sorry, I just found that my version won't work properly on Solaris. Attached is the corrected one. Sorry for creating so many messages :-) On 2/23/07, Serge Dubrouski [EMAIL PROTECTED] wrote: Attached is the patch in the way that I like it to be. On 2/23/07, Serge Dubrouski [EMAIL PROTECTED]

Re: [Linux-ha-dev] pgsql RA improvements

2007-02-23 Thread Andrew Beekhof
On 2/23/07, Serge Dubrouski [EMAIL PROTECTED] wrote: On 2/23/07, Andrew Beekhof [EMAIL PROTECTED] wrote: On 2/23/07, Keisuke MORI [EMAIL PROTECTED] wrote: Hi, We have found a several problems with pgsql RA through our testing. It 'fails to failover' in some scenarios. I'm proposing a