[Linux-ha-dev] [patch] OCF Filesystem agent doesn't check /proc/mounts

2008-04-22 Thread Simon Horman
On Mon, Apr 21, 2008 at 10:45:59AM +0100, Andrew Suffield wrote: > On Mon, Apr 21, 2008 at 10:22:01AM +0100, David Lee wrote: > > Solaris doesn't have a "/proc/mounts". What it does have is the ability > > (like Linux) to list the kernel mount table from a simple "mount" command. > > Irritatingly

Re: [Linux-ha-dev] Re: [RFC] heartbeat-2.1.4

2008-04-22 Thread Andrew Beekhof
On Tue, Apr 22, 2008 at 1:52 PM, Keisuke MORI <[EMAIL PROTECTED]> wrote: > "Andrew Beekhof" <[EMAIL PROTECTED]> writes: > (snip) > > >> Here's my observation: > >> > >> - An element of pending_ops is removed at lrm.c:L497 > >> - It is called inside from g_has_table_foreach() at L1475 > >>

Re: [Linux-ha-dev] Re: [RFC] heartbeat-2.1.4

2008-04-22 Thread Keisuke MORI
"Andrew Beekhof" <[EMAIL PROTECTED]> writes: (snip) >> Here's my observation: >> >> - An element of pending_ops is removed at lrm.c:L497 >> - It is called inside from g_has_table_foreach() at L1475 >> - This is violating the usage of g_has_table_foreach() according >>to the glib manual.

Re: [Linux-ha-dev] Re: [RFC] heartbeat-2.1.4

2008-04-22 Thread Andrew Beekhof
2008/4/22 Keisuke MORI <[EMAIL PROTECTED]>: > Hi, > > > > "Andrew Beekhof" <[EMAIL PROTECTED]> writes: > > > On Wed, Apr 16, 2008 at 1:31 PM, HIDEO YAMAUCHI > > <[EMAIL PROTECTED]> wrote: > >> Hi Andrew, > >> > >> > >> > I asked for the right function but the wrong frame number - I should >

Re: [Linux-ha-dev] Re: [RFC] heartbeat-2.1.4

2008-04-22 Thread Keisuke MORI
recurring_action_by_rsc, rsc); http://library.gnome.org/devel/glib/stable/glib-Hash-Tables.html#g-hash-table-foreach (...) The hash table may not be modified while iterating over it (you can't add/remove items). I also attached my suggested patch, although I can not guarantee the correctnes

Re: [Linux-ha-dev] Re: Bug#476692: heartbeat: OCF Filesystem agentdoesn't check /proc/mounts

2008-04-22 Thread Sebastian Reitenbach
High-Availability Linux Development List wrote: > On Sat, 19 Apr 2008, Simon Horman wrote: > > > On Fri, Apr 18, 2008 at 02:52:41PM +0100, Andrew Suffield wrote: > > > Package: heartbeat > > > > > > The OCF Filesystem agent uses this code to monitor the mounted > > > filesystems: > > > > > > li