Re: [Linux-ha-dev] [Linux-HA] OCF resource for conntrack

2010-09-28 Thread Jonathan Petersson
Great feedback, thanks a bunch, I'll get to it making the mods recommended asap. On Tue, Sep 28, 2010 at 10:23 PM, Florian Haas wrote: > Hi Jonathan, > > as this discussion applies to a new RA, let's move it to the -dev list. > Very helpful contribution, thanks a lot. A few comments below. > >> #

Re: [Linux-ha-dev] [Linux-HA] OCF resource for conntrack

2010-09-28 Thread Florian Haas
Hi Jonathan, as this discussion applies to a new RA, let's move it to the -dev list. Very helpful contribution, thanks a lot. A few comments below. > # Fill in some defaults if no values are specified > OCF_RESKEY_bin_default="/usr/sbin/conntrackd" > OCF_RESKEY_cfg_default="/etc/conntrackd/conntr

Re: [Linux-ha-dev] [PATCH] Medium: adjust socket buffers when adjusting ipc queue length

2010-09-28 Thread Lars Ellenberg
ARGHL. somehow used the wrong, still broken, repository for the hg email. > + if (qlen == 0) - if (qlen == 0) + if (q_len == 0) > + cl_log(LOG_DEBUG, "adjusted %sbuf size to %u", direction, > bytes); - cl_log(LOG_DEBUG, "adjusted %sbuf size to %u", dire

[Linux-ha-dev] [PATCH] Medium: adjust socket buffers when adjusting ipc queue length

2010-09-28 Thread Lars Ellenberg
# HG changeset patch # User Lars Ellenberg # Date 1285685263 -7200 # Node ID beedb189b8a9c47c793f898755d0e301aacce4d4 # Parent 94f4ee6025502c7ef710775d458ef766c51ad6db Medium: adjust socket buffers when adjusting ipc queue length If a channel adjusts its ipc queue length, it is probably a good i

[Linux-ha-dev] [PATCH] Low: add cl_rand_from_intervall(a, b) helper

2010-09-28 Thread Lars Ellenberg
# HG changeset patch # User Lars Ellenberg # Date 1285682508 -7200 # Node ID 94f4ee6025502c7ef710775d458ef766c51ad6db # Parent 066f484922ec549f84ea59c138d4e6cf16b2e14b Low: add cl_rand_from_intervall(a, b) helper There are a few places throughout the (heartbeat) code which want to generate rando

[Linux-ha-dev] [PATCH] Low: add and use UNCONST_CAST_POINTER macro to avoid -Wqual-cast warnings

2010-09-28 Thread Lars Ellenberg
# HG changeset patch # User Lars Ellenberg # Date 1285672353 -7200 # Node ID 066f484922ec549f84ea59c138d4e6cf16b2e14b # Parent 5e309d18204045b882616fedeed7e315fc4907bf Low: add and use UNCONST_CAST_POINTER macro to avoid -Wqual-cast warnings This also removes unnecessary memcopy and excessive st

[Linux-ha-dev] [PATCH] Low: remove unused MAX_MESSAGE_SIZE define

2010-09-28 Thread Lars Ellenberg
# HG changeset patch # User Lars Ellenberg # Date 1285671995 -7200 # Node ID 5e309d18204045b882616fedeed7e315fc4907bf # Parent 0f791595cee4182dcfdb2dfa76a4b1d488c3dfd1 Low: remove unused MAX_MESSAGE_SIZE define This define is unused and of no meaning to the code since 2002. diff -r 0f791595cee4

Re: [Linux-ha-dev] Fix for external/ipmi

2010-09-28 Thread Holger . Teutsch
Hi Dejan, I understand. Indeed, the getconfignames interface is not very rich 8-) . - holger -Ursprüngliche Nachricht- Von: "Dejan Muhamedagic" Gesendet: Sep 24, 2010 6:22:30 PM An: "High-Availability Linux Development List" Betreff: Re: [Linux-ha-dev] Fix for external/ipmi >Hi Holger,