Re: [Linux-ha-dev] Add real monitoring capabilities to IPaddr2 resource agent

2011-02-11 Thread Robert Euhus
Thanks for your comments. Lars Marowsky-Bree schrieb: > On 2011-02-05T00:16:45, Lars Ellenberg wrote: > >> I do like this packet counter monitoring. > > So do I, but I'd just casually suggest that this may make sense as a > daemon, or at least per physical NIC - instead of per virtual IP. > I

Re: [Linux-ha-dev] Add real monitoring capabilities to IPaddr2 resource agent

2011-02-11 Thread Robert Euhus
Thanks for your comments. I have attached an updated version, although not everything has been worked in yet (see below). Lars Ellenberg schrieb: [..] + RX_PACKETS_NEW="`get_rx_packets`" + RX_PACKETS_OLD="$RX_PACKETS_NEW" ^^^ assign old here, only ok, done. + for n in `se

Re: [Linux-ha-dev] Feedback on conntrackd RA by Dominik Klein

2011-02-11 Thread Florian Haas
On 02/11/2011 01:41 PM, Dominik Klein wrote: > Maybe you applied the s/100/$slavescore patch someone sent a couple > weeks ago. I used the last version from thread "New stateful RA: > conntrackd" dated october 27th 3:29pm. > > Anyway, here's my version. Applied and pushed with two minor edits. Th

Re: [Linux-ha-dev] Feedback on conntrackd RA by Dominik Klein

2011-02-11 Thread Dominik Klein
Maybe you applied the s/100/$slavescore patch someone sent a couple weeks ago. I used the last version from thread "New stateful RA: conntrackd" dated october 27th 3:29pm. Anyway, here's my version. Regards Dominik On 02/11/2011 01:36 PM, Florian Haas wrote: > On 2011-02-11 09:48, Dominik Klein

Re: [Linux-ha-dev] Feedback on conntrackd RA by Dominik Klein

2011-02-11 Thread Florian Haas
On 2011-02-11 09:48, Dominik Klein wrote: > Hi Florian > >> it appears that the RA is good to be merged with just a few changes left >> to be done. > > Great! > > [lots of exemplary role-model patch modifications] > > Regards > Dominik Thanks! For some reason the patch does not apply in my che

Re: [Linux-ha-dev] Feedback on conntrackd RA by Dominik Klein

2011-02-11 Thread Dominik Klein
Hi Florian > it appears that the RA is good to be merged with just a few changes left > to be done. Great! > * Please fix the initialization to honor $OCF_FUNCTIONS_DIR and ditch > the redundant locale initialization. done > * Please rename the parameters to follow the precendents set by other