[Linux-ha-dev] [Patch] OCF_RESKEY_CRM_meta_timeout not matching monitor timeout meta-data.

2011-12-15 Thread renayama19661014
Hi All, I made the patch which revised the old next problem. * http://www.gossamer-threads.com/lists/linuxha/users/70262 In consideration of influence when a parameter was changed, I replace only a value of timeout. Please confirm my patch. And please commit a patch. Best Regards, Hideo

Re: [Linux-ha-dev] [Patch] OCF_RESKEY_CRM_meta_timeout not matching monitor timeout meta-data.

2011-12-15 Thread Dejan Muhamedagic
Hi Hideo-san, On Thu, Dec 15, 2011 at 06:21:00PM +0900, renayama19661...@ybb.ne.jp wrote: Hi All, I made the patch which revised the old next problem. * http://www.gossamer-threads.com/lists/linuxha/users/70262 In consideration of influence when a parameter was changed, I replace only

Re: [Linux-ha-dev] [Patch] OCF_RESKEY_CRM_meta_timeout not matching monitor timeout meta-data.

2011-12-15 Thread renayama19661014
Hi Dejan, Thank you for comment. It looks like a wrong place for a fix. Shouldn't crmd send all environment? It is only by chance that we have the timeout value available in this function. In the case of stop, crmd does not ask lrmd for the substitution of the parameter. . (snip)

Re: [Linux-ha-dev] [Patch] OCF_RESKEY_CRM_meta_timeout not matching monitor timeout meta-data.

2011-12-15 Thread Andrew Beekhof
On Thu, Dec 15, 2011 at 8:45 PM, renayama19661...@ybb.ne.jp wrote: Hi Dejan, Thank you for comment. It looks like a wrong place for a fix. Shouldn't crmd send all environment? It is only by chance that we have the timeout value available in this function. In the case of stop, crmd does

Re: [Linux-ha-dev] [Patch] OCF_RESKEY_CRM_meta_timeout not matching monitor timeout meta-data.

2011-12-15 Thread renayama19661014
Hi Andrew, Thank you for comment. When stopping, you always want to use the old parameters (think of someone changing 'ip' for an IPaddr resource). Options that are interpreted by the crmd or lrmd are a different matter which resulted in:

Re: [Linux-ha-dev] [Patch] OCF_RESKEY_CRM_meta_timeout not matching monitor timeout meta-data.

2011-12-15 Thread Andrew Beekhof
On Fri, Dec 16, 2011 at 1:21 PM, renayama19661...@ybb.ne.jp wrote: Hi Andrew, Thank you for comment. When stopping, you always want to use the old parameters (think of someone changing 'ip' for an IPaddr resource). Options that are interpreted by the crmd or lrmd are a different matter

Re: [Linux-ha-dev] [Patch] OCF_RESKEY_CRM_meta_timeout not matching monitor timeout meta-data.

2011-12-15 Thread renayama19661014
Hi Andrew, All right. Will you apply this correction to 1.0 of Pacemaker? Sure. We'll pick it up for .13 Many Thanks!! Hideo Yamauchi. --- On Fri, 2011/12/16, Andrew Beekhof and...@beekhof.net wrote: On Fri, Dec 16, 2011 at 1:21 PM,  renayama19661...@ybb.ne.jp wrote: Hi Andrew,