Re: [Linux-ha-dev] Patch : slapd : Even if kill command fails in terminate, return success.

2012-03-29 Thread nozawat
Hi Dejan >> Can we also do a global replace s/result/rc/? > OK,I contribute a patch again. I made this patch, I attach it. Regards, Tomo 2012年3月30日12:03 nozawat : > Hi Dejan > > Thank you for your reply. >> This patch doesn't look right. What if the first kill(1) fails >> (because, say, the pro

Re: [Linux-ha-dev] Patch : slapd : Even if kill command fails in terminate, return success.

2012-03-29 Thread nozawat
Hi Dejan Thank you for your reply. > This patch doesn't look right. What if the first kill(1) fails > (because, say, the process just exited)? And if '$result' is -ne > 0, then the while loop will finish anyway. Yes,And output an error in an origin of summons and retry it. because kill repaid retu

Re: [Linux-ha-dev] Patch : slapd : Even if kill command fails in terminate, return success.

2012-03-29 Thread Dejan Muhamedagic
Hi Tomo, On Tue, Mar 27, 2012 at 10:27:36AM +0900, nozawat wrote: > Hi > > Even if kill fails in terminate, return success. > When kill fails, this is the patch which I revised to return an error > definitely. This patch doesn't look right. What if the first kill(1) fails (because, say, the pr

Re: [Linux-ha-dev] [PATCH] SAPDatabase: Pull Request

2012-03-29 Thread Dejan Muhamedagic
Hi Alex, On Mon, Mar 26, 2012 at 04:22:19PM +0200, alexander.kra...@basf.com wrote: > Hi, > > just want to point your attention to this changed pull-request. > It was reviewed once by Dejan and afterwards changed by me. > > I'm just uncertain, if github has notifed the repo owners about this >