Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-16 Thread renayama19661014
Hi Lars, > Pushed to http://hg.linux-ha.org/glue We confirmed that a problem was settled with your patch. Many Thanks! Hideo Yamauchi. --- On Thu, 2012/5/17, Lars Ellenberg wrote: > On Wed, May 16, 2012 at 09:33:48AM +0900, renayama19661...@ybb.ne.jp wrote: > > Hi Lars, > > > > In the enviro

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-16 Thread Lars Ellenberg
On Wed, May 16, 2012 at 09:33:48AM +0900, renayama19661...@ybb.ne.jp wrote: > Hi Lars, > > In the environment where we confirmed leak, I confirm your patch. Pushed to http://hg.linux-ha.org/glue Thanks, -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulti

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-15 Thread renayama19661014
Hi Lars, Sorry...An answer was late. In the environment where we confirmed leak, I confirm your patch. Many Thanks, Hideo Yamauchi. --- On Wed, 2012/5/16, Lars Ellenberg wrote: > On Tue, May 15, 2012 at 11:14:53AM +0200, Lars Ellenberg wrote: > > On Mon, May 14, 2012 at 05:44:55PM +0200, Lars

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-15 Thread Lars Ellenberg
On Tue, May 15, 2012 at 11:14:53AM +0200, Lars Ellenberg wrote: > On Mon, May 14, 2012 at 05:44:55PM +0200, Lars Ellenberg wrote: > > > By the way, I suspect Lars' suggestion would work fine. I would > > > certainly explain what the "better" patch is in the comments when you > > > apply this one

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-15 Thread Lars Ellenberg
On Mon, May 14, 2012 at 05:44:55PM +0200, Lars Ellenberg wrote: > > By the way, I suspect Lars' suggestion would work fine. I would > > certainly explain what the "better" patch is in the comments when you > > apply this one. > > My suggestion would be: > > > diff --git a/lib/clplumbing/GSour

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-14 Thread Lars Ellenberg
On Wed, May 02, 2012 at 09:00:35PM -0600, Alan Robertson wrote: > This is very interesting. My apologies for missing this memory leak > :-(. The code logs memory usage periodically exactly to help notice > such a thing. > > In my new open source project [http://assimmon.org], I am death on >

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-08 Thread renayama19661014
Hi Alan, Thank you for comments. > FYI: there is code in the heartbeat communication layer which is quite happy > to simulate lost packets. > > I made it difficult to turn on accidentally. Read the code for details if > you're interested. All right. Many Thanks, Hideo Yamauchi. --- On Tue,

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-08 Thread Alan Robertson
FYI: there is code in the heartbeat communication layer which is quite happy to simulate lost packets. I made it difficult to turn on accidentally. Read the code for details if you're interested. On 04/30/2012 10:21 PM, renayama19661...@ybb.ne.jp wrote: > Hi Lars, > > We confirmed that this

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-02 Thread Alan Robertson
This is very interesting. My apologies for missing this memory leak :-(. The code logs memory usage periodically exactly to help notice such a thing. In my new open source project [http://assimmon.org], I am death on memory leaks. But I can assure you that back when that code was written, i

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-02 Thread renayama19661014
Hi Lars, Thank you for comments. > > > > And when it passes more than a full day > > > > * node1 > > 32126 ?        SLs   79:52      0   182 71189 24328  0.1 heartbeat: master > > control process                        > > > > * node2 > > 31928 ?        SLs   77:01      0   182 70869 240

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-02 Thread Lars Ellenberg
On Wed, May 02, 2012 at 10:43:36AM +0900, renayama19661...@ybb.ne.jp wrote: > Hi Lars, > > And when it passes more than a full day > > * node1 > 32126 ?SLs 79:52 0 182 71189 24328 0.1 heartbeat: master > control process > > * node2 > 31928 ?

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-05-01 Thread renayama19661014
Hi Lars, And when it passes more than a full day * node1 32126 ?SLs 79:52 0 182 71189 24328 0.1 heartbeat: master control process * node2 31928 ?SLs 77:01 0 182 70869 24008 0.1 heartbeat: master control process Best Regards, Hid

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-04-30 Thread renayama19661014
Hi Lars, We confirmed that this problem occurred with v1 mode of Heartbeat. * The problem happens with the v2 mode in the same way. We confirmed a problem in the next procedure. Step 1) Put a special device extinguishing a communication packet of Heartbeat in the network. Step 2) Between node

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-04-27 Thread renayama19661014
Hi Lars, Thank you for comments. > Have you actually been able to measure that memory leak you observed, > and you can confirm this patch will fix it? > > Because I don't think this patch has any effect. Yes. I really measured leak. I can show a result next week. #Japan is a holiday until Tuesd

Re: [Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-04-27 Thread Lars Ellenberg
On Thu, Apr 26, 2012 at 10:56:30AM +0900, renayama19661...@ybb.ne.jp wrote: > Hi All, > > We gave test that assumed remote cluster environment. > And we tested packet lost. > > The retransmission timer of Heartbeat causes memory leak. > > I donate a patch. > Please confirm the contents of the pa

[Linux-ha-dev] [Patch] The patch which revises memory leak.

2012-04-25 Thread renayama19661014
Hi All, We gave test that assumed remote cluster environment. And we tested packet lost. The retransmission timer of Heartbeat causes memory leak. I donate a patch. Please confirm the contents of the patch. And please reflect a patch in a repository of Heartbeat. Best Regards, Hideo Yamauchi.