Re: [PATCH v2 2/2] VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host()

2024-01-10 Thread Dan Carpenter
On Wed, Jan 10, 2024 at 04:03:28PM -0800, Kees Cook wrote: > > Oops, yes, thanks for fixing my confusion. Right, this is a direct write > across members into the flex array, not a composite destination. Yay > all the corner cases. :P Is there a document somewhere which explains what will trigger

Re: [PATCH v2 2/2] lib/string: shrink lib/string.i via IWYU

2024-01-10 Thread Kees Cook
On Tue, Jan 09, 2024 at 09:49:10PM +, Justin Stitt wrote: > On Thu, Dec 14, 2023 at 09:06:13PM +, tanz...@google.com wrote: > > This diff uses an open source tool include-what-you-use (IWYU) to modify > > the include list changing indirect includes to direct includes. > > IWYU is implemente

Re: [PATCH v2 2/2] VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host()

2024-01-10 Thread Kees Cook
On Mon, Jan 08, 2024 at 08:05:38PM -0600, Gustavo A. R. Silva wrote: > On 1/8/24 16:37, Kees Cook wrote: > > On Fri, Jan 05, 2024 at 08:40:00AM -0800, Harshit Mogalapalli wrote: > > > Syzkaller hit 'WARNING in dg_dispatch_as_host' bug. > > > > > > memcpy: detected field-spanning write (size 56) of

Re: [PATCH] ARM: unwind: Add missing "Call trace:" line

2024-01-10 Thread Linus Walleij
On Wed, Jan 10, 2024 at 10:56 PM Kees Cook wrote: > Every other architecture in Linux includes the line "Call trace:" before > backtraces. In some cases ARM would print "Backtrace:", but this was > only via 1 specific call path, and wasn't included in CPU Oops nor things > like KASAN, UBSAN, etc

[PATCH] ARM: unwind: Add missing "Call trace:" line

2024-01-10 Thread Kees Cook
Every other architecture in Linux includes the line "Call trace:" before backtraces. In some cases ARM would print "Backtrace:", but this was only via 1 specific call path, and wasn't included in CPU Oops nor things like KASAN, UBSAN, etc that called dump_stack(). Regularize this line so CI systems

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Guenter Roeck
On 1/10/24 12:34, Krzysztof Kozlowski wrote: On 10/01/2024 20:06, Guenter Roeck wrote: On 1/10/24 09:54, Krzysztof Kozlowski wrote: On 10/01/2024 16:54, Ninad Palsule wrote: Hello Krzysztof, On 1/10/24 09:37, Krzysztof Kozlowski wrote: On 10/01/2024 15:31, Ninad Palsule wrote: Hello Krzysz

[PATCH 2/2] arm64: defconfig: Enable PSTORE_RAM

2024-01-10 Thread Nícolas F . R . A . Prado
Enable PSTORE_RAM, that is the ramoops driver, in the defconfig, to allow logging and retrieving panics and oopses to/from RAM automatically for platforms that have a ramoops reserved memory node in DT. Signed-off-by: Nícolas F. R. A. Prado --- arch/arm64/configs/defconfig | 1 + 1 file change

[PATCH 1/2] pstore/ram: Register to module device table

2024-01-10 Thread Nícolas F . R . A . Prado
Register the compatible for this module on the module device table so it can be automatically loaded when a matching DT node is present, allowing logging of panics and oopses without any intervention. Signed-off-by: Nícolas F. R. A. Prado --- fs/pstore/ram.c | 1 + 1 file changed, 1 insertion(+

[PATCH 0/2] Enable PSTORE_RAM as a module in the arm64 defconfig

2024-01-10 Thread Nícolas F . R . A . Prado
This series enables the PSTORE_RAM config, aka the ramoops driver, in the defconfig. Nícolas F. R. A. Prado (2): pstore/ram: Register to module device table arm64: defconfig: Enable PSTORE_RAM arch/arm64/configs/defconfig | 1 + fs/pstore/ram.c | 1 + 2 files changed, 2 inser

Re: [GIT PULL] pstore updates for v6.8-rc1

2024-01-10 Thread pr-tracker-bot
The pull request you sent on Mon, 8 Jan 2024 10:24:29 -0800: > https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git > tags/pstore-v6.8-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/72116efd6307077546c93e0432a197876cedff70 Thank you! -- Deet-doot-dot,

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Krzysztof Kozlowski
On 10/01/2024 21:34, Krzysztof Kozlowski wrote: >> I have send it as a separate commit. >> https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ni...@linux.ibm.com/ > Why did you do that? It now just adds undocumented compatibles to the > driver. Please, as

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Krzysztof Kozlowski
On 10/01/2024 20:06, Guenter Roeck wrote: > On 1/10/24 09:54, Krzysztof Kozlowski wrote: >> On 10/01/2024 16:54, Ninad Palsule wrote: >>> Hello Krzysztof, >>> >>> >>> On 1/10/24 09:37, Krzysztof Kozlowski wrote: On 10/01/2024 15:31, Ninad Palsule wrote: > Hello Krzysztof, > > >

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Guenter Roeck
On 1/10/24 09:54, Krzysztof Kozlowski wrote: On 10/01/2024 16:54, Ninad Palsule wrote: Hello Krzysztof, On 1/10/24 09:37, Krzysztof Kozlowski wrote: On 10/01/2024 15:31, Ninad Palsule wrote: Hello Krzysztof, I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Krzysztof Kozlowski
On 10/01/2024 16:54, Ninad Palsule wrote: > Hello Krzysztof, > > > On 1/10/24 09:37, Krzysztof Kozlowski wrote: >> On 10/01/2024 15:31, Ninad Palsule wrote: >>> Hello Krzysztof, >>> >>> >>> >>> I have send it as a separate commit. >>> https://lore.kernel.org/linux-kernel/20231214144954.3

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Conor Dooley
On Wed, Jan 10, 2024 at 09:54:19AM -0600, Ninad Palsule wrote: > Hello Krzysztof, > > > On 1/10/24 09:37, Krzysztof Kozlowski wrote: > > On 10/01/2024 15:31, Ninad Palsule wrote: > > > Hello Krzysztof, > > > > > > > > > > > > > > > > I have send it as a separate commit. > > > > > > > https://

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Ninad Palsule
Hello Krzysztof, On 1/10/24 09:37, Krzysztof Kozlowski wrote: On 10/01/2024 15:31, Ninad Palsule wrote: Hello Krzysztof, I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ni...@linux.ibm.com/ Why did you do that? It now just adds undocumen

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Krzysztof Kozlowski
On 10/01/2024 15:31, Ninad Palsule wrote: > Hello Krzysztof, > > > > I have send it as a separate commit. > https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ni...@linux.ibm.com/ Why did you do that? It now just adds undocumented compatibles to the driver. Please,

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Ninad Palsule
Hello Krzysztof, I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ni...@linux.ibm.com/ Why did you do that? It now just adds undocumented compatibles to the driver. Please, as Rob requested, work with Lukas on his series to make sure that the