Re: [PATCH v3 7/7] kunit: Add tests for fault

On Fri, Apr 19, 2024 at 03:33:49PM -0700, Guenter Roeck wrote: > Hi, > > On Tue, Mar 19, 2024 at 11:48:57AM +0100, Mickaël Salaün wrote: > > Add a test case to check NULL pointer dereference and make sure it would > > result as a failed test. > > > > The full kunit_fault test suite is marked as s

Re: [PATCH v3 7/7] kunit: Add tests for fault

Hi, On Tue, Mar 19, 2024 at 11:48:57AM +0100, Mickaël Salaün wrote: > Add a test case to check NULL pointer dereference and make sure it would > result as a failed test. > > The full kunit_fault test suite is marked as skipped when run on UML > because it would result to a kernel panic. > > Test

Re: [PATCH v3] arm64: hibernate: Fix level3 translation fault in swsusp_save()

On Wed, 17 Apr 2024 10:52:48 +0800, Yaxiong Tian wrote: > On ARM64 machines using UEFI, if can_set_direct_map() return false by > setting some CONFIGS in kernel build or grub,such as > NO CONFIG_DEBUG_PAGEALLOC_ENABLE_DEFAULT、NO CONFIG_KFENCE > NO CONFIG_RODATA_FULL_DEFAULT_ENABLED.Also with settin

Re: [PATCH 0/5] string: Merge separate tests into string_kunit.c

On 4/19/24 15:01, Kees Cook wrote: Hi, We have a few lone function tests (strscpy and strcat) that are better collected into the common string_kunit.c test suite. Perform various renamings, merge everything, and clean up after them. -Kees Kees Cook (5): string: Prepare to merge strscpy_kuni

Re: [PATCH v3] arm64: hibernate: Fix level3 translation fault in swsusp_save()

On Wed, Apr 17, 2024 at 10:52:48AM +0800, Yaxiong Tian wrote: > On ARM64 machines using UEFI, if can_set_direct_map() return false by > setting some CONFIGS in kernel build or grub,such as > NO CONFIG_DEBUG_PAGEALLOC_ENABLE_DEFAULT、NO CONFIG_KFENCE > NO CONFIG_RODATA_FULL_DEFAULT_ENABLED.Also with

Re: [PATCH 0/5] string: Merge separate tests into string_kunit.c

On Fri, Apr 19, 2024 at 5:02 PM Kees Cook wrote: > > Hi, > > We have a few lone function tests (strscpy and strcat) that are better > collected into the common string_kunit.c test suite. Perform various > renamings, merge everything, and clean up after them. All makes sense to me, thanks for doin

[PATCH 2/5] string: Merge strscpy KUnit tests into string_kunit.c

Move the strscpy() tests into string_kunit.c. Remove the separate Kconfig and Makefile rule. Signed-off-by: Kees Cook --- Cc: Andy Shevchenko Cc: Ivan Orlov Cc: linux-hardening@vger.kernel.org --- MAINTAINERS | 1 - lib/Kconfig.debug | 5 -- lib/Makefile| 1 - lib/strin

[PATCH 4/5] string: Merge strcat KUnit tests into string_kunit.c

Move the strcat() tests into string_kunit.c. Remove the separate Kconfig and Makefile rule. Signed-off-by: Kees Cook --- Cc: Andy Shevchenko Cc: Ivan Orlov Cc: linux-hardening@vger.kernel.org --- MAINTAINERS| 1 - lib/Kconfig.debug | 5 --- lib/Makefile | 1 - lib/strcat_k

[PATCH 5/5] string: Convert KUnit test names to standard convention

The KUnit convention for test names is AREA_test_WHAT. Adjust the string test names to follow this pattern. Signed-off-by: Kees Cook --- Cc: Andy Shevchenko Cc: Ivan Orlov Cc: linux-hardening@vger.kernel.org --- lib/string_kunit.c | 72 +++--- 1 file cha

[PATCH 3/5] string: Prepare to merge strcat KUnit tests into string_kunit.c

The test naming convention differs between string_kunit.c and strcat_kunit.c. Move "test" to the beginning of the function name. Signed-off-by: Kees Cook --- Cc: Andy Shevchenko Cc: Ivan Orlov Cc: linux-hardening@vger.kernel.org --- lib/strcat_kunit.c | 12 ++-- 1 file changed, 6 inser

[PATCH 0/5] string: Merge separate tests into string_kunit.c

Hi, We have a few lone function tests (strscpy and strcat) that are better collected into the common string_kunit.c test suite. Perform various renamings, merge everything, and clean up after them. -Kees Kees Cook (5): string: Prepare to merge strscpy_kunit.c into string_kunit.c string: Merg

[PATCH 1/5] string: Prepare to merge strscpy_kunit.c into string_kunit.c

In preparation for moving the strscpy_kunit.c tests into string_kunit.c, rename "tc" to "strscpy_check" for better readability. Signed-off-by: Kees Cook --- Cc: Andy Shevchenko Cc: Ivan Orlov Cc: linux-hardening@vger.kernel.org --- lib/strscpy_kunit.c | 51 +++--