Re: [PATCH] auxdisplay: Use sizeof(*pointer) instead of sizeof(type)

2024-06-03 Thread Geert Uytterhoeven
gned-off-by: Erick Archer Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talki

Re: [PATCH] lib: stackinit: Adjust target string to 8 bytes for m68k

2024-02-27 Thread Geert Uytterhoeven
s happened, and move the KUNIT check outside of the consecutive > calls to minimize what happens between them. Thanks for your patch! > Reported-by: Guenter Roeck > Closes: > https://lore.kernel.org/lkml/a0d10d50-2720-4ecd-a2c6-c2c5e5aee...@roeck-us.net/ Do reports have an expiratio

Re: [PATCH 03/10] scsi: NCR5380: Replace snprintf() with the safer scnprintf() variant

2024-02-08 Thread Geert Uytterhoeven
ance->can_queue, instance->cmd_per_lun, > +instance->sg_tablesize, instance->this_id, > +hostdata->flags & FLAG_DMA_FIXUP ? "DMA_FIXUP " : "", > +hostdata->flags & FLAG_NO_PSEUDO_DMA ? &

Re: [PATCH v2 2/4] string: Allow 2-argument strscpy()

2024-02-05 Thread Geert Uytterhoeven
Hi Kees, On Mon, Feb 5, 2024 at 2:01 PM Kees Cook wrote: > On Mon, Feb 05, 2024 at 01:47:08PM +0100, Geert Uytterhoeven wrote: > > > +/* > > > + * The 2 argument style can only be used when dst is an array with a > > > + * known size. > > >

Re: [PATCH v2 4/4] um: Convert strscpy() usage to 2-argument style

2024-02-05 Thread Geert Uytterhoeven
t, src, sizeof(dst)) (dst), (src) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talkin

Re: [PATCH v2 3/4] string: Allow 2-argument strscpy_pad()

2024-02-05 Thread Geert Uytterhoeven
__wrote;\ > -}) > +#define strscpy_pad(dst, src, ...) \ > + CONCATENATE(__strscpy_pad, COUNT_ARGS(__VA_ARGS__))(dst, src, > __VA_ARGS__) Likewise, Gr{oetje,eeting}s, Geert -- Geert Uytterh

Re: [PATCH v2 2/4] string: Allow 2-argument strscpy()

2024-02-05 Thread Geert Uytterhoeven
be > + * zero padded. If padding is desired please use strscpy_pad(). > + * > + * Returns the number of characters copied in @dst (not including the > + * trailing %NUL) or -E2BIG if @size is 0 or the copy from @src was > + * truncated. > + */ > +#define strscpy(dst, src, .

Re: rcar-dmac.c: race condition regarding cookie handling?

2024-01-29 Thread Geert Uytterhoeven
Hi Kees, On Mon, Jan 29, 2024 at 6:38 PM Kees Cook wrote> > On Mon, Jan 29, 2024 at 10:57:40AM +0100, Geert Uytterhoeven wrote: > > CC Kees (for the wrap-around in dma_cookie_assign() not handled in [A]) > > [...] > > Was the system running for a very long time? > >

Re: [PATCH 27/82] m68k: Refactor intentional wrap-around calculation

2024-01-23 Thread Geert Uytterhoeven
Hi Eero, On Tue, Jan 23, 2024 at 2:30 PM Eero Tamminen wrote: > On 23.1.2024 10.13, Geert Uytterhoeven wrote: > > On Tue, Jan 23, 2024 at 1:35 AM Kees Cook wrote: > >> In an effort to separate intentional arithmetic wrap-around from > >> unexpected wrap-around, we n

Re: [PATCH 27/82] m68k: Refactor intentional wrap-around calculation

2024-01-23 Thread Geert Uytterhoeven
nk: https://github.com/KSPP/linux/issues/26 [2] > Link: https://github.com/KSPP/linux/issues/27 [3] > Link: https://github.com/KSPP/linux/issues/344 [4] > Cc: Geert Uytterhoeven > Cc: Andrew Morton > Cc: Arnd Bergmann > Cc: Liam Howlett > Cc: "Matthew Wilcox (Oracle)"

Re: the nul-terminated string helper desk chair rearrangement

2023-10-26 Thread Geert Uytterhoeven
uld mean we need a way to find the index too! ctags? Although "git grep" is faster (assumed you use the "correct" search pattern, which can sometimes be challenging, indeed). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond