Re: [PATCH v4 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-11 Thread Guenter Roeck
off-by: Steven Rostedt (Google) Reviewed-by: Guenter Roeck --- Changes since v3: https://lore.kernel.org/linux-trace-kernel/20240606150316.916395...@goodmis.org - Change type of start and size to phys_addr_t fs/pstore/ram.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [PATCH v4 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-11 Thread Guenter Roeck
On 6/11/24 14:56, Steven Rostedt wrote: From: "Steven Rostedt (Google)" In order to allow for requesting a memory region that can be used for things like pstore on multiple machines where the memory layout is not the same, add a new option to the kernel command line called "reserve_mem". The

Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-11 Thread Guenter Roeck
On 6/11/24 07:40, Wei Yang wrote: [ ... ] +/* Keep a table to reserve named memory */ +#define RESERVE_MEM_MAX_ENTRIES8 +#define RESERVE_MEM_NAME_SIZE 16 ^ Suggest to align with previous line. It _is_ aligned. It just looks

Re: [PATCH v3 7/7] kunit: Add tests for fault

2024-04-22 Thread Guenter Roeck
On 4/22/24 06:08, Mickaël Salaün wrote: On Fri, Apr 19, 2024 at 04:38:01PM -0700, Guenter Roeck wrote: On Fri, Apr 19, 2024 at 03:33:49PM -0700, Guenter Roeck wrote: Hi, On Tue, Mar 19, 2024 at 11:48:57AM +0100, Mickaël Salaün wrote: Add a test case to check NULL pointer dereference and make

Re: [PATCH v3 7/7] kunit: Add tests for fault

2024-04-19 Thread Guenter Roeck
On Fri, Apr 19, 2024 at 03:33:49PM -0700, Guenter Roeck wrote: > Hi, > > On Tue, Mar 19, 2024 at 11:48:57AM +0100, Mickaël Salaün wrote: > > Add a test case to check NULL pointer dereference and make sure it would > > result as a failed test. > > > > The full

Re: [PATCH v3 7/7] kunit: Add tests for fault

2024-04-19 Thread Guenter Roeck
Hi, On Tue, Mar 19, 2024 at 11:48:57AM +0100, Mickaël Salaün wrote: > Add a test case to check NULL pointer dereference and make sure it would > result as a failed test. > > The full kunit_fault test suite is marked as skipped when run on UML > because it would result to a kernel panic. > >

[PATCH] Revert "kunit: memcpy: Split slow memcpy tests into MEMCPY_SLOW_KUNIT_TEST"

2024-03-14 Thread Guenter Roeck
p the slow tests is no longer needed. Revert the patch introducing it. Cc: David Gow Cc: Kees Cook Signed-off-by: Guenter Roeck --- lib/Kconfig.debug | 12 lib/memcpy_kunit.c | 3 --- 2 files changed, 15 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 21

Re: [PATCH] lib: stackinit: Adjust target string to 8 bytes for m68k

2024-02-27 Thread Guenter Roeck
ned, and move the KUNIT check outside of the consecutive > calls to minimize what happens between them. > > Reported-by: Guenter Roeck > Closes: > https://lore.kernel.org/lkml/a0d10d50-2720-4ecd-a2c6-c2c5e5aee...@roeck-us.net/ > Signed-off-by: Kees Cook Hmm, guess I misunderstood

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Guenter Roeck
On 1/10/24 12:34, Krzysztof Kozlowski wrote: On 10/01/2024 20:06, Guenter Roeck wrote: On 1/10/24 09:54, Krzysztof Kozlowski wrote: On 10/01/2024 16:54, Ninad Palsule wrote: Hello Krzysztof, On 1/10/24 09:37, Krzysztof Kozlowski wrote: On 10/01/2024 15:31, Ninad Palsule wrote: Hello

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Guenter Roeck
On 1/10/24 09:54, Krzysztof Kozlowski wrote: On 10/01/2024 16:54, Ninad Palsule wrote: Hello Krzysztof, On 1/10/24 09:37, Krzysztof Kozlowski wrote: On 10/01/2024 15:31, Ninad Palsule wrote: Hello Krzysztof, I have send it as a separate commit.

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2023-12-12 Thread Guenter Roeck
On 12/12/23 10:51, Conor Dooley wrote: On Tue, Dec 12, 2023 at 10:00:39AM -0800, Guenter Roeck wrote: On Tue, Dec 12, 2023 at 05:15:51PM +, Conor Dooley wrote: On Tue, Dec 12, 2023 at 10:40:03AM -0600, Ninad Palsule wrote: From: Joel Stanley The NPCT75x TPM is TIS compatible. It has

Re: [PATCH v1 2/8] dt-bindings: tpm: Add schema for TIS I2C devices

2023-12-12 Thread Guenter Roeck
On Tue, Dec 12, 2023 at 05:14:26PM +, Conor Dooley wrote: > Hey, > > On Tue, Dec 12, 2023 at 10:39:58AM -0600, Ninad Palsule wrote: > > From: Johannes Holland > > > > Add a dt schema to support device tree bindings > > "Add bindings for..." > > > for the generic I2C > > physical layer.

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2023-12-12 Thread Guenter Roeck
On Tue, Dec 12, 2023 at 05:15:51PM +, Conor Dooley wrote: > On Tue, Dec 12, 2023 at 10:40:03AM -0600, Ninad Palsule wrote: > > From: Joel Stanley > > > > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. > > > >

Re: [PATCH] hwmon: (pc87360) Bounds check data->innr usage

2023-11-30 Thread Guenter Roeck
elvare Cc: Guenter Roeck Cc: linux-hw...@vger.kernel.org Signed-off-by: Kees Cook Looks good to me. Reviewed-by: Gustavo A. R. Silva Guess I'll apply it, even though it is quite pointless. But arguing against such changes seems like shouting into the wind, so whatever. There are several

Re: [PATCH v2][next] hwmon: (aspeed-pwm-tacho) Fix -Wstringop-overflow warning in aspeed_create_fan_tach_channel()

2023-11-15 Thread Guenter Roeck
On Tue, Nov 14, 2023 at 01:53:08PM -0600, Gustavo A. R. Silva wrote: > Based on the documentation below, the maximum number of Fan tach > channels is 16: > > Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt:45: > 45 - aspeed,fan-tach-ch : should specify the Fan tach input channel. >

Re: [PATCH][next] hwmon: (aspeed-pwm-tacho) Fix -Wstringop-overflow warning in aspeed_create_fan_tach_channel()

2023-11-14 Thread Guenter Roeck
On Mon, Nov 13, 2023 at 01:38:12PM -0600, Gustavo A. R. Silva wrote: > Based on the documentation below, the maximum number of Fan tach > channels is 16: > > Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt:45: > 45 - aspeed,fan-tach-ch : should specify the Fan tach input channel. >

Re: [PATCH 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered

2023-11-03 Thread Guenter Roeck
her one until the "bark" interrupt is cleared and asserts again. > > This matches how many older Qualcomm SoCs have things configured. > > Fixes: 28cc13e4060c ("arm64: dts: qcom: sc7180: Add watchdog bark interrupt") > Signed-off-by: Douglas Anderson Reviewed-by

Re: [PATCH v3] hwmon: refactor deprecated strncpy

2023-09-27 Thread Guenter Roeck
On Thu, Sep 21, 2023 at 05:41:46AM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > Let's refactor this kcalloc() + strncpy() into a kmemdup_nul() which has > more obvious behavior and is less error prone. > > To avoid truncating the