Re: [PATCH v2 4/7] kunit: Handle test faults

2024-03-11 Thread Rae Moar
ns. First, do you mean here "setting try_result with -EINTR" instead? But happy to add the tested-by. Tested-by: Rae Moar Thanks! -Rae > the test passed. > > Fix kunit_generic_run_threadfn_adapter() signature by returning 0 > instead of calling kthread_complete_and_exit(

Re: [PATCH v2 3/7] kunit: Fix timeout message

2024-03-05 Thread Rae Moar
On Fri, Mar 1, 2024 at 2:40 PM Mickaël Salaün wrote: > > The exit code is always checked, so let's properly handle the -ETIMEDOUT > error code. Hello! This change looks good to me. Thanks! -Rae Reviewed-by: Rae Moar > > Cc: Brendan Higgins > Cc: David Gow > Cc: Rae M

Re: [PATCH v2 2/7] kunit: Fix kthread reference

2024-03-05 Thread Rae Moar
On Fri, Mar 1, 2024 at 2:40 PM Mickaël Salaün wrote: > > There is a race condition when a kthread finishes after the deadline and > before the call to kthread_stop(), which may lead to use after free. Hello! I have tested this patch and it looks good to me. Thanks! -Rae Reviewed-by:

Re: [PATCH v2 1/7] kunit: Handle thread creation error

2024-03-05 Thread Rae Moar
; code returned by kthread_run(), which will mark the test as failed and > print "internal error occurred...". Hello! I have tested this and this fix looks good to me. Thanks! -Rae Reviewed-by: Rae Moar > > Cc: Brendan Higgins > Cc: David Gow > Cc: Rae Moar > Cc: Shuah K