Re: [PATCH] cap_syslog: remove CAP_SYS_ADMIN when dmesg_restrict

2024-02-01 Thread Kees Cook
On Fri, 05 Jan 2024 14:20:07 +0800, Jingzi Meng wrote: > CAP_SYSLOG was separated from CAP_SYS_ADMIN and introduced in Linux > 2.6.37 (2010-11). For a long time, certain syslog actions required > CAP_SYS_ADMIN or CAP_SYSLOG. Maybe it’s time to officially remove > CAP_SYS_ADMIN for more

Re: [PATCH] cap_syslog: remove CAP_SYS_ADMIN when dmesg_restrict

2024-01-14 Thread 孟敬姿
I tested on ubuntu 22.04.3 LTS kernel 6.2.16 and Fedora 39 kernel 6.6.11, the warning is gone, and CAP_SYS_ADMIN is no longer authorized to bypass check_syslog_permissions(). Best regards, Jingzi

Re: [PATCH] cap_syslog: remove CAP_SYS_ADMIN when dmesg_restrict

2024-01-08 Thread Kees Cook
On Fri, Jan 05, 2024 at 02:20:07PM +0800, Jingzi Meng wrote: > CAP_SYSLOG was separated from CAP_SYS_ADMIN and introduced in Linux > 2.6.37 (2010-11). For a long time, certain syslog actions required > CAP_SYS_ADMIN or CAP_SYSLOG. Maybe it’s time to officially remove > CAP_SYS_ADMIN for more

Re: [PATCH] cap_syslog: remove CAP_SYS_ADMIN when dmesg_restrict

2024-01-07 Thread 孟敬姿
On Fri 2024-01-05 09:49:44, Theodore Ts'o wrote: It's unclear to me what goal you have in trying to mess with the capability definitions? Perhaps it might be useful if you were to explicitly state your goals in these proposals? Petr is right, we are trying to resolve the overlap problem of

Re: [PATCH] cap_syslog: remove CAP_SYS_ADMIN when dmesg_restrict

2024-01-05 Thread Petr Mladek
On Fri 2024-01-05 09:49:44, Theodore Ts'o wrote: > On Fri, Jan 05, 2024 at 02:20:07PM +0800, Jingzi Meng wrote: > > CAP_SYSLOG was separated from CAP_SYS_ADMIN and introduced in Linux > > 2.6.37 (2010-11). For a long time, certain syslog actions required > > CAP_SYS_ADMIN or CAP_SYSLOG. Maybe it’s

Re: [PATCH] cap_syslog: remove CAP_SYS_ADMIN when dmesg_restrict

2024-01-05 Thread Theodore Ts'o
On Fri, Jan 05, 2024 at 02:20:07PM +0800, Jingzi Meng wrote: > CAP_SYSLOG was separated from CAP_SYS_ADMIN and introduced in Linux > 2.6.37 (2010-11). For a long time, certain syslog actions required > CAP_SYS_ADMIN or CAP_SYSLOG. Maybe it’s time to officially remove > CAP_SYS_ADMIN for more

[PATCH] cap_syslog: remove CAP_SYS_ADMIN when dmesg_restrict

2024-01-04 Thread Jingzi Meng
CAP_SYSLOG was separated from CAP_SYS_ADMIN and introduced in Linux 2.6.37 (2010-11). For a long time, certain syslog actions required CAP_SYS_ADMIN or CAP_SYSLOG. Maybe it’s time to officially remove CAP_SYS_ADMIN for more fine-grained control. CAP_SYS_ADMIN was once removed but added back for