Re: [PATCH] sfc: replace deprecated strncpy with strscpy

2023-10-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Thu, 12 Oct 2023 20:38:19 + you wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > `desc`

Re: [PATCH] sfc: replace deprecated strncpy with strscpy

2023-10-12 Thread Kees Cook
On Thu, Oct 12, 2023 at 08:38:19PM +, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > `desc` is expected to be NUL-terminated as evident by the manual >

Re: [PATCH] sfc: replace deprecated strncpy with strscpy

2023-10-12 Thread Edward Cree
On 12/10/2023 21:38, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > `desc` is expected to be NUL-terminated as evident by the manual > NUL-byte assignment.

[PATCH] sfc: replace deprecated strncpy with strscpy

2023-10-12 Thread Justin Stitt
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. `desc` is expected to be NUL-terminated as evident by the manual NUL-byte assignment. Moreover, NUL-padding does not seem to be necessary. The