Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-13 Thread Kees Cook
On June 13, 2024 7:06:47 AM PDT, Ard Biesheuvel wrote: >On Thu, 13 Jun 2024 at 15:26, Steven Rostedt wrote: >> >> On Thu, 13 Jun 2024 08:11:48 +0200 >> Ard Biesheuvel wrote: >> > > >> > > I've added one more comment to v5, with that fixed I can take this. >> > > >> > >> > So how is this suppo

Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-13 Thread Steven Rostedt
On Thu, 13 Jun 2024 16:06:47 +0200 Ard Biesheuvel wrote: > Fair enough. As long as it is documented that there is no guarantee > that this will keep working over a kernel upgrade, then I have no > objections. Thanks, I'll send out v6 and even stress that this may not work for all kernel version

Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-13 Thread Ard Biesheuvel
On Thu, 13 Jun 2024 at 15:26, Steven Rostedt wrote: > > On Thu, 13 Jun 2024 08:11:48 +0200 > Ard Biesheuvel wrote: > > > > > > I've added one more comment to v5, with that fixed I can take this. > > > > > > > So how is this supposed to work wrt to the rigid 'no user visible > > regressions' rule,

Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-13 Thread Steven Rostedt
On Thu, 13 Jun 2024 08:11:48 +0200 Ard Biesheuvel wrote: > > > > I've added one more comment to v5, with that fixed I can take this. > > > > So how is this supposed to work wrt to the rigid 'no user visible > regressions' rule, given that this whole thing is a best effort thing This has nothin

Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-12 Thread Ard Biesheuvel
On Thu, 13 Jun 2024 at 08:04, Mike Rapoport wrote: > > On Wed, Jun 12, 2024 at 02:52:28PM -0400, Steven Rostedt wrote: > > On Wed, 12 Jun 2024 11:45:57 -0700 > > Kees Cook wrote: > > > > > On Tue, Jun 11, 2024 at 10:49:13AM -0400, Steven Rostedt wrote: > > > > From: "Steven Rostedt (Google)" > >

Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-12 Thread Mike Rapoport
On Wed, Jun 12, 2024 at 02:52:28PM -0400, Steven Rostedt wrote: > On Wed, 12 Jun 2024 11:45:57 -0700 > Kees Cook wrote: > > > On Tue, Jun 11, 2024 at 10:49:13AM -0400, Steven Rostedt wrote: > > > From: "Steven Rostedt (Google)" > > > > > > Add a method to find a region specified by reserve_mem=

Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-12 Thread Steven Rostedt
On Wed, 12 Jun 2024 11:45:57 -0700 Kees Cook wrote: > On Tue, Jun 11, 2024 at 10:49:13AM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > Add a method to find a region specified by reserve_mem=nn:align:name for > > ramoops. Adding a kernel command line parameter: > > >

Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-12 Thread Kees Cook
On Tue, Jun 11, 2024 at 10:49:13AM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Add a method to find a region specified by reserve_mem=nn:align:name for > ramoops. Adding a kernel command line parameter: > > reserve_mem=12M:4096:oops ramoops.mem_name=oops > > Will use th

[PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

2024-06-11 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Add a method to find a region specified by reserve_mem=nn:align:name for ramoops. Adding a kernel command line parameter: reserve_mem=12M:4096:oops ramoops.mem_name=oops Will use the size and location defined by the memmap parameter where it finds the memory an