[PATCH 2/2] DT: add binding documentation for STTS751

2016-09-07 Thread Andrea Merello
Signed-off-by: Andrea Merello Cc: Rob Herring Cc: Mark Rutland --- Documentation/devicetree/bindings/hwmon/stts751.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/stts751.txt diff --git a/Documentation/devicetree/bindin

[PATCH 1/2] hwmon: new driver for ST stts751 thermal sensor

2016-09-07 Thread Andrea Merello
This patch adds a HWMON driver for ST Microelectronics STTS751 temperature sensors. It does support manual-triggered conversions as well as automatic conversions. The latter is used when the "event" or "therm" function is present (declaring the physical wire is attached in the DT). Thanks-to: LAB

Re: [PATCH 1/2] hwmon: new driver for ST stts751 thermal sensor

2016-09-07 Thread LABBE Corentin
Hello I have some coments below On Wed, Sep 07, 2016 at 02:33:36PM +0200, Andrea Merello wrote: > This patch adds a HWMON driver for ST Microelectronics STTS751 > temperature sensors. > > It does support manual-triggered conversions as well as automatic > conversions. The latter is used when the

Re: [PATCH 1/2] hwmon: new driver for ST stts751 thermal sensor

2016-09-07 Thread Guenter Roeck
On 09/07/2016 06:16 AM, LABBE Corentin wrote: Hello I have some coments below Some more comments below. On Wed, Sep 07, 2016 at 02:33:36PM +0200, Andrea Merello wrote: This patch adds a HWMON driver for ST Microelectronics STTS751 temperature sensors. It does support manual-triggered conve

Re: [PATCH 1/2] hwmon: new driver for ST stts751 thermal sensor

2016-09-07 Thread Guenter Roeck
On 09/07/2016 08:03 AM, Andrea Merello wrote: On Wed, Sep 7, 2016 at 4:07 PM, Guenter Roeck mailto:li...@roeck-us.net>> wrote: On 09/07/2016 06:16 AM, LABBE Corentin wrote: Hello I have some coments below Some more comments below. On Wed, Sep 07, 2016 at 02:

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-07 Thread Hoan Tran
Hi Guenter, On Tue, Sep 6, 2016 at 11:39 PM, Guenter Roeck wrote: > On 09/06/2016 11:07 PM, Hoan Tran wrote: >> >> Hi Guenter, >> >> On Tue, Sep 6, 2016 at 10:50 PM, Guenter Roeck wrote: >>> >>> On 09/06/2016 10:21 PM, Hoan Tran wrote: Hi Guenter, Thank for your quick re

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-07 Thread Guenter Roeck
On Wed, Sep 07, 2016 at 11:55:06AM -0700, Hoan Tran wrote: > Hi Guenter, > > On Tue, Sep 6, 2016 at 11:39 PM, Guenter Roeck wrote: > > On 09/06/2016 11:07 PM, Hoan Tran wrote: > >> > >> Hi Guenter, > >> > >> On Tue, Sep 6, 2016 at 10:50 PM, Guenter Roeck wrote: > >>> > >>> On 09/06/2016 10:21 PM

Re: [PATCH] hwmon: xgene: Fix crash when alarm occurs before driver probe

2016-09-07 Thread Hoan Tran
Hi Guenter, On Wed, Sep 7, 2016 at 12:24 PM, Guenter Roeck wrote: > On Wed, Sep 07, 2016 at 11:55:06AM -0700, Hoan Tran wrote: >> Hi Guenter, >> >> On Tue, Sep 6, 2016 at 11:39 PM, Guenter Roeck wrote: >> > On 09/06/2016 11:07 PM, Hoan Tran wrote: >> >> >> >> Hi Guenter, >> >> >> >> On Tue, Sep

Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver

2016-09-07 Thread Arnd Bergmann
On Thursday, July 21, 2016 1:55:56 PM CEST Hoan Tran wrote: > + ctx->comm_base_addr = cppc_ss->base_address; > + if (ctx->comm_base_addr) { > + ctx->pcc_comm_addr = > + acpi_os_ioremap(ctx->comm_base_addr, > +

Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver

2016-09-07 Thread Guenter Roeck
On Wed, Sep 07, 2016 at 11:41:44PM +0200, Arnd Bergmann wrote: > On Thursday, July 21, 2016 1:55:56 PM CEST Hoan Tran wrote: > > + ctx->comm_base_addr = cppc_ss->base_address; > > + if (ctx->comm_base_addr) { > > + ctx->pcc_comm_addr = > > +

Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver

2016-09-07 Thread Guenter Roeck
On Wed, Sep 07, 2016 at 11:41:44PM +0200, Arnd Bergmann wrote: > On Thursday, July 21, 2016 1:55:56 PM CEST Hoan Tran wrote: > > + ctx->comm_base_addr = cppc_ss->base_address; > > + if (ctx->comm_base_addr) { > > + ctx->pcc_comm_addr = > > +