Re: [PATCH v2] hwmon: Update documentation to clarify rules for the 'name' attribute

2017-01-25 Thread Jean Delvare
On Wed, 25 Jan 2017 01:28:02 -0800, Guenter Roeck wrote: > Clarify that the name attribute must report a valid name, and the rules > for valid names. Also clarify that the name parameter must be provided > for all supported API functions. > > Signed-off-by: Guenter Roeck > --- > v2: '.' is an acc

Re: [PATCH v3] hwmon: Make name attribute mandatory for new APIs

2017-01-25 Thread Jean Delvare
On Wed, 25 Jan 2017 01:34:40 -0800, Guenter Roeck wrote: > It does not make sense to use one of the the new APIs when not > even providing a name attribute. Make it mandatory. > > Signed-off-by: Guenter Roeck > --- > v3: hwmon_device_register() needs to call __hwmon_device_register() directly. >

Re: [PATCH v3 1/2] hwmon: new driver for ST stts751 thermal sensor

2017-01-25 Thread Guenter Roeck
On 01/25/2017 03:00 AM, Andrea Merello wrote: On Wed, Jan 25, 2017 at 11:53 AM, Guenter Roeck wrote: On 01/25/2017 01:51 AM, Andrea Merello wrote: On Tue, Jan 24, 2017 at 9:18 PM, Guenter Roeck wrote: On Tue, Jan 24, 2017 at 04:02:20PM +0100, Andrea Merello wrote: This patch adds a HWMON

Re: [PATCH v3 1/2] hwmon: new driver for ST stts751 thermal sensor

2017-01-25 Thread Andrea Merello
On Wed, Jan 25, 2017 at 11:53 AM, Guenter Roeck wrote: > On 01/25/2017 01:51 AM, Andrea Merello wrote: >> >> On Tue, Jan 24, 2017 at 9:18 PM, Guenter Roeck wrote: >>> >>> On Tue, Jan 24, 2017 at 04:02:20PM +0100, Andrea Merello wrote: This patch adds a HWMON driver for ST Microelectroni

Re: [PATCH v3 1/2] hwmon: new driver for ST stts751 thermal sensor

2017-01-25 Thread Guenter Roeck
On 01/25/2017 01:51 AM, Andrea Merello wrote: On Tue, Jan 24, 2017 at 9:18 PM, Guenter Roeck wrote: On Tue, Jan 24, 2017 at 04:02:20PM +0100, Andrea Merello wrote: This patch adds a HWMON driver for ST Microelectronics STTS751 temperature sensors. It does support manual-triggered conversions

Re: [PATCH v3 1/2] hwmon: new driver for ST stts751 thermal sensor

2017-01-25 Thread Andrea Merello
On Tue, Jan 24, 2017 at 9:18 PM, Guenter Roeck wrote: > On Tue, Jan 24, 2017 at 04:02:20PM +0100, Andrea Merello wrote: >> This patch adds a HWMON driver for ST Microelectronics STTS751 >> temperature sensors. >> >> It does support manual-triggered conversions as well as automatic >> conversions.

Re: [PATCH] hwmon: Update documentation to clarify rules for the 'name' attribute

2017-01-25 Thread Guenter Roeck
On 01/25/2017 01:14 AM, Jean Delvare wrote: Hi Guenter, On Tue, 24 Jan 2017 20:26:34 -0800, Guenter Roeck wrote: Clarify that the name attribute must report a valid name, and the rules for valid names. Also clarify that the name parameter must be provided for all supported API functions. Signe

[PATCH v3] hwmon: Make name attribute mandatory for new APIs

2017-01-25 Thread Guenter Roeck
It does not make sense to use one of the the new APIs when not even providing a name attribute. Make it mandatory. Signed-off-by: Guenter Roeck --- v3: hwmon_device_register() needs to call __hwmon_device_register() directly. v2: One should use ERR_PTR where appropriate drivers/hwmon/hwmon.c |

Re: [PATCH v2] hwmon: Make name attribute mandatory for new APIs

2017-01-25 Thread Guenter Roeck
On 01/25/2017 01:04 AM, Jean Delvare wrote: Hi Guenter, On Tue, 24 Jan 2017 08:57:14 -0800, Guenter Roeck wrote: It does not make sense to use one of the the new APIs when not even providing a name attribute. Make it mandatory. Fully agreed, but... Signed-off-by: Guenter Roeck --- v2: One

[PATCH v2] hwmon: Update documentation to clarify rules for the 'name' attribute

2017-01-25 Thread Guenter Roeck
Clarify that the name attribute must report a valid name, and the rules for valid names. Also clarify that the name parameter must be provided for all supported API functions. Signed-off-by: Guenter Roeck --- v2: '.' is an acceptable character in the 'name' attribute. Documentation/hwmon/hwmon-

Re: [PATCH] hwmon: Update documentation to clarify rules for the 'name' attribute

2017-01-25 Thread Jean Delvare
Hi Guenter, On Tue, 24 Jan 2017 20:26:34 -0800, Guenter Roeck wrote: > Clarify that the name attribute must report a valid name, and the rules > for valid names. Also clarify that the name parameter must be provided > for all supported API functions. > > Signed-off-by: Guenter Roeck > --- > Doc

Re: [PATCH v2] hwmon: Make name attribute mandatory for new APIs

2017-01-25 Thread Jean Delvare
Hi Guenter, On Tue, 24 Jan 2017 08:57:14 -0800, Guenter Roeck wrote: > It does not make sense to use one of the the new APIs when not > even providing a name attribute. Make it mandatory. Fully agreed, but... > Signed-off-by: Guenter Roeck > --- > v2: One should use ERR_PTR where appropriate >