Re: Question about hwmon_attr_show_string

2017-03-07 Thread Guenter Roeck
On 03/07/2017 01:08 AM, Jean Delvare wrote: Hi Guenter, On Mon, 6 Mar 2017 15:47:55 -0800, Guenter Roeck wrote: On Mon, Mar 06, 2017 at 09:48:35PM +0100, Peter Hüwe wrote: Hi Guenter, I was wondering whether there was a particular reason why hwmon_attr_show_string passes only an "empty"

Re: [PATCH] hwmon: (max31790) Set correct PWM value

2017-03-07 Thread Guenter Roeck
On Tue, Mar 07, 2017 at 02:38:29PM -0500, Alex Hemme wrote: > Traced fans not spinning to incorrect PWM value being written. > The passed in value was written instead of the calulated value. > > Fixes: 54187ff9d766 ("hwmon: (max31790) Convert to use new hwmon registration > API") > >

Re: [PATCH 2/2] hwmon: Aspeed AST2400/AST2500 ADC

2017-03-07 Thread Rick Altherr
On Sun, Mar 5, 2017 at 8:28 AM, Guenter Roeck wrote: > On 03/01/2017 07:29 PM, Rick Altherr wrote: >> >> Resending in plain text. >> >> On Tue, Feb 28, 2017 at 7:45 PM, Guenter Roeck wrote: >>> >>> On 02/28/2017 04:49 PM, Joel Stanley wrote:

Re: Question about hwmon_attr_show_string

2017-03-07 Thread Jean Delvare
Hi Guenter, On Mon, 6 Mar 2017 15:47:55 -0800, Guenter Roeck wrote: > On Mon, Mar 06, 2017 at 09:48:35PM +0100, Peter Hüwe wrote: > > Hi Guenter, > > > > I was wondering whether there was a particular reason why > > hwmon_attr_show_string passes only an "empty" pointer(pointer) to the ops- > >

Re: Question about hwmon_attr_show_string

2017-03-07 Thread Peter Huewe
Am 7. März 2017 10:08:46 MEZ schrieb Jean Delvare : >Hi Guenter, > >On Mon, 6 Mar 2017 15:47:55 -0800, Guenter Roeck wrote: >> On Mon, Mar 06, 2017 at 09:48:35PM +0100, Peter Hüwe wrote: >> > Hi Guenter, >> > >> > I was wondering whether there was a particular reason why >> >