Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

2018-03-01 Thread Rob Herring
On Wed, Feb 21, 2018 at 05:20:29PM +0200, Mikko Perttunen wrote: > On 21.02.2018 16:46, Guenter Roeck wrote: > > On 02/20/2018 11:15 PM, Mikko Perttunen wrote: > > > AIUI, the PWM framework already exposes a sysfs node with period > > > information. We should just use that instead of adding a new d

Re: [PATCH v3] hwmon: g762: handle cleanup with devm_add_action

2018-03-01 Thread Guenter Roeck
On 03/01/2018 06:48 AM, Peng Hao wrote: Simplify code and use devm_add_action() to handle cleanup. Signed-off-by: Peng Hao Excellent. The dummy function for g762_of_clock_disable() is no longer needed, and the NULL check for ->clk in g762_of_clock_disable() is not needed anymore either. No n