Re: [PATCH linux-next v5 12/13] drivers/hwmon: Add PECI dimmtemp driver

2018-06-01 Thread Guenter Roeck
On Fri, Jun 01, 2018 at 11:23:03AM -0700, Jae Hyun Yoo wrote: > This commit adds PECI dimmtemp hwmon driver. > > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by: Vernon Mauery > Cc: Alan Cox > Cc: Andrew Jeffery > Cc: Andy Shevchenko > Cc:

Re: [PATCH linux-next v5 10/13] Documentation: hwmon: Add documents for PECI hwmon client drivers

2018-06-01 Thread Guenter Roeck
On Fri, Jun 01, 2018 at 11:22:44AM -0700, Jae Hyun Yoo wrote: > This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. > > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by: Vernon Mauery > Cc: Jason M Biils > Cc: Randy Dunlap

Re: [PATCH linux-next v5 11/13] drivers/hwmon: Add PECI cputemp driver

2018-06-01 Thread Guenter Roeck
On Fri, Jun 01, 2018 at 11:22:54AM -0700, Jae Hyun Yoo wrote: > This commit adds PECI cputemp hwmon driver. > > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by: Vernon Mauery > Cc: Alan Cox > Cc: Andrew Jeffery > Cc: Andy Shevchenko > Cc:

[PATCH linux-next v5 12/13] drivers/hwmon: Add PECI dimmtemp driver

2018-06-01 Thread Jae Hyun Yoo
This commit adds PECI dimmtemp hwmon driver. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew

[PATCH linux-next v5 10/13] Documentation: hwmon: Add documents for PECI hwmon client drivers

2018-06-01 Thread Jae Hyun Yoo
This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Jason M Biils Cc: Randy Dunlap --- Documentation/hwmon/peci-cputemp | 78 +++

[PATCH linux-next v5 11/13] drivers/hwmon: Add PECI cputemp driver

2018-06-01 Thread Jae Hyun Yoo
This commit adds PECI cputemp hwmon driver. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew Lunn

[PATCH linux-next v5 00/13] PECI device driver introduction

2018-06-01 Thread Jae Hyun Yoo
Introduction of the Platform Environment Control Interface (PECI) bus device driver. PECI is a one-wire bus interface that provides a communication channel between an Intel processor and chipset components to external monitoring or control devices. PECI is designed to support the following

Re: [PATCH v4 2/2] hwmon: (asus_atk0110) Make use of device managed memory

2018-06-01 Thread Guenter Roeck
On Fri, Jun 01, 2018 at 05:14:19PM +0200, Bastian Germann wrote: > Use devm_* variants of kstrdup and kzalloc. Get rid of kfree cleanups. > > Signed-off-by: Bastian Germann Thanks a lot for the cleanup and fast turnaround. Applied to hwmon-next. Thanks, Guenter -- To unsubscribe from this

Re: [PATCH v4 1/2] hwmon: (asus_atk0110) Replace deprecated device register call

2018-06-01 Thread Guenter Roeck
On Fri, Jun 01, 2018 at 05:14:18PM +0200, Bastian Germann wrote: > Make the asus_atk0110 driver use hwmon_device_register_with_groups instead > of the deprecated hwmon_device_register. > Construct the expected attribute_group array from the sensor list which > contains all needed attributes. >

Re: [PATCH] hwmon: (k10temp) Make function get_raw_temp static

2018-06-01 Thread Guenter Roeck
On Fri, Jun 01, 2018 at 02:37:13PM +0100, Colin King wrote: > From: Colin Ian King > > The function get_raw_temp is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > drivers/hwmon/k10temp.c:149:14: warning: symbol 'get_raw_temp'

[PATCH v4 2/2] hwmon: (asus_atk0110) Make use of device managed memory

2018-06-01 Thread Bastian Germann
Use devm_* variants of kstrdup and kzalloc. Get rid of kfree cleanups. Signed-off-by: Bastian Germann --- drivers/hwmon/asus_atk0110.c | 44 +++- 1 file changed, 8 insertions(+), 36 deletions(-) diff --git a/drivers/hwmon/asus_atk0110.c

[PATCH v4 1/2] hwmon: (asus_atk0110) Replace deprecated device register call

2018-06-01 Thread Bastian Germann
Make the asus_atk0110 driver use hwmon_device_register_with_groups instead of the deprecated hwmon_device_register. Construct the expected attribute_group array from the sensor list which contains all needed attributes. Remove the manual sysfs file creation and deletion that are now taken care of

asus_atk0110: Use non-deprecated registration and managed memory

2018-06-01 Thread Bastian Germann
This is version 4 of my previously unversioned patch. Version 2 addresses the issues brought up by Guenter. The two v1 patches are joined in v2 1/2. The unnecessary dynamic allocations are now part of the atk_data struct. devm_kcalloc is used for the attribute array that is created from sensors.

Re: [PATCH 1/2] hwmon: (asus_atk0110) Replace deprecated device register call

2018-06-01 Thread Guenter Roeck
On 06/01/2018 04:07 AM, Bastian Germann wrote: Make the asus_atk0110 driver use hwmon_device_register_with_groups instead of the deprecated hwmon_device_register. Construct the expected attribute_group array from the sensor list which contains all needed attributes. Remove the manual sysfs file

[PATCH 2/2] hwmon: (asus_atk0110) Make use of device managed memory

2018-06-01 Thread Bastian Germann
Use devm_* variants of kstrdup and kzalloc. Get rid of kfree cleanups. Signed-off-by: Bastian Germann --- drivers/hwmon/asus_atk0110.c | 44 +++- 1 file changed, 8 insertions(+), 36 deletions(-) diff --git a/drivers/hwmon/asus_atk0110.c

[PATCH 1/2] hwmon: (asus_atk0110) Replace deprecated device register call

2018-06-01 Thread Bastian Germann
Make the asus_atk0110 driver use hwmon_device_register_with_groups instead of the deprecated hwmon_device_register. Construct the expected attribute_group array from the sensor list which contains all needed attributes. Remove the manual sysfs file creation and deletion that are now taken care of

Re: [PATCH 2/2] hwmon: (asus_atk0110) Make use of device managed memory

2018-06-01 Thread Andy Shevchenko
On Fri, Jun 1, 2018 at 1:57 AM, Bastian Germann wrote: > Use devm_* variants of kstrdup and kzalloc. Get rid of the kfree cleanups. > static int atk_debugfs_ggrp_open(struct inode *inode, struct file *file) > { > struct atk_data *data = inode->i_private; > + struct device *dev =