Re: [PATCH v1 1/2] dt-binding: misc: Add common LPC snoop documentation

2019-04-15 Thread Andrew Jeffery
On Mon, 15 Apr 2019, at 21:51, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM BIOS Post Code (BPC) and Apeed AST2500 LPC snoop. > The LPC snoop monitoring two configurable I/O addresses > written by the host on Low Pin Count (LPC) bus. > > Signed-off-by: To

Re: [PATCH] hwmon (occ): Fix extended status bits

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 06:37:20PM +0800, Lei YU wrote: > The occ's extended status is checked and shown as sysfs attributes. But > the code was incorrectly checking the "status" bits. > Fix it by checking the "ext_status" bits. > > Signed-off-by: Lei YU > Reviewed-by: Eddie James Applied. Tha

Re: [PATCH v6] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 03:28:07PM -0700, Patrick Venture wrote: > From: Maxim Sloyko > > Intersil ISL68137 is a digital output 7-phase configurable PWM > controller with an AVSBus interface. > > Signed-off-by: Maxim Sloyko > Signed-off-by: Robert Lippert > Signed-off-by: Patrick Venture Thi

Re: [PATCH v6] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Patrick Venture
On Mon, Apr 15, 2019 at 3:28 PM Patrick Venture wrote: > > From: Maxim Sloyko > > Intersil ISL68137 is a digital output 7-phase configurable PWM > controller with an AVSBus interface. > > Signed-off-by: Maxim Sloyko > Signed-off-by: Robert Lippert > Signed-off-by: Patrick Venture I trim out a

[PATCH v6] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Patrick Venture
From: Maxim Sloyko Intersil ISL68137 is a digital output 7-phase configurable PWM controller with an AVSBus interface. Signed-off-by: Maxim Sloyko Signed-off-by: Robert Lippert Signed-off-by: Patrick Venture --- v6: Fix reversed logic bug. v5: Drop extra parens Drop extra parameter check v

Re: [PATCH v5 2/2] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Patrick Venture
On Mon, Apr 15, 2019 at 2:58 PM Guenter Roeck wrote: > > On Mon, Apr 15, 2019 at 02:44:14PM -0700, Patrick Venture wrote: > > From: Maxim Sloyko > > > > Intersil ISL68137 is a digital output 7-phase configurable PWM > > controller with an AVSBus interface. > > > > Signed-off-by: Maxim Sloyko > >

Re: [PATCH] hwmon (occ): Fix extended status bits

2019-04-15 Thread Eddie James
On 4/15/19 3:28 PM, Guenter Roeck wrote: On Mon, Apr 15, 2019 at 06:37:20PM +0800, Lei YU wrote: The occ's extended status is checked and shown as sysfs attributes. But the code was incorrectly checking the "status" bits. Fix it by checking the "ext_status" bits. Signed-off-by: Lei YU Looks

Re: [PATCH] hwmon: Add support for samples attributes

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 02:47:16PM -0700, Nicolin Chen wrote: > Thanks for adding this. > > On Mon, Apr 15, 2019 at 01:27:12PM -0700, Guenter Roeck wrote: > > Add support for the new samples attributes to the hwmon core. > > > > Cc: Krzysztof Adamski > > Cc: Nicolin Chen > > Acked-by: Nicolin

Re: [PATCH v5 2/2] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 02:44:14PM -0700, Patrick Venture wrote: > From: Maxim Sloyko > > Intersil ISL68137 is a digital output 7-phase configurable PWM > controller with an AVSBus interface. > > Signed-off-by: Maxim Sloyko > Signed-off-by: Robert Lippert > Signed-off-by: Patrick Venture For

Re: [PATCH v5 1/2] pmbus: support for custom sysfs attributes

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 02:44:05PM -0700, Patrick Venture wrote: > From: krzysztof.adam...@nokia.com > > This patch makes it possible to pass custom struct attribute_group array > via the pmbus_driver_info struct so that those can be added to the > attribute groups passed to hwmon_device_register_

Re: [PATCH] hwmon: Add support for samples attributes

2019-04-15 Thread Nicolin Chen
Thanks for adding this. On Mon, Apr 15, 2019 at 01:27:12PM -0700, Guenter Roeck wrote: > Add support for the new samples attributes to the hwmon core. > > Cc: Krzysztof Adamski > Cc: Nicolin Chen Acked-by: Nicolin Chen Will redo my change and test through API later. > Signed-off-by: Guenter

[PATCH v5 2/2] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Patrick Venture
From: Maxim Sloyko Intersil ISL68137 is a digital output 7-phase configurable PWM controller with an AVSBus interface. Signed-off-by: Maxim Sloyko Signed-off-by: Robert Lippert Signed-off-by: Patrick Venture --- v5: Drop extra parens Drop extra parameter check v4: Use kstrtobool Cleanup p

[PATCH v5 1/2] pmbus: support for custom sysfs attributes

2019-04-15 Thread Patrick Venture
From: krzysztof.adam...@nokia.com This patch makes it possible to pass custom struct attribute_group array via the pmbus_driver_info struct so that those can be added to the attribute groups passed to hwmon_device_register_with_groups(). This makes it possible to register custom sysfs attributes

Re: [PATCH v4 2/2] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Patrick Venture
On Mon, Apr 15, 2019 at 2:35 PM Guenter Roeck wrote: > > On Mon, Apr 15, 2019 at 01:41:22PM -0700, Patrick Venture wrote: > > From: Maxim Sloyko > > > > Intersil ISL68137 is a digital output 7-phase configurable PWM > > controller with an AVSBus interface. > > > > Signed-off-by: Maxim Sloyko > >

Re: [PATCH v4 2/2] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 01:41:22PM -0700, Patrick Venture wrote: > From: Maxim Sloyko > > Intersil ISL68137 is a digital output 7-phase configurable PWM > controller with an AVSBus interface. > > Signed-off-by: Maxim Sloyko > Signed-off-by: Robert Lippert > Signed-off-by: Patrick Venture Cou

[PATCH v4 1/2] pmbus: support for custom sysfs attributes

2019-04-15 Thread Patrick Venture
From: krzysztof.adam...@nokia.com This patch makes it possible to pass custom struct attribute_group array via the pmbus_driver_info struct so that those can be added to the attribute groups passed to hwmon_device_register_with_groups(). This makes it possible to register custom sysfs attributes

Re: [PATCH] hwmon (occ): Fix extended status bits

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 06:37:20PM +0800, Lei YU wrote: > The occ's extended status is checked and shown as sysfs attributes. But > the code was incorrectly checking the "status" bits. > Fix it by checking the "ext_status" bits. > > Signed-off-by: Lei YU Looks ok to me, but can I get a confirmat

[PATCH] hwmon: Add support for samples attributes

2019-04-15 Thread Guenter Roeck
Add support for the new samples attributes to the hwmon core. Cc: Krzysztof Adamski Cc: Nicolin Chen Signed-off-by: Guenter Roeck --- drivers/hwmon/hwmon.c | 5 + include/linux/hwmon.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/

Re: [PATCH v3 4/4] pmbus_core: export coefficients via sysfs

2019-04-15 Thread Adamski, Krzysztof (Nokia - PL/Wroclaw)
On Mon, Apr 15, 2019 at 09:33:10AM -0700, Guenter Roeck wrote: >We are talking an ABI here. ABIs are supposed to be hardware independent. >Directly mapping registers to attributes is not exactly hardware independent. That is true, I get that, even though I don't want to map registers. I want to ma

Re: [PATCH v3 3/4] lm25066: support SAMPLES_FOR_AVG register

2019-04-15 Thread Guenter Roeck
On Sun, Apr 14, 2019 at 09:59:19PM +, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > Manufacturer specific SAMPLES_FOR_AVG register allows setting the number > of samples used in computing the average values (PMBUS_VIRT_READ_*_AVG). > The number we write is an exponent of base 2 of the numbe

Re: [PATCH v3 2/4] hwmon: Document the samples attributes

2019-04-15 Thread Guenter Roeck
On Sun, Apr 14, 2019 at 09:58:40PM +, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > Document new ABI attributes: {in,power,curr,temp}_samples and samples. > > Signed-off-by: Krzysztof Adamski Applied to hwmon-next. Thanks, Guenter > --- > Documentation/hwmon/sysfs-interface | 18 +

Re: [PATCH v3 1/4] pmbus: introduce PMBUS_VIRT_*_SAMPLES registers

2019-04-15 Thread Guenter Roeck
On Sun, Apr 14, 2019 at 09:58:18PM +, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > Those virtual registers can be used to export manufacturer specific > functionality for controlling the number of samples for average values > reported by the device. > > Signed-off-by: Krzysztof Adamski

Re: [PATCH v3 1/2] pmbus: support for custom sysfs attributes

2019-04-15 Thread Patrick Venture
On Mon, Apr 15, 2019 at 11:14 AM Patrick Venture wrote: > > From: krzysztof.adam...@nokia.com My instance of git send-email didn't parse the From line correctly, my apologies. > > This patch makes it possible to pass custom struct attribute_group array > via the pmbus_driver_info struct so that

[PATCH v3 1/2] pmbus: support for custom sysfs attributes

2019-04-15 Thread Patrick Venture
From: krzysztof.adam...@nokia.com This patch makes it possible to pass custom struct attribute_group array via the pmbus_driver_info struct so that those can be added to the attribute groups passed to hwmon_device_register_with_groups(). This makes it possible to register custom sysfs attributes

Re: [PATCH v3 4/4] pmbus_core: export coefficients via sysfs

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 08:34:48AM +, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > On Sun, Apr 14, 2019 at 07:38:33PM -0700, Guenter Roeck wrote: > >On 4/14/19 3:37 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > >>On Sun, Apr 14, 2019 at 11:59:38PM +0200, Krzysztof Adamski wrote: > >

Re: [PATCH] hwmon: (ir38064) delete incorrect line

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 07:17:28AM -0700, Patrick Venture wrote: > Delete line indicating the datasheet was not publicly available. This > line was originally present as a default during the write-up and was > subsequently not removed once the datasheet was located. > > Signed-off-by: Patrick Ven

[PATCH] hwmon: (ir38064) delete incorrect line

2019-04-15 Thread Patrick Venture
Delete line indicating the datasheet was not publicly available. This line was originally present as a default during the write-up and was subsequently not removed once the datasheet was located. Signed-off-by: Patrick Venture --- Documentation/hwmon/ir38064 | 3 --- 1 file changed, 3 deletions

Re: [PATCH] hwmon: (pmbus_core) Replace S_ with octal values

2019-04-15 Thread Guenter Roeck
On 4/14/19 3:22 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: On Sun, Apr 14, 2019 at 02:57:24PM -0700, Guenter Roeck wrote: Replace S_ with octal values. The conversion was done automatically with coccinelle. The semantic patches and the scripts used to generate this commit log are availa

Re: [PATCH v1 2/2] misc: npcm: add NPCM LPC BPC driver

2019-04-15 Thread Guenter Roeck
On 4/15/19 5:12 AM, Tomer Maimon wrote: Add Nuvoton BMC NPCM BIOS post code (BPC) driver. The NPCM BPC monitoring two I/O address written by the host on the Low Pin Count (LPC) bus, the capure data stored in 128-word FIFO. Signed-off-by: Tomer Maimon --- drivers/misc/Kconfig |

[PATCH v1 1/2] dt-binding: misc: Add common LPC snoop documentation

2019-04-15 Thread Tomer Maimon
Added device tree binding documentation for Nuvoton BMC NPCM BIOS Post Code (BPC) and Apeed AST2500 LPC snoop. The LPC snoop monitoring two configurable I/O addresses written by the host on Low Pin Count (LPC) bus. Signed-off-by: Tomer Maimon --- .../devicetree/bindings/misc/lpc-snoop.txt

[PATCH v1 2/2] misc: npcm: add NPCM LPC BPC driver

2019-04-15 Thread Tomer Maimon
Add Nuvoton BMC NPCM BIOS post code (BPC) driver. The NPCM BPC monitoring two I/O address written by the host on the Low Pin Count (LPC) bus, the capure data stored in 128-word FIFO. Signed-off-by: Tomer Maimon --- drivers/misc/Kconfig | 8 + drivers/misc/Makefile |

[PATCH v1 0/2] misc: Add NPCM LPC BPC driver support

2019-04-15 Thread Tomer Maimon
This patch set adds BIOS Post code (BPC) support for the Nuvoton NPCM Baseboard Management Controller (BMC). Nuvoton BMC NPCM BIOS Post Code (BPC) monitoring two configurable I/O addresses written by the host on the Low Pin Count (LPC) bus, the capture data stored in 128-word FIFO. NPCM BPC can s

[PATCH] hwmon (occ): Fix extended status bits

2019-04-15 Thread Lei YU
The occ's extended status is checked and shown as sysfs attributes. But the code was incorrectly checking the "status" bits. Fix it by checking the "ext_status" bits. Signed-off-by: Lei YU --- drivers/hwmon/occ/sysfs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/d

Re: [PATCH v3 4/4] pmbus_core: export coefficients via sysfs

2019-04-15 Thread Adamski, Krzysztof (Nokia - PL/Wroclaw)
On Sun, Apr 14, 2019 at 07:38:33PM -0700, Guenter Roeck wrote: >On 4/14/19 3:37 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: >>On Sun, Apr 14, 2019 at 11:59:38PM +0200, Krzysztof Adamski wrote: >>>PMBUS devices report values in real-world units. Those using direct >>>format require conversion