On 7/21/19 1:37 PM, avo...@riseup.net wrote:
On 2019-07-21 17:14, Guenter Roeck wrote:
On Sun, Jul 21, 2019 at 02:00:51PM +0200, Robert Karszniewicz wrote:
Removes:
- hwmon_dev from k8temp_data struct, as that is now passed
to callbacks, anyway.
- other k8temp_data struct fields, too.
- k8te
V2:
Addressing maintainer feedback,
- Increased attribute array from 8 to 9, to accommodate NULL terminator.
- Removed #define ATTR_GROUP_COUNT.
- Replaced hwmon_device_register_with_groups() with
devm_hwmon_device_register_with_groups() api.
- Removed the adt7475_remove_files() as no longer ne
hwmon_device_register() is a deprecated function and produces a warning.
Converting the driver to use the hwmon_device_register_with_groups()
instead.
Signed-off-by: Grant McEwan
---
drivers/hwmon/adt7475.c | 146 ++--
1 file changed, 50 insertions(+), 96 del
On 2019-07-21 17:14, Guenter Roeck wrote:
> On Sun, Jul 21, 2019 at 02:00:51PM +0200, Robert Karszniewicz wrote:
>> Removes:
>> - hwmon_dev from k8temp_data struct, as that is now passed
>> to callbacks, anyway.
>> - other k8temp_data struct fields, too.
>> - k8temp_update_device()
>>
>> Also red
On Sun, Jul 21, 2019 at 02:00:51PM +0200, Robert Karszniewicz wrote:
> Removes:
> - hwmon_dev from k8temp_data struct, as that is now passed
> to callbacks, anyway.
> - other k8temp_data struct fields, too.
> - k8temp_update_device()
>
> Also reduces binary size:
>textdata bss de
On Sun, Jul 21, 2019 at 12:15:53PM +0200, Christophe JAILLET wrote:
> There is a typo in MAX37185_NUM_FAN_PAGES. To be consistent, it should be
> MAX31785_NUM_FAN_PAGES (1 and 7 switched).
>
> At line 24, we already have:
>#define MAX31785_NR_FAN_PAGES 6
> and MAX37185_NUM_FAN_PAG
Removes:
- hwmon_dev from k8temp_data struct, as that is now passed
to callbacks, anyway.
- other k8temp_data struct fields, too.
- k8temp_update_device()
Also reduces binary size:
textdata bss dec hex filename
41391448 0558715d3 drivers/hwmon/k8temp.ko.ba
Removes:
- hwmon_dev from k8temp_data struct, as that is now passed
to callbacks, anyway.
- other k8temp_data struct fields, too.
- k8temp_update_device()
Also reduces binary size:
textdata bss dec hex filename
41391448 0558715d3 drivers/hwmon/k8temp.ko.ba
There is a typo in MAX37185_NUM_FAN_PAGES. To be consistent, it should be
MAX31785_NUM_FAN_PAGES (1 and 7 switched).
At line 24, we already have:
#define MAX31785_NR_FAN_PAGES6
and MAX37185_NUM_FAN_PAGES seems to be unused.
It is likely that it is only a typo and/or a left-over
