Re: [PATCH v3 1/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips

2019-10-04 Thread Guenter Roeck
On Thu, Oct 03, 2019 at 06:34:17PM +, Tremblay, Eric wrote: > hwmon: Add driver for Texas Instruments TMP512/513 sensor chips. > > TI's TMP512/513 are I2C/SMBus system monitor chips. These chips > monitor the supply voltage, supply current, power consumption > and provide one local and up to

Re: [PATCH 09/10] hwmon: (lm70) Avoid undefined reference to match table

2019-10-04 Thread Guenter Roeck
On Fri, Oct 04, 2019 at 02:43:33PM -0700, Stephen Boyd wrote: > We're going to remove of_match_ptr() from the definition of > of_match_device() when CONFIG_OF=n. This way we can always be certain > that of_match_device() acts the same when CONFIG_OF is set and when it > isn't. Add of_match_ptr()

[PATCH 09/10] hwmon: (lm70) Avoid undefined reference to match table

2019-10-04 Thread Stephen Boyd
We're going to remove of_match_ptr() from the definition of of_match_device() when CONFIG_OF=n. This way we can always be certain that of_match_device() acts the same when CONFIG_OF is set and when it isn't. Add of_match_ptr() here so that this doesn't break when that change is made to the

[PATCH 00/10] Stop NULLifying match pointer in of_match_device()

2019-10-04 Thread Stephen Boyd
of_match_device() uses of_match_ptr() to make the match table argument NULL via the pre-processor when CONFIG_OF=n. This makes life harder for compilers who think that match tables are never used and warn about unused variables when CONFIG_OF=n. This series changes various callers to use

Re: [PATCH v3 2/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips

2019-10-04 Thread Guenter Roeck
On Thu, Oct 03, 2019 at 06:34:41PM +, Tremblay, Eric wrote: > hwmon: Add DT bindings for TMP513 driver > $subject is misleading. > Signed-off-by: Eric Tremblay > --- > .../devicetree/bindings/hwmon/tmp513.txt | 33 +++ > 1 file changed, 33 insertions(+) > create mode

RE: [PATCH v3 0/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips

2019-10-04 Thread Tremblay, Eric
> On Thu, Oct 03, 2019 at 06:35:51PM +, Tremblay, Eric wrote: > > > Version three of the driver for Texas Instruments TMP512/513 sensors. > > > > > > Thanks again for the review, I think we are getting close. I'm not > > > in an easy position for now to test the driver without device tree. > >