Re: [PATCH v1 2/2] misc: npcm7xx: add NPCM7xx LPC BPC driver

2018-07-16 Thread Greg KH
On Wed, Jul 04, 2018 at 12:14:27PM +0300, Tomer Maimon wrote: > Add Nuvoton BMC NPCM7xx BIOS post code (BPC) driver. > > The NPCM7xx BPC monitoring two I/O address written by > the host on the Low Pin Count (LPC) bus, the capure > data stored in 128-word FIFO. > > Signed-off-by: Tomer Maimon It

Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-23 Thread Greg KH
On Tue, Apr 10, 2018 at 11:32:05AM -0700, Jae Hyun Yoo wrote: > +static void peci_adapter_dev_release(struct device *dev) > +{ > + /* do nothing */ > +} As per the in-kernel documentation, I am now allowed to make fun of you. You are trying to "out smart" the kernel by getting rid of a warnin

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-21 Thread Greg KH
On Wed, Feb 21, 2018 at 12:42:30PM -0800, Jae Hyun Yoo wrote: > On 2/21/2018 9:58 AM, Greg KH wrote: > > On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: > > > This commit adds driver implementation for PECI bus into linux > > > driver framework. > >

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-21 Thread Greg KH
On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: > This commit adds driver implementation for PECI bus into linux > driver framework. > > Signed-off-by: Jae Hyun Yoo > --- Why is there no other Intel developers willing to review and sign off on this patch? Please get their review f

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-11 Thread Greg KH
On Thu, Jan 11, 2018 at 07:56:51PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2018-01-11 at 08:30 +0100, Greg KH wrote: > > 4.13? Why that kernel? It too is obsolete and insecure and > > unsupported. > > Haha, it's n-1. come on :-) And, if you use it in a

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-11 Thread Greg KH
On Thu, Jan 11, 2018 at 12:28:48AM -0800, Joel Stanley wrote: > On Wed, Jan 10, 2018 at 11:30 PM, Greg KH wrote: > > On Wed, Jan 10, 2018 at 01:46:34PM -0800, Jae Hyun Yoo wrote: > >> Thanks for your pointing it out and I totally agree with you. Actually, we > >> are pr

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Greg KH
On Wed, Jan 10, 2018 at 01:46:34PM -0800, Jae Hyun Yoo wrote: > On 1/10/2018 12:27 PM, Greg KH wrote: > > On Wed, Jan 10, 2018 at 11:30:05AM -0800, Jae Hyun Yoo wrote: > > > On 1/10/2018 11:17 AM, Greg KH wrote: > > > > On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Greg KH
On Wed, Jan 10, 2018 at 11:30:05AM -0800, Jae Hyun Yoo wrote: > On 1/10/2018 11:17 AM, Greg KH wrote: > > On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae Hyun Yoo wrote: > > > On 1/10/2018 2:17 AM, Greg KH wrote: > > > > On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Greg KH
On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae Hyun Yoo wrote: > On 1/10/2018 2:17 AM, Greg KH wrote: > > On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo wrote: > > > From: Jae Hyun Yoo > > > > > > Hello, > > > > > > This patch set pr

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-10 Thread Greg KH
On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: > This commit adds driver implementation for Aspeed PECI. Also adds > generic peci.h and peci_ioctl.h files to provide compatibility > to peci drivers that can be implemented later e.g. Nuvoton's BMC > SoC family. We don't add code that

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-10 Thread Greg KH
On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: > +#pragma pack(push, 1) > +struct peci_xfer_msg { > + unsigned char client_addr; > + unsigned char tx_len; > + unsigned char rx_len; > + unsigned char tx_buf[MAX_BUFFER_SIZE]; > + unsigned char rx_buf[MAX_BUFFER_SIZE

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Greg KH
On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo wrote: > From: Jae Hyun Yoo > > Hello, > > This patch set provides support for PECI of AST2400/2500 which can give us > PECI > functionalities such as temperature monitoring, platform manageability, > processor diagnostics and failure analy

Re: [PATCH linux v6 0/3] Export 1-wire thermal sensors as hwmon device

2017-08-31 Thread Greg KH
On Wed, Aug 30, 2017 at 04:34:32PM -0700, Jaghathiswari Rankappagounder Natarajan wrote: > Hi Greg, > Please pull in this patchset into the tree. Thanks! Thanks for the reworks, all now queued up. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a

Re: [PATCH linux v5 1/3] drivers: w1: add hwmon support structures

2017-08-28 Thread Greg KH
On Mon, Jul 17, 2017 at 04:09:04PM -0700, Jaghathiswari Rankappagounder Natarajan wrote: > This patch has changes to w1.h/w1.c/w1_family.h generic files to > add (optional) hwmon support structures. > > Signed-off-by: Jaghathiswari Rankappagounder Natarajan > Acked-by: Evgeniy Polyakov > Acked-

Re: Converting DEVICE_ATTR to DEVICE_ATTR_{RO,RW,WO} and changing function names at the same time

2016-12-22 Thread Greg KH
On Thu, Dec 22, 2016 at 04:45:45PM +0100, Julia Lawall wrote: > > > On Thu, 22 Dec 2016, Guenter Roeck wrote: > > > On 12/22/2016 04:29 AM, Julia Lawall wrote: > > > > > > > > > On Wed, 21 Dec 2016, Guenter Roeck wrote: > > > > > > > Hi Julia, > > > > > > > > On Wed, Dec 21, 2016 at 08:39:38PM +

Re: [PATCH 0239/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Greg KH
On Tue, Aug 02, 2016 at 06:52:21PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro,