Re: [PATCH 1/1] hwmon (occ): Add temp sensor value check

2019-04-17 Thread Guenter Roeck
On 4/17/19 4:26 AM, Alexander Amelkin wrote: From: Alexander Soldatov The occ driver supports two formats for the temp sensor value. The OCC firmware for P8 supports only the first format, for which no range checking or error processing is performed in the driver. Inspecting the OCC sources

Re: [PATCH v2 00/21] Convert hwmon documentation to ReST

2019-04-16 Thread Guenter Roeck
On 4/16/19 6:58 PM, Mauro Carvalho Chehab wrote: Em Tue, 16 Apr 2019 13:31:14 -0700 Guenter Roeck escreveu: On Tue, Apr 16, 2019 at 02:19:49PM -0600, Jonathan Corbet wrote: On Fri, 12 Apr 2019 20:09:16 -0700 Guenter Roeck wrote: The big real-world question is: Is the series good enough

Re: [PATCH 3/3] hwmon (occ): Add more details to Kconfig help text

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 03:43:50PM +, Eddie James wrote: > From: Eddie James > > The help text needs to spell out how the driver runs on a BMC, as it > previously seemed to indicate it ran on a POWER processor. > > Signed-off-by: Eddie James Applied. Thanks, Guenter > --- >

Re: [PATCH 2/3] hwmon (occ): Prevent sysfs error attribute from returning error

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 03:43:49PM +, Eddie James wrote: > The error sysfs attribute returns the stored error state of the OCC and > doesn't depend on the OCC poll response. Therefore, split the error > attribute into it's own function to avoid failing out of the function if > the poll

Re: [PATCH 1/3] hwmon (occ): Store error condition for rate-limited polls

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 03:43:48PM +, Eddie James wrote: > The OCC driver limits the rate of sending poll commands to the OCC. If a > user reads a hwmon entry after a poll response resulted in an error and > is rate-limited, the error is invisible to the user. Fix this by storing > the last

Re: [PATCH 4/4] hwmon: (pmbus/tps40422) add support for output voltage margining

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 11:36:19AM -0700, Ruslan Babayev wrote: > TPS40422 has MFR_SPECIFIC registers STEP_VREF_MARGIN_HIGH and > STEP_VREF_MARGIN_LOW, which are signed 16-bit in units of 2mV. This > value is an offset from the nominal reference voltage of 600mV. > > For instance, the default

Re: [PATCH 2/4] hwmon: (pmbus) mark registers READ_VIN and READ_IIN as paged

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 12:40:33PM -0700, Guenter Roeck wrote: > On Tue, Apr 16, 2019 at 11:36:17AM -0700, Ruslan Babayev wrote: > > On some devices (like IR35215) READ_VIN and READ_IIN registers are > > paged. > > > > For devices where these registers are not paged the

Re: [PATCH v2 00/21] Convert hwmon documentation to ReST

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 02:19:49PM -0600, Jonathan Corbet wrote: > On Fri, 12 Apr 2019 20:09:16 -0700 > Guenter Roeck wrote: > > > The big real-world question is: Is the series good enough for you to accept, > > or do you expect some level of user/kernel separation ? &

Re: [PATCH 3/4] hwmon: (pmbus) add support for IR35215

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 11:36:18AM -0700, Ruslan Babayev wrote: > Provide support for Infineon Dual Output Digital Multi-Phase Buck > Controllers IR35215 and IR3570B. > > Cc: xe-linux-exter...@cisco.com > Signed-off-by: Ruslan Babayev > --- > Documentation/hwmon/ir35215 | 98

Re: [PATCH v2] hwmon: (ina3221) Add averaging mode support

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 12:41:31PM -0700, Nicolin Chen wrote: > The CONFIG register has a 3-bit averaging mode field for users > to setup the number of samples that are collected and averaged > together. This is very useful to filter noise from sensor data. > > This patch adds a 'samples' sysfs

Re: [PATCH 1/4] hwmon: (pmbus) add support for output voltage registers

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 11:36:16AM -0700, Ruslan Babayev wrote: > Registers VOUT_COMMAND, VOUT_MARGIN_HIGH and VOUT_MARGIN_LOW are > described in PMBUS Spec Part II Rev 1.2. Exposing them in the PMBUS > core allows the drivers to turn them on with a corresponding > PMBUS_HAVE_VOUT_... flags. > >

Re: [PATCH 2/4] hwmon: (pmbus) mark registers READ_VIN and READ_IIN as paged

2019-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2019 at 11:36:17AM -0700, Ruslan Babayev wrote: > On some devices (like IR35215) READ_VIN and READ_IIN registers are > paged. > > For devices where these registers are not paged the extra check > ensures we expose only the registers that are actually present. > > Cc:

Re: [PATCH] hwmon (occ): Fix extended status bits

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 06:37:20PM +0800, Lei YU wrote: > The occ's extended status is checked and shown as sysfs attributes. But > the code was incorrectly checking the "status" bits. > Fix it by checking the "ext_status" bits. > > Signed-off-by: Lei YU > Reviewed-by: Eddie James Applied.

Re: [PATCH v6] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 03:28:07PM -0700, Patrick Venture wrote: > From: Maxim Sloyko > > Intersil ISL68137 is a digital output 7-phase configurable PWM > controller with an AVSBus interface. > > Signed-off-by: Maxim Sloyko > Signed-off-by: Robert Lippert > Signed-off-by: Patrick Venture

Re: [PATCH] hwmon: Add support for samples attributes

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 02:47:16PM -0700, Nicolin Chen wrote: > Thanks for adding this. > > On Mon, Apr 15, 2019 at 01:27:12PM -0700, Guenter Roeck wrote: > > Add support for the new samples attributes to the hwmon core. > > > > Cc: Krzysztof Adamski > > Cc: Nic

Re: [PATCH v5 2/2] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 02:44:14PM -0700, Patrick Venture wrote: > From: Maxim Sloyko > > Intersil ISL68137 is a digital output 7-phase configurable PWM > controller with an AVSBus interface. > > Signed-off-by: Maxim Sloyko > Signed-off-by: Robert Lippert > Signed-off-by: Patrick Venture

Re: [PATCH v5 1/2] pmbus: support for custom sysfs attributes

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 02:44:05PM -0700, Patrick Venture wrote: > From: krzysztof.adam...@nokia.com > > This patch makes it possible to pass custom struct attribute_group array > via the pmbus_driver_info struct so that those can be added to the > attribute groups passed to

Re: [PATCH v4 2/2] hwmon: (pmbus/isl68137): Add driver for Intersil ISL68137 PWM Controller

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 01:41:22PM -0700, Patrick Venture wrote: > From: Maxim Sloyko > > Intersil ISL68137 is a digital output 7-phase configurable PWM > controller with an AVSBus interface. > > Signed-off-by: Maxim Sloyko > Signed-off-by: Robert Lippert > Signed-off-by: Patrick Venture

Re: [PATCH] hwmon (occ): Fix extended status bits

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 06:37:20PM +0800, Lei YU wrote: > The occ's extended status is checked and shown as sysfs attributes. But > the code was incorrectly checking the "status" bits. > Fix it by checking the "ext_status" bits. > > Signed-off-by: Lei YU Looks ok to me, but can I get a

[PATCH] hwmon: Add support for samples attributes

2019-04-15 Thread Guenter Roeck
Add support for the new samples attributes to the hwmon core. Cc: Krzysztof Adamski Cc: Nicolin Chen Signed-off-by: Guenter Roeck --- drivers/hwmon/hwmon.c | 5 + include/linux/hwmon.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon

Re: [PATCH v3 3/4] lm25066: support SAMPLES_FOR_AVG register

2019-04-15 Thread Guenter Roeck
On Sun, Apr 14, 2019 at 09:59:19PM +, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > Manufacturer specific SAMPLES_FOR_AVG register allows setting the number > of samples used in computing the average values (PMBUS_VIRT_READ_*_AVG). > The number we write is an exponent of base 2 of the

Re: [PATCH v3 2/4] hwmon: Document the samples attributes

2019-04-15 Thread Guenter Roeck
On Sun, Apr 14, 2019 at 09:58:40PM +, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > Document new ABI attributes: {in,power,curr,temp}_samples and samples. > > Signed-off-by: Krzysztof Adamski Applied to hwmon-next. Thanks, Guenter > --- > Documentation/hwmon/sysfs-interface | 18

Re: [PATCH v3 1/4] pmbus: introduce PMBUS_VIRT_*_SAMPLES registers

2019-04-15 Thread Guenter Roeck
On Sun, Apr 14, 2019 at 09:58:18PM +, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > Those virtual registers can be used to export manufacturer specific > functionality for controlling the number of samples for average values > reported by the device. > > Signed-off-by: Krzysztof Adamski

Re: [PATCH v3 4/4] pmbus_core: export coefficients via sysfs

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 08:34:48AM +, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > On Sun, Apr 14, 2019 at 07:38:33PM -0700, Guenter Roeck wrote: > >On 4/14/19 3:37 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > >>On Sun, Apr 14, 2019 at 11:59:38PM +0200, Krzys

Re: [PATCH] hwmon: (ir38064) delete incorrect line

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 07:17:28AM -0700, Patrick Venture wrote: > Delete line indicating the datasheet was not publicly available. This > line was originally present as a default during the write-up and was > subsequently not removed once the datasheet was located. > > Signed-off-by: Patrick

Re: [PATCH] hwmon: (pmbus_core) Replace S_ with octal values

2019-04-15 Thread Guenter Roeck
On 4/14/19 3:22 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: On Sun, Apr 14, 2019 at 02:57:24PM -0700, Guenter Roeck wrote: Replace S_ with octal values. The conversion was done automatically with coccinelle. The semantic patches and the scripts used to generate this commit log

Re: [PATCH v1 2/2] misc: npcm: add NPCM LPC BPC driver

2019-04-15 Thread Guenter Roeck
On 4/15/19 5:12 AM, Tomer Maimon wrote: Add Nuvoton BMC NPCM BIOS post code (BPC) driver. The NPCM BPC monitoring two I/O address written by the host on the Low Pin Count (LPC) bus, the capure data stored in 128-word FIFO. Signed-off-by: Tomer Maimon --- drivers/misc/Kconfig |

Re: [PATCH v3 4/4] pmbus_core: export coefficients via sysfs

2019-04-14 Thread Guenter Roeck
On 4/14/19 3:37 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: On Sun, Apr 14, 2019 at 11:59:38PM +0200, Krzysztof Adamski wrote: PMBUS devices report values in real-world units. Those using direct format require conversion using standarised coefficients and formula. This operation is

Re: [PATCH v2 1/3] pmbus: introduce PMBUS_VIRT_*_SAMPLES registers

2019-04-14 Thread Guenter Roeck
On 4/14/19 12:08 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: On Sun, Apr 14, 2019 at 07:27:47AM -0700, Guenter Roeck wrote: On 4/13/19 9:03 AM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: Those virtual registers can be used to export manufacturer specific functionality

[PATCH] hwmon: (pmbus_core) Replace S_ with octal values

2019-04-14 Thread Guenter Roeck
by compiling the old and new files and comparing text and data sizes. Cc: Krzysztof Adamski Signed-off-by: Guenter Roeck --- drivers/hwmon/pmbus/pmbus_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c

Re: [PATCH v2 2/3] lm25066: support SAMPLES_FOR_AVG register

2019-04-14 Thread Guenter Roeck
On 4/14/19 12:00 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: On Sun, Apr 14, 2019 at 07:37:35AM -0700, Guenter Roeck wrote: On 4/13/19 9:03 AM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: Manufacturer specific SAMPLES_FOR_AVG register allows setting the number of samples used

Re: [PATCH v2 2/3] lm25066: support SAMPLES_FOR_AVG register

2019-04-14 Thread Guenter Roeck
On 4/13/19 9:03 AM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: Manufacturer specific SAMPLES_FOR_AVG register allows setting the number of samples used in computing the average values (PMBUS_VIRT_READ_*_AVG). The number we write is an exponent of base 2 of the number of samples so for

Re: [PATCH v2 1/3] pmbus: introduce PMBUS_VIRT_*_SAMPLES registers

2019-04-14 Thread Guenter Roeck
On 4/13/19 9:03 AM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: Those virtual registers can be used to export manufacturer specific functionality for controlling the number of samples for average values reported by the device. Signed-off-by: Krzysztof Adamski ---

Re: [PATCH v2 00/21] Convert hwmon documentation to ReST

2019-04-12 Thread Guenter Roeck
On 4/12/19 9:04 AM, Jonathan Corbet wrote: On Thu, 11 Apr 2019 14:07:31 -0700 Guenter Roeck wrote: While nobody does such split, IMHO, the best would be to keep the information outside Documentation/admin-guide. But hey! You're the Doc maintainer. If you prefer to move, I'm perfectly fine

Re: [PATCH v2 00/21] Convert hwmon documentation to ReST

2019-04-12 Thread Guenter Roeck
On 4/12/19 5:25 PM, Mauro Carvalho Chehab wrote: Em Fri, 12 Apr 2019 09:12:52 -0700 Guenter Roeck escreveu: On 4/12/19 9:04 AM, Jonathan Corbet wrote: On Thu, 11 Apr 2019 14:07:31 -0700 Guenter Roeck wrote: While nobody does such split, IMHO, the best would be to keep the information

Re: [PATCH v3] hwmon: (pmbus/ir38064): Add driver for Infineon IR38064 Voltage Regulator

2019-04-12 Thread Guenter Roeck
On 4/12/19 1:37 PM, Patrick Venture wrote: From: Maxim Sloyko Add the pmbus driver for the Infineon ir38064 voltage regulator. VOUT_MODE is not supported by the device. The driver fakes linear16 mode with exponent value -8. The device supports VOUT_PEAK, IOUT_PEAK, and TEMPERATURE_PEAK,

Re: [PATCH v2] hwmon: (pmbus/ir38064): Add driver for Infineon IR38064 Voltage Regulator

2019-04-12 Thread Guenter Roeck
On 4/12/19 12:43 PM, Patrick Venture wrote: From: Maxim Sloyko Add the pmbus driver for the Infineon ir38064 voltage regulator. Signed-off-by: Maxim Sloyko Signed-off-by: Patrick Venture --- v2: - Cleaned up weird tabbing behavior in doc. v1: - Initial patchset. ---

Re: [PATCH RESEND] hwmon: pwm-fan: Report probe errors consistently

2019-04-12 Thread Guenter Roeck
On Fri, Apr 12, 2019 at 03:05:23PM +0100, Robin Murphy wrote: > Printing the error code for a failure provides a head-start for > debugging, since it's often sufficient to pinpoint the origin of the > failure. We already do this for some probe-failure messages, so let's > make the rest of them

Re: [PATCH] Documentation: hwmon: ir35221: fix company name

2019-04-12 Thread Guenter Roeck
On Fri, Apr 12, 2019 at 09:27:42AM -0700, Patrick Venture wrote: > Fix the company name from "Infinion" to "Infineon." > > Signed-off-by: Patrick Venture Applied to hwmon-next. Thanks, Guenter

Re: [PATCH V5 0/3] hwmon: pwm-fan: Add RPM support

2019-04-12 Thread Guenter Roeck
On 4/11/19 6:30 AM, Stefan Wahren wrote: Contrary to the gpio-fan the pwm-fan driver isn't easy to setup with pwmconfig/fancontrol because of the missing hwmon sysfs entry for actual revolutions per minute. This series adds this feature. Series applied to hwmon-next. Thanks, Guenter

Re: [PATCH v2 00/21] Convert hwmon documentation to ReST

2019-04-12 Thread Guenter Roeck
On 4/12/19 9:04 AM, Jonathan Corbet wrote: On Thu, 11 Apr 2019 14:07:31 -0700 Guenter Roeck wrote: While nobody does such split, IMHO, the best would be to keep the information outside Documentation/admin-guide. But hey! You're the Doc maintainer. If you prefer to move, I'm perfectly fine

Re: Couple of questions on SCMI sensor protocol and Linux implementation

2019-04-12 Thread Guenter Roeck
On 4/12/19 6:57 AM, Sudeep Holla wrote: On Tue, Apr 02, 2019 at 08:22:58PM -0700, Florian Fainelli wrote: Hi Sudeep, There are a couple of things on which I would appreciate your feedback regarding the Linux SCMI sensor protocol: 1) The Linux SCMI implementation has all the nuts and bolts to

Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

2019-04-12 Thread Guenter Roeck
On 4/12/19 6:54 AM, Robin Murphy wrote: On 12/04/2019 14:50, Guenter Roeck wrote: On 4/12/19 4:50 AM, Robin Murphy wrote: On 12/04/2019 12:07, Stefan Wahren wrote: On 11.04.19 18:57, Guenter Roeck wrote: On Thu, Apr 11, 2019 at 03:30:11PM +0200, Stefan Wahren wrote: -ATTRIBUTE_GROUPS

Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

2019-04-12 Thread Guenter Roeck
On 4/12/19 4:50 AM, Robin Murphy wrote: On 12/04/2019 12:07, Stefan Wahren wrote: On 11.04.19 18:57, Guenter Roeck wrote: On Thu, Apr 11, 2019 at 03:30:11PM +0200, Stefan Wahren wrote: -ATTRIBUTE_GROUPS(pwm_fan); +static umode_t pwm_fan_attrs_visible(struct kobject *kobj, struct attribute

Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

2019-04-12 Thread Guenter Roeck
On 4/12/19 6:35 AM, Stefan Wahren wrote: Hi Enrico, On 12.04.19 15:15, Enrico Weigelt, metux IT consult wrote: On 11.04.19 15:30, Stefan Wahren wrote: This adds RPM support to the pwm-fan driver in order to use with fancontrol/pwmconfig. This feature is intended for fans with a tachometer

Re: [PATCH v2 00/21] Convert hwmon documentation to ReST

2019-04-11 Thread Guenter Roeck
On Thu, Apr 11, 2019 at 05:43:57PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 11 Apr 2019 12:43:24 -0600 > Jonathan Corbet escreveu: > > > On Wed, 10 Apr 2019 16:22:37 -0300 > > Mauro Carvalho Chehab wrote: > > > > > This series converts the contents of Documentation/hwmon to ReST > > >

Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

2019-04-11 Thread Guenter Roeck
On Thu, Apr 11, 2019 at 03:30:11PM +0200, Stefan Wahren wrote: > This adds RPM support to the pwm-fan driver in order to use with > fancontrol/pwmconfig. This feature is intended for fans with a tachometer > output signal, which generate a defined number of pulses per revolution. > >

Re: [PATCH 1/3] pmbus: support for custom sysfs attributes

2019-04-11 Thread Guenter Roeck
On 4/11/19 12:53 AM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: On Wed, Apr 10, 2019 at 05:35:21PM -0700, Guenter Roeck wrote: On 4/10/19 3:38 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: This patch makes it possible to pass custom struct attribute_group array via

Re: [PATCH 2/3] lm25066: export sysfs attribute for SAMPLES_FOR_AVG

2019-04-11 Thread Guenter Roeck
On 4/11/19 1:09 AM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: On Wed, Apr 10, 2019 at 09:24:29PM -0700, Nicolin Chen wrote: On Wed, Apr 10, 2019 at 05:55:19PM -0700, Guenter Roeck wrote: +static ssize_t samples_for_avg_show(struct device *dev, + struct

Re: [PATCH 2/3] lm25066: export sysfs attribute for SAMPLES_FOR_AVG

2019-04-10 Thread Guenter Roeck
On 4/10/19 3:39 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: Register custom sysfs attribute to be registered by pmbus allowing read/write access to the manufacturer specific SAMPLES_FOR_AVG register. This register allows setting the number of samples used in computing the average values

Re: [PATCH 1/3] pmbus: support for custom sysfs attributes

2019-04-10 Thread Guenter Roeck
On 4/10/19 3:38 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: This patch makes it possible to pass custom struct attribute_group array via the pmbus_driver_info struct so that those can be added to the attribute groups passed to hwmon_device_register_with_groups(). This makes it possible

Re: [PATCH 3/3] pmbus: export coefficients via sysfs

2019-04-10 Thread Guenter Roeck
On 4/10/19 3:39 PM, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: In order to get best accuracy, in case of some devices it is required to tweak coefficient values. This is especially true for devices using some external shunt resistor or being operated in non-usual environment. Those values

Re: [PATCH 01/21] docs: hwmon: k10temp: convert to ReST format

2019-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2019 at 08:11:51AM -0300, Mauro Carvalho Chehab wrote: > Convert k10temp to ReST format, in order to allow it to > be parsed by Sphinx. > > Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab The first Signed-off-by: is bad. This affects all patches in the

Re: [PATCH v2 1/2] hwmon: (occ) Move common code to a separate module

2019-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2019 at 11:21:47AM -0700, Guenter Roeck wrote: > Jean, > > On Wed, Apr 10, 2019 at 12:47:26PM +0200, Jean Delvare wrote: > > Instead of duplicating the common code into the 2 (binary) drivers, > > move the common code to a separate module. This is cleaner

Re: [PATCH v2 1/2] hwmon: (occ) Move common code to a separate module

2019-04-10 Thread Guenter Roeck
Jean, On Wed, Apr 10, 2019 at 12:47:26PM +0200, Jean Delvare wrote: > Instead of duplicating the common code into the 2 (binary) drivers, > move the common code to a separate module. This is cleaner. > > Signed-off-by: Jean Delvare > Cc: Eddie James > Cc: Guenter Roeck

Re: [PATCH] hwmon: OCC drivers are PowerPC-only

2019-04-09 Thread Guenter Roeck
a BMC processor > connected to a PowerPC processor. BMC will most likely be ARM, but shouldn't > be restricted to that arch only. > > > > > >Also drop configuration symbol SENSORS_OCC which serves no purpose > >that I can see. > > > >Signed-off-by: Jean Delvare &

Re: pmbus based power regulator

2019-04-09 Thread Guenter Roeck
On 4/9/19 6:07 AM, Michal Simek wrote: On 09. 04. 19 15:05, Guenter Roeck wrote: On 4/9/19 5:56 AM, Michal Simek wrote: Hi, I have one question about hwmon/pmbus. I have tps544b25 on the board. I have enabled this chip via DT to get probed. Patch below. I can't see any issue with monitoring

Re: pmbus based power regulator

2019-04-09 Thread Guenter Roeck
On 4/9/19 5:56 AM, Michal Simek wrote: Hi, I have one question about hwmon/pmbus. I have tps544b25 on the board. I have enabled this chip via DT to get probed. Patch below. I can't see any issue with monitoring but I am curious how to enable setting up voltage. I expect this should be moved to

Re: pmbus based power regulator

2019-04-09 Thread Guenter Roeck
On 4/9/19 5:56 AM, Michal Simek wrote: Hi, I have one question about hwmon/pmbus. I have tps544b25 on the board. I have enabled this chip via DT to get probed. Patch below. I can't see any issue with monitoring but I am curious how to enable setting up voltage. I expect this should be moved to

Re: [PATCH v3 3/4] lib: logic_pio: Reject accesses to unregistered CPU MMIO regions

2019-04-08 Thread Guenter Roeck
On 4/8/19 1:19 AM, John Garry wrote: On 05/04/2019 19:29, Guenter Roeck wrote: On Fri, Apr 05, 2019 at 01:06:15PM -0500, Bjorn Helgaas wrote: On Fri, Apr 05, 2019 at 09:10:27AM +0100, John Garry wrote: On 04/04/2019 19:58, Bjorn Helgaas wrote: On Thu, Apr 04, 2019 at 10:43:36AM -0700

[PATCH 2/2] hwmon: (vt1211) Use request_muxed_region for Super-IO accesses

2019-04-05 Thread Guenter Roeck
by multiple drivers is synchronized. Fixes: 2219cd81a6cd ("hwmon/vt1211: Add probing of alternate config index port") Signed-off-by: Guenter Roeck --- drivers/hwmon/vt1211.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/vt1211.c b/dri

[PATCH 1/2] hwmon: (w83627hf) Use request_muxed_region for Super-IO accesses

2019-04-05 Thread Guenter Roeck
by multiple drivers is synchronized. Fixes: b72656dbc491 ("hwmon: (w83627hf) Stop using globals for I/O port numbers") Signed-off-by: Guenter Roeck --- drivers/hwmon/w83627hf.c | 42 +- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git

[PATCH v2] hwmon: (smsc47m1) Use request_muxed_region for Super-IO accesses

2019-04-05 Thread Guenter Roeck
by multiple drivers is synchronized. Fixes: 8d5d45fb1468 ("I2C: Move hwmon drivers (2/3)") Reported-by: Kefeng Wang Reported-by: John Garry Cc: John Garry Signed-off-by: Guenter Roeck --- v2: Fix subject, handle error in smsc47m1_restore() drivers/hwmon/smsc4

Re: [PATCH 4/4] hwmon: (smsc47b397) Use request_muxed_region for Super-IO accesses

2019-04-05 Thread Guenter Roeck
On Fri, Apr 05, 2019 at 06:25:13AM -0700, Guenter Roeck wrote: > On 4/5/19 1:46 AM, John Garry wrote: > >On 05/04/2019 08:47, John Garry wrote: > >>On 04/04/2019 19:33, Guenter Roeck wrote: > >>>Super-IO accesses may fail on a system with no or unmapped LPC bus. >

Re: [PATCH 4/4] hwmon: (smsc47b397) Use request_muxed_region for Super-IO accesses

2019-04-05 Thread Guenter Roeck
On 4/5/19 1:46 AM, John Garry wrote: On 05/04/2019 08:47, John Garry wrote: On 04/04/2019 19:33, Guenter Roeck wrote: Super-IO accesses may fail on a system with no or unmapped LPC bus. BTW, these may still require attention: sch56xx-common smsc47m1 Those two already call

[PATCH 12/16] hwmon: (vt8231) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Cc: Roger Lucas Signed-off-by: Guenter Roeck --- drivers

[PATCH 16/16] hwmon: (adm1029) Use permission specific [SENSOR_][DEVICE_]ATTR variants

2019-04-04 Thread Guenter Roeck
used to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Cc: Corentin Labbe Signed-off-by: Guenter Roeck

[PATCH 14/16] hwmon: (smsc47m1) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/smsc47m1.c

[PATCH 11/16] hwmon: (sis5595) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/sis5595.c | 92

[PATCH 10/16] hwmon: (menf21bmc_hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Cc: Andreas Werner Signed-off-by: Guenter Roeck --- drivers

[PATCH 13/16] hwmon: (smsc47m192) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/smsc47m192.c

[PATCH 15/16] hwmon: (w83627hf) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/w83627hf.c

[PATCH 07/16] hwmon: (lm78) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm78.c | 114

[PATCH 08/16] hwmon: (lm85) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm85.c | 340

[PATCH 09/16] hwmon: (via686a) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/via686a.c

[PATCH 04/16] hwmon: (thmc50) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/thmc50.c | 83

[PATCH 05/16] hwmon: (adm1031) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/adm1031.c

[PATCH 06/16] hwmon: (lm87) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm87.c | 165

[PATCH 02/16] hwmon: (adm1026) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/adm1026.c

[PATCH 03/16] hwmon: (adm9240) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/adm9240.c

[PATCH 01/16] hwmon: (adm1025) Use permission specific SENSOR[_DEVICE]_ATTR variants

2019-04-04 Thread Guenter Roeck
to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/adm1025.c | 98

[PATCH 1/4] hwmon: (f71805f) Use request_muxed_region for Super-IO accesses

2019-04-04 Thread Guenter Roeck
Cc: John Garry Signed-off-by: Guenter Roeck --- drivers/hwmon/f71805f.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/f71805f.c b/drivers/hwmon/f71805f.c index 73c681162653..623736d2a7c1 100644 --- a/drivers/hwmon/f71805f.c +++ b/drivers/hwmon

[PATCH 2/4] hwmon: (pc87427) Use request_muxed_region for Super-IO accesses

2019-04-04 Thread Guenter Roeck
by multiple drivers is synchronized. Fixes: ba224e2c4f0a7 ("hwmon: New PC87427 hardware monitoring driver") Reported-by: Kefeng Wang Reported-by: John Garry Cc: John Garry Signed-off-by: Guenter Roeck --- drivers/hwmon/pc87427.c | 14 +- 1 file changed, 13 insertions(+),

[PATCH 4/4] hwmon: (smsc47b397) Use request_muxed_region for Super-IO accesses

2019-04-04 Thread Guenter Roeck
by multiple drivers is synchronized. Fixes: 8d5d45fb1468 ("I2C: Move hwmon drivers (2/3)") Reported-by: Kefeng Wang Reported-by: John Garry Cc: John Garry Signed-off-by: Guenter Roeck --- drivers/hwmon/smsc47m1.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

[PATCH 3/4] hwmon: (smsc47b397) Use request_muxed_region for Super-IO accesses

2019-04-04 Thread Guenter Roeck
by multiple drivers is synchronized. Fixes: 8d5d45fb1468 ("I2C: Move hwmon drivers (2/3)") Reported-by: Kefeng Wang Reported-by: John Garry Cc: John Garry Signed-off-by: Guenter Roeck --- drivers/hwmon/smsc47b397.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletion

[PATCH 06/24] hwmon: (ad7414) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/ad7414.c:218:34: warning: ‘ad7414_of_match’ defined but not used Marking ad7414_of_match as __mayybe_unused fixes the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/ad7414.c | 2 +- 1 file

[PATCH 18/24] hwmon: (lm85) Fix build warning

2019-04-04 Thread Guenter Roeck
The following build warning is seen if CONFIG_OF is disabled. drivers/hwmon/lm85.c:1645:34: warning: ‘lm85_of_match’ defined but not used Mark lm85_of_match as __maybe_unused to ix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm85.c | 2 +- 1 file changed, 1 insertion

[PATCH 24/24] hwmon: (ina2xx) Fix build warning

2019-04-04 Thread Guenter Roeck
The following build warning is seen if CONFIG_OF is disabled. drivers/hwmon/ina2xx.c:510:34: warning: ‘ina2xx_of_match’ defined but not used Mark ina2xx_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/ina2xx.c | 2 +- 1 file changed, 1

[PATCH 09/24] hwmon: (ads1015) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/ads1015.c:310:34: warning: ‘ads1015_of_match’ defined but not used Marking ads1015_of_match as __maybe_unused fixes the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/ads1015.c | 2 +- 1 file

[PATCH 22/24] hwmon: lm95245: Fix build warnings

2019-04-04 Thread Guenter Roeck
: ‘lm95245_reg_address’ defined but not used The array is no longer used since commit c0a4b9ec1b43 ("hwmon: (lm95245) Use new hwmon registration API"). Remove it. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm95245.c | 15 +-- 1 file changed, 1 insertion(+), 14

[PATCH 20/24] hwmon: (stts751) Fix build warning

2019-04-04 Thread Guenter Roeck
The following build warning is seen if CONFIG_OF is disabled. drivers/hwmon/stts751.c:88:34: warning: ‘stts751_of_match’ defined but not used Mark stts751_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/stts751.c | 2 +- 1 file changed, 1

[PATCH 23/24] hwmon: (lm63) Fix build warning

2019-04-04 Thread Guenter Roeck
The following build warning is seen if CONFIG_OF is disabled. drivers/hwmon/lm63.c:1156:34: warning: ‘lm63_of_match’ defined but not used Mark lm63_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm63.c | 2 +- 1 file changed, 1 insertion

[PATCH 21/24] hwmon: (tmp421) Fix build warning

2019-04-04 Thread Guenter Roeck
The following build warning is seen if CONFIG_OF is disabled. drivers/hwmon/tmp421.c:73:34: warning: ‘tmp421_of_match’ defined but not used Mark tmp421_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/tmp421.c | 2 +- 1 file changed, 1

[PATCH 07/24] hwmon: (tmp102) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/tmp102.c:324:34: warning: ‘tmp102_of_match’ defined but not used Mark it as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/tmp102.c | 2 +- 1 file changed, 1

[PATCH 01/24] hwmon: (pmbus/tps53679) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/pmbus/tps53679.c:100:34: warning: ‘tps53679_of_match’ defined but not used Marking tps53679_of_match as __maybe_unused fixes the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/pmbus/tps53679.c

[PATCH 03/24] hwmon: (ltc4151) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/ltc4151.c:211:34: warning: ‘ltc4151_match’ defined but not used Mark ltc4151_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/ltc4151.c | 2 +- 1 file changed

[PATCH 19/24] hwmon: (max6621) Fix build warning

2019-04-04 Thread Guenter Roeck
The following build warning is seen if CONFIG_OF is disabled. drivers/hwmon/max6621.c:573:34: warning: ‘max6621_of_match’ defined but not used Mark max6621_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/max6621.c | 2 +- 1 file changed, 1

[PATCH 17/24] hwmon: (max6650) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/max6650.c:137:34: warning: ‘max6650_dt_match’ defined but not used Mark max6650_dt_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/max6650.c | 2 +- 1 file

[PATCH 15/24] hwmon: (ina209) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/ina209.c:590:34: warning: ‘ina209_of_match’ defined but not used Mark ina209_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/ina209.c | 2 +- 1 file

[PATCH 04/24] hwmon: (lm90) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/lm90.c:239:34: warning: ‘lm90_of_match’ defined but not used Mark lm90_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm90.c | 2 +- 1 file changed, 1

<    1   2   3   4   5   6   7   8   9   10   >