[PATCH 13/24] hwmon: (w83773g) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/w83773g.c:47:34: warning: ‘w83773_of_match’ defined but not used Mark w83773_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/w83773g.c | 2 +- 1 file

[PATCH 16/24] hwmon: (max6697) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/max6697.c:653:34: warning: ‘max6697_of_match’ defined but not used Mark max6697_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/max6697.c | 2 +- 1 file

[PATCH 08/24] hwmon: (tmp103) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/tmp103.c:173:34: warning: ‘tmp103_of_match’ defined but not used Marking tmp103_of_match as __maybe_unused fixes the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/tmp103.c | 2 +- 1 file

[PATCH 14/24] hwmon: (lm75) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/lm75.c:446:34: warning: ‘lm75_of_match’ defined but not used Mark lm75_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm75.c | 2 +- 1 file changed, 1

[PATCH 02/24] hwmon: (pmbus/ucd900) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/pmbus/ucd9000.c:154:34: warning: ‘ucd9000_of_match’ defined but not used Mark ucd9000_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/pmbus/ucd9000.c | 2

[PATCH 11/24] hwmon: (hih6130) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/hih6130.c:255:34: warning: ‘hih6130_of_match’ defined but not used Mark hih6130_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/hih6130.c | 2 +- 1 file

[PATCH 12/24] hwmon: (ads7828) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/ads7828.c:203:34: warning: ‘ads7828_of_match’ defined but not used Mark ads7828_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/ads7828.c | 2 +- 1 file

[PATCH 05/24] hwmon: (adc128d818) Fix build warning

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/adc128d818.c:524:34: warning: ‘adc128_of_match’ defined but not used Mark adc128_of_match as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/adc128d818.c | 2 +- 1

[PATCH] hwmon: (pmbus/ucd9200): Mark ucd9200_of_match as maybe_unused

2019-04-04 Thread Guenter Roeck
If CONFIG_OF is not enabled, the following build warning is observed. drivers/hwmon/pmbus/ucd9200.c:50:34: warning: ‘ucd9200_of_match’ defined but not used Mark it as __maybe_unused to fix the problem. Signed-off-by: Guenter Roeck --- drivers/hwmon/pmbus/ucd9200.c | 2 +- 1 file

Re: [PATCH V4 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

2019-04-03 Thread Guenter Roeck
On Wed, Apr 03, 2019 at 04:59:35PM +0100, Robin Murphy wrote: > On 03/04/2019 10:55, Stefan Wahren wrote: > >Hi Guenter, > > > >Am 02.04.19 um 22:55 schrieb Guenter Roeck: > >>On Tue, Apr 02, 2019 at 04:21:50PM +0200, Stefan Wahren wrote: > >>>This adds

Re: [PATCH] hwmon: pwm-fan: Disable PWM if fetching cooling data fails

2019-04-03 Thread Guenter Roeck
On Wed, Apr 03, 2019 at 02:48:33PM +0200, Stefan Wahren wrote: > In case pwm_fan_of_get_cooling_data() fails we should disable the PWM > just like in the other error cases. > > Reported-by: Guenter Rock > Signed-off-by: Stefan Wahren > Fixes: 2e5219c77183 ("hwmon: (pwm-fan) Read PWM FAN

Re: [PATCH V4 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

2019-04-02 Thread Guenter Roeck
On Tue, Apr 02, 2019 at 04:21:50PM +0200, Stefan Wahren wrote: > This adds RPM support to the pwm-fan driver in order to use with > fancontrol/pwmconfig. This feature is intended for fans with a tachometer > output signal, which generate a defined number of pulses per revolution. > >

Re: [PATCH 7/7] hwmon/drivers/core: Simplify complex dependency

2019-04-02 Thread Guenter Roeck
ERMAL_OF) > > CONFIG_THERMAL can not be a module anymore, then: > > if defined(CONFIG_THERMAL) && defined(CONFIG_THERMAL_OF) > > And CONFIG_THERMAL_OF already depends on CONFIG_THERMAL, so: > > if defined(CONFIG_THERMAL_OF) > > Thus, > > ifdef CONFIG_THER

[GIT PULL] hwmon fixes for hwmon-for-v5.1-rc4

2019-04-02 Thread Guenter Roeck
-bindings: hwmon: (adc128d818) Specify ti,mode property size Eddie James (1): hwmon: (occ) Fix power sensor indexing Guenter Roeck (1): hwmon: (ntc_thermistor) Fix temperature type reporting Documentation/devicetree/bindings/hwmon/adc128d818.txt | 4 ++-- drivers/hwmon/Kconfig

[PATCH] hwmon: (jz4740) Use devm_platform_ioremap_resource

2019-04-01 Thread Guenter Roeck
The new helper devm_platform_ioremap_resource() wraps platform_get_resource() and devm_ioremap_resource() together. Use it to simplify the code. Signed-off-by: Guenter Roeck --- drivers/hwmon/jz4740-hwmon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hwmon

[PATCH 17/17] hwmon: (w83773g) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/w83773g.c | 30 ++ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/hwmon/w83773g.c b/drivers/

[PATCH 16/17] hwmon: (tmp108) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/tmp108.c | 29 ++--- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.

[PATCH 15/17] hwmon: (tmp102) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/tmp102.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.

[PATCH 13/17] hwmon: (npcm750-pwm-fan) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Cc: Avi Fishman Cc: Tomer Maimon Cc: Patrick Venture Cc: Nancy Yuen Cc: Brendan Higgins Signed-off-by: Guenter Roeck --- drivers/hwmon/npcm750-pwm-fan.c | 70 +++---

[PATCH 14/17] hwmon: (raspberrypi-hwmon) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/raspberrypi-hwmon.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/hwmon/raspberrypi-hwmon.c b/drivers/hwm

[PATCH 09/17] hwmon: (ltq-cputemp) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/ltq-cputemp.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/hwmon/ltq-cputemp.c b/drivers/hwmo

[PATCH 10/17] hwmon: (max31790) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/max31790.c | 58 +--- 1 file changed, 20 insertions(+), 38 deletions(-) diff --git a/drivers/hwmon/m

[PATCH 08/17] hwmon: (ltc4245) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/ltc4245.c | 73 - 1 file changed, 23 insertions(+), 50 deletions(-) diff --git a/drivers/hwmon

[PATCH 12/17] hwmon: (mlxreg-fan) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/mlxreg-fan.c | 48 +++--- 1 file changed, 15 insertions(+), 33 deletions(-) diff --git a/drivers/hwmon/mlxre

[PATCH 11/17] hwmon: (max6621) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/max6621.c | 42 -- 1 file changed, 12 insertions(+), 30 deletions(-) diff --git a/drivers/hwmon/max6621.c b/d

[PATCH 02/17] hwmon: (ina3221) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. The patch was post-edited to retain comments. Signed-off-by: Guenter Roeck --- drivers/hwmon/ina3221.c | 48 +++- 1 file changed, 15 insertions(+), 33 delet

[PATCH 06/17] hwmon: (lm95241) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm95241.c | 34 -- 1 file changed, 8 insertions(+), 26 deletions(-) diff --git a/drivers/hwmon/lm95241.c b/drivers/

[PATCH 04/17] hwmon: (lm75) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm75.c | 32 1 file changed, 4 insertions(+), 28 deletions(-) diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.

[PATCH 05/17] hwmon: (lm90) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm90.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c index 480d70a5177

[PATCH 03/17] hwmon: (jc42) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/jc42.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c index 4fa48

[PATCH 07/17] hwmon: (lm95245) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/lm95245.c | 34 +- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/drivers/hwmon/lm95245.c b/drivers/

[PATCH 00/17] hwmon: Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
The HWMON_CHANNEL_INFO macro simplifies the code, reduces the likelihood of errors, and makes the code easier to read. This series converts all hwmon drivers to use the macro if possible. The conversion is done automatically with coccinelle. The semantic patch used to make this change is as

[PATCH 01/17] hwmon: (adt7411) Use HWMON_CHANNEL_INFO macro

2019-04-01 Thread Guenter Roeck
not introduce functional changes. Many thanks to Julia Lawall for providing the semantic patch. Signed-off-by: Guenter Roeck --- drivers/hwmon/adt7411.c | 48 +++- 1 file changed, 15 insertions(+), 33 deletions(-) diff --git a/drivers/hwmon

[PATCH] hwmon: Documentation: Add usage example for HWMON_CHANNEL_INFO

2019-03-31 Thread Guenter Roeck
The new HWMON_CHANNEL_INFO macro simplifies the code, reduces the likelihood of errors, and makes the code easier to read. Add a usage example to help driver writers to actually use it. Signed-off-by: Guenter Roeck --- Documentation/hwmon/hwmon-kernel-api.txt | 13 + 1 file changed

[PATCH] hwmon: (nct7904) Use new HWMON_CHANNEL_INFO() macro

2019-03-29 Thread Guenter Roeck
The new macro simplifies the code, reduces the likelihood of errors, and makes the code easier to read. Signed-off-by: Guenter Roeck --- drivers/hwmon/nct7904.c | 128 +--- 1 file changed, 46 insertions(+), 82 deletions(-) diff --git a/drivers/hwmon

Re: [PATCH v4 2/2] hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver

2019-03-29 Thread Guenter Roeck
On Thu, Mar 28, 2019 at 01:09:37PM +, Charles Keepax wrote: > From: Lucas Tanure > > Lochnagar is an evaluation and development board for Cirrus > Logic Smart CODEC and Amp devices. It allows the connection of > most Cirrus Logic devices on mini-cards, as well as allowing > connection of

Re: [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size

2019-03-29 Thread Guenter Roeck
On Wed, Mar 13, 2019 at 11:11:26AM -0300, Carlos Menin wrote: > By default, cells in DT are 32-bit in size. The driver reads "ti,mode" > using the function of_property_read_u8() which causes the value to be > read incorrectly in little-endian architectures if the size is not > specified. > > Make

Re: [PATCH v4 1/2] hwmon: lochnagar: Add device tree binding document

2019-03-29 Thread Guenter Roeck
On Thu, Mar 28, 2019 at 01:09:36PM +, Charles Keepax wrote: > Lochnagar is an evaluation and development board for Cirrus > Logic Smart CODEC and Amp devices. It allows the connection of > most Cirrus Logic devices on mini-cards, as well as allowing > connection of various application

Re: [PATCH v3 2/2] hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver

2019-03-27 Thread Guenter Roeck
On Wed, Mar 27, 2019 at 03:13:28PM +, Charles Keepax wrote: > From: Lucas Tanure > > Lochnagar is an evaluation and development board for Cirrus > Logic Smart CODEC and Amp devices. It allows the connection of > most Cirrus Logic devices on mini-cards, as well as allowing > connection of

Re: [PATCH] hwmon: adc128d818: Fix value read from Device Tree

2019-03-26 Thread Guenter Roeck
On Tue, Mar 26, 2019 at 12:01:57PM +, Carlos Menin wrote: > On Tue, Mar 12, 2019 at 10:37:04AM -0700, Guenter Roeck wrote: > > On Tue, Mar 12, 2019 at 05:10:48PM +, Carlos Menin wrote: > > > On Tue, Mar 12, 2019 at 08:26:58AM -0700, Guenter Roeck wrote: > > > &

Re: [PATCH v2 2/2] hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver

2019-03-26 Thread Guenter Roeck
On 3/26/19 3:05 AM, Charles Keepax wrote: On Mon, Mar 25, 2019 at 11:47:11AM -0700, Guenter Roeck wrote: On Mon, Mar 25, 2019 at 05:10:54PM +, Charles Keepax wrote: On Mon, Mar 25, 2019 at 09:46:22AM -0700, Guenter Roeck wrote: On Mon, Mar 25, 2019 at 01:16:51PM +, Charles Keepax

Re: [PATCH v2 2/2] hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver

2019-03-25 Thread Guenter Roeck
On Mon, Mar 25, 2019 at 05:10:54PM +, Charles Keepax wrote: > On Mon, Mar 25, 2019 at 09:46:22AM -0700, Guenter Roeck wrote: > > On Mon, Mar 25, 2019 at 01:16:51PM +, Charles Keepax wrote: > > > On Mon, Mar 25, 2019 at 04:17:31AM -0700, Guenter Roeck wrote: > >

Re: [PATCH v2 2/2] hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver

2019-03-25 Thread Guenter Roeck
On Mon, Mar 25, 2019 at 01:16:51PM +, Charles Keepax wrote: > On Mon, Mar 25, 2019 at 04:17:31AM -0700, Guenter Roeck wrote: > > On 3/25/19 4:00 AM, Charles Keepax wrote: > > >From: Lucas Tanure > > > > > >Lochnagar is an evaluation and development boa

Re: [PATCH v2 2/2] hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver

2019-03-25 Thread Guenter Roeck
On 3/25/19 4:00 AM, Charles Keepax wrote: From: Lucas Tanure Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows the connection of most Cirrus Logic devices on mini-cards, as well as allowing connection of various application processor

Re: Userspace matching of hwmon devices to hardware

2019-03-25 Thread Guenter Roeck
On 3/25/19 1:21 AM, Lei YU wrote: This email is to ask/discuss if there is a stable path/name (or whatever) for hwmon devices in the different versions of kernels. In OpenBMC, the service phosphor-hwmon reads the sensors' value and expose to DBus, depending on a configure file that matches the

Re: [PATCH V3 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

2019-03-23 Thread Guenter Roeck
On 3/22/19 1:24 AM, Stefan Wahren wrote: This adds RPM support to the pwm-fan driver in order to use with fancontrol/pwmconfig. This feature is intended for fans with a tachometer output signal, which generate a defined number of pulses per revolution. Signed-off-by: Stefan Wahren ---

Re: [PATCH 3/3] hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver

2019-03-21 Thread Guenter Roeck
On Thu, Mar 21, 2019 at 03:47:53PM +, Charles Keepax wrote: > On Thu, Mar 21, 2019 at 06:14:23AM -0700, Guenter Roeck wrote: > > On 3/21/19 4:59 AM, Charles Keepax wrote: > > >On Wed, Mar 20, 2019 at 09:40:10AM -0700, Guenter Roeck wrote: > > >>On Wed, Mar 20, 201

Re: [PATCH 3/3] hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver

2019-03-21 Thread Guenter Roeck
On 3/21/19 4:59 AM, Charles Keepax wrote: On Wed, Mar 20, 2019 at 09:40:10AM -0700, Guenter Roeck wrote: On Wed, Mar 20, 2019 at 02:58:18PM +, Charles Keepax wrote: From: Lucas Tanure Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows

Re: [PATCH 2/3] hwmon: Add convience macro to define simple static sensors

2019-03-20 Thread Guenter Roeck
On Wed, Mar 20, 2019 at 02:58:17PM +, Charles Keepax wrote: > It takes a fair amount of boiler plate code to add new sensors, add a > macro that can be used to specify simple static sensors. > > Signed-off-by: Charles Keepax Great idea! Applied to hwmon-next; no need to resend. Thanks,

[PATCH] hwmon: (ntc_thermistor) Fix temperature type reporting

2019-03-20 Thread Guenter Roeck
rt to new hwmon API") Signed-off-by: Guenter Roeck --- drivers/hwmon/ntc_thermistor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c index e4f9f7ce92fa..f9abad9e 100644 --- a/drivers/hwmon/ntc_thermistor.c

Re: [PATCH 3/3] hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver

2019-03-20 Thread Guenter Roeck
On Wed, Mar 20, 2019 at 02:58:18PM +, Charles Keepax wrote: > From: Lucas Tanure > > Lochnagar is an evaluation and development board for Cirrus > Logic Smart CODEC and Amp devices. It allows the connection of > most Cirrus Logic devices on mini-cards, as well as allowing > connection of

Re: [PATCH] hwmon: occ: Fix power sensor indexing

2019-03-20 Thread Guenter Roeck
On Tue, Mar 19, 2019 at 04:01:58PM -0500, Eddie James wrote: > In the case of power sensor version 0xA0, the sensor indexing overlapped > with the "caps" power sensors, resulting in probe failure and kernel > warnings. Fix this by specifying the next index for each power sensor > version. > >

Re: [PATCH v2 hwmon-next] hwmon: (mlxreg-fan) Add support for fan capability registers

2019-03-20 Thread Guenter Roeck
On Mon, Mar 18, 2019 at 04:10:28PM +, Vadim Pasternak wrote: > Add support for fan capability registers in order to distinct between > the systems which have minor fan configuration differences. This > reduces the amount of code used to describe such systems. > The capability registers

Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties

2019-03-19 Thread Guenter Roeck
ed to introduce an example of the old > properties which escaped the scope of the later cleanup and has thus > continued to be dutifully copied for new boards despite being useless. > Clean up these remaining undocumented anachronisms to minimise any > further confusion. > > Signed

Re: [PATCH] hwmon: (da9052) Synchronize access with mfd

2019-03-18 Thread Guenter Roeck
On 3/18/19 7:29 AM, Samu Nuutamo wrote: When tsi-as-adc is configured it is possible for in7[0123]_input read to in{70,71,72,73}_input ? return an incorrect value if a concurrent read to in[456]_input is performed. This is likely caused by a concurrent manipulation of the mux channel without

Re: [PATCH v1 hwmon-next] hwmon: (mlxreg-fan) Add support for fan capability registers

2019-03-18 Thread Guenter Roeck
On 3/18/19 7:31 AM, Vadim Pasternak wrote: -Original Message- From: Guenter Roeck On Behalf Of Guenter Roeck Sent: Monday, March 18, 2019 4:18 PM To: Vadim Pasternak Cc: linux-hwmon@vger.kernel.org Subject: Re: [PATCH v1 hwmon-next] hwmon: (mlxreg-fan) Add support for fan capability

Re: [PATCH v1 hwmon-next] hwmon: (mlxreg-fan) Add support for fan capability registers

2019-03-18 Thread Guenter Roeck
On 3/18/19 3:53 AM, Vadim Pasternak wrote: Add support for fan capability registers in order to distinct between the systems which have minor fan configuration differences. This reduces the amount of code used to describe such systems. The capability registers provides system specific

Re: PMBus driver for FSP/3Y Power device with non-standard VOUT values (LINEAR11 vs LINEAR16)

2019-03-16 Thread Guenter Roeck
On Fri, Mar 15, 2019 at 12:38:59PM -0700, Guenter Roeck wrote: > On Fri, Mar 15, 2019 at 11:29:45AM -0700, Guenter Roeck wrote: > > On Fri, Mar 15, 2019 at 10:19:33AM +, Grönke, Christian wrote: > > > Hello Guenter, > > > > > > > -Ursprüngliche Na

Re: PMBus driver for FSP/3Y Power device with non-standard VOUT values (LINEAR11 vs LINEAR16)

2019-03-15 Thread Guenter Roeck
On Fri, Mar 15, 2019 at 11:29:45AM -0700, Guenter Roeck wrote: > On Fri, Mar 15, 2019 at 10:19:33AM +, Grönke, Christian wrote: > > Hello Guenter, > > > > > -Ursprüngliche Nachricht- > > > Von: Guenter Roeck Im Auftrag von Guenter Roeck > > >

Re: PMBus driver for FSP/3Y Power device with non-standard VOUT values (LINEAR11 vs LINEAR16)

2019-03-15 Thread Guenter Roeck
On Fri, Mar 15, 2019 at 10:19:33AM +, Grönke, Christian wrote: > Hello Guenter, > > > -Ursprüngliche Nachricht----- > > Von: Guenter Roeck Im Auftrag von Guenter Roeck > > Gesendet: Donnerstag, 14. März 2019 17:53 > > An: Grönke, Christian > > Cc: lin

Re: [RFC PATCH 2/2] hwmon: (f71805f): Use request_region() in f71805f_init()

2019-03-15 Thread Guenter Roeck
On 3/15/19 4:20 AM, John Garry wrote: On 14/03/2019 17:44, Guenter Roeck wrote: On Thu, Mar 14, 2019 at 05:21:32PM +, John Garry wrote: On 14/03/2019 17:05, Guenter Roeck wrote: On Fri, Mar 15, 2019 at 12:55:16AM +0800, John Garry wrote: Currently the driver does not call request_region

[PATCH] hwmon: (pmbus) Add IEEE 754 half precision support to PMBus core

2019-03-14 Thread Guenter Roeck
PMBus v1.3.1 adds IEEE 754 half precision as additional data format. Add support for it. Cc: Christian Grönke Signed-off-by: Guenter Roeck --- drivers/hwmon/pmbus/pmbus.h | 2 +- drivers/hwmon/pmbus/pmbus_core.c | 142 +-- 2 files changed, 139

Re: [RFC PATCH 2/2] hwmon: (f71805f): Use request_region() in f71805f_init()

2019-03-14 Thread Guenter Roeck
On Thu, Mar 14, 2019 at 05:21:32PM +, John Garry wrote: > On 14/03/2019 17:05, Guenter Roeck wrote: > >On Fri, Mar 15, 2019 at 12:55:16AM +0800, John Garry wrote: > >>Currently the driver does not call request_region() prior to > >>accessing IO port region

Re: [RFC PATCH 1/2] resource: Request IO port regions from children of ioport_resource

2019-03-14 Thread Guenter Roeck
On Fri, Mar 15, 2019 at 12:55:15AM +0800, John Garry wrote: > Currently when we request an IO port region, the request is made directly > to the top resource, ioport_resource. > > There is an issue here, in that drivers may request an IO port region even > if the IO port region has not even been

Re: [RFC PATCH 2/2] hwmon: (f71805f): Use request_region() in f71805f_init()

2019-03-14 Thread Guenter Roeck
On Fri, Mar 15, 2019 at 12:55:16AM +0800, John Garry wrote: > Currently the driver does not call request_region() prior to > accessing IO port regions in f71805f_init(), so add it. > > Signed-off-by: John Garry > --- > drivers/hwmon/f71805f.c | 13 - > 1 file changed, 12

Re: PMBus driver for FSP/3Y Power device with non-standard VOUT values (LINEAR11 vs LINEAR16)

2019-03-14 Thread Guenter Roeck
Hi Christian, On Thu, Mar 14, 2019 at 04:08:32PM +, Grönke, Christian wrote: > > The framework code seemed to work fine. I used your code for the conversion: > linear11 -> 'scaled integer' -> ieee754 > It provided a way to test the code and was easy for me as my tries to do > some other

Re: PMBus driver for FSP/3Y Power device with non-standard VOUT values (LINEAR11 vs LINEAR16)

2019-03-14 Thread Guenter Roeck
On Thu, Mar 14, 2019 at 04:08:32PM +, Grönke, Christian wrote: > Hello Guenter, > > > -Ursprüngliche Nachricht----- > > Von: Guenter Roeck Im Auftrag von Guenter Roeck > > Gesendet: Donnerstag, 14. März 2019 04:19 > > An: Grönke, Christian > > Cc: lin

Re: PMBus driver for FSP/3Y Power device with non-standard VOUT values (LINEAR11 vs LINEAR16)

2019-03-13 Thread Guenter Roeck
ve to follow the pmbus spec to the letter - it is sufficient to declare the VOUT values to be in ieee754 format for your driver. Guenter --- >From 2f80cad52914c674afc5a80a84f4756e1b12d803 Mon Sep 17 00:00:00 2001 From: Guenter Roeck Date: Wed, 13 Mar 2019 14:36:28 -0700 Subject: [PATCH] hwmon: (p

Re: PMBus driver for FSP/3Y Power device with non-standard VOUT values (LINEAR11 vs LINEAR16)

2019-03-13 Thread Guenter Roeck
On Wed, Mar 13, 2019 at 04:20:28PM +, Grönke, Christian wrote: > Hi, > > Thanks for the fast answer. > > > -Ursprüngliche Nachricht- > > Von: Guenter Roeck Im Auftrag von Guenter Roeck > > Gesendet: Mittwoch, 13. März 2019 16:20 > > An: Gr

Re: PMBus driver for FSP/3Y Power device with non-standard VOUT values (LINEAR11 vs LINEAR16)

2019-03-13 Thread Guenter Roeck
On Wed, Mar 13, 2019 at 08:19:41AM -0700, Guenter Roeck wrote: > On Wed, Mar 13, 2019 at 12:31:53PM +, Grönke, Christian wrote: > > Hello all, > > > > I am currently working on a hwmon/pmbus driver for a PMBus capable 3Y > > Power/FSP power supply (YH5301-1EAR).

Re: PMBus driver for FSP/3Y Power device with non-standard VOUT values (LINEAR11 vs LINEAR16)

2019-03-13 Thread Guenter Roeck
On Wed, Mar 13, 2019 at 12:31:53PM +, Grönke, Christian wrote: > Hello all, > > I am currently working on a hwmon/pmbus driver for a PMBus capable 3Y > Power/FSP power supply (YH5301-1EAR). > > The datasheet has limited information. But with the help of some online > sources, other

Re: [PATCH] hwmon: (ina3221) Add averaging mode support

2019-03-12 Thread Guenter Roeck
On Tue, Mar 12, 2019 at 03:04:31PM -0700, Nicolin Chen wrote: > The CONFIG register has a 3-bit averaging mode field for users > to setup the number of samples that are collected and averaged > together. This is very useful to filter noise from sensor data. > > This patch adds an 'average' sysfs

Re: [PATCH] hwmon: adc128d818: Fix value read from Device Tree

2019-03-12 Thread Guenter Roeck
On Tue, Mar 12, 2019 at 05:10:48PM +, Carlos Menin wrote: > On Tue, Mar 12, 2019 at 08:26:58AM -0700, Guenter Roeck wrote: > > On Tue, Mar 12, 2019 at 01:14:39PM +, Carlos Menin wrote: > > > Cells in DT are 32-bits in size. of_property_read_u8() does not work > >

Re: [PATCH] hwmon: adc128d818: Fix value read from Device Tree

2019-03-12 Thread Guenter Roeck
Copying DT maintainer and mailing list. On Tue, Mar 12, 2019 at 08:26:58AM -0700, Guenter Roeck wrote: > On Tue, Mar 12, 2019 at 01:14:39PM +, Carlos Menin wrote: > > Cells in DT are 32-bits in size. of_property_read_u8() does not work > > properly as it returns incorrect v

Re: [PATCH] hwmon: adc128d818: Fix value read from Device Tree

2019-03-12 Thread Guenter Roeck
On Tue, Mar 12, 2019 at 01:14:39PM +, Carlos Menin wrote: > Cells in DT are 32-bits in size. of_property_read_u8() does not work > properly as it returns incorrect values in little-endian architectures. > Fix it by using of_property_read_u32() instead. > Are you saying that pretty much all

Re: [PATCH] hwmon: (w83773g) Select REGMAP_I2C to fix build error

2019-03-11 Thread Guenter Roeck
On Mon, Mar 11, 2019 at 05:57:30PM +0800, Axel Lin wrote: > Select REGMAP_I2C to avoid below build error: > ERROR: "__devm_regmap_init_i2c" [drivers/hwmon/w83773g.ko] undefined! > > Signed-off-by: Axel Lin Applied. Thanks, Guenter > --- > drivers/hwmon/Kconfig | 1 + > 1 file changed, 1

[GIT PULL] hwmon updates for hwmon-for-v5.1

2019-03-04 Thread Guenter Roeck
Logical continuations should be on the previous line checkpatch warning hwmon: (adm1029) Fix function alignment hwmon: (adm1029) Add a comment for locking mutex Eddie James (1): hwmon: (occ) Fix license headers Guenter Roeck (60): hwmon: (gl518sm) Use permission specific

Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75

2019-02-28 Thread Guenter Roeck
On Thu, Feb 28, 2019 at 11:00:44PM +0530, Jagan Teki wrote: > On Thu, Feb 28, 2019 at 8:45 PM Rob Herring wrote: > > > > On Tue, Feb 12, 2019 at 05:08:08PM +0530, Jagan Teki wrote: > > > Add missing dt-binding documentation for lm75 hwmon sensor. > > > > > > Signed-off-by: Jagan Teki [ ... ] >

Re: tmp102 hwmon accessing temp1_input, max, max_hyst

2019-02-27 Thread Guenter Roeck
gt; > hdmi_crit: trip1 { > > temperature = <95000>; > > hysteresis = <2000>; > > type = "critical"; > > }; > >

Re: [PATCH v1 1/1] hwmon: (emc1403) Add support for EMC1444

2019-02-26 Thread Guenter Roeck
On Tue, Feb 26, 2019 at 10:40:05AM -0500, Shravan Kumar Ramani wrote: > EMC1444 is compatible with EMC1404. Add it to device ID table. > Is that some super-secretive chip ? The Microchip website completely fails to provide information about it. It lists a chip with that name under

Re: [hwmon:hwmon-next 88/88] FATAL: drivers/hwmon/ad7418: struct of_device_id is not terminated with a NULL entry!

2019-02-25 Thread Guenter Roeck
On Mon, Feb 25, 2019 at 04:26:56PM +0100, Linus Walleij wrote: > On Mon, Feb 25, 2019 at 4:08 PM kbuild test robot wrote: > > > >> FATAL: drivers/hwmon/ad7418: struct of_device_id is not terminated with > > >> a NULL entry! > > Grrr why do I always do this silly mistake. Sorry :( > And I

Re: [PATCH 2/2] hwmon: (ad7418) Add device tree probing

2019-02-25 Thread Guenter Roeck
On Mon, Jan 28, 2019 at 10:06:37PM +0100, Linus Walleij wrote: > This adds device tree probing for the AD7418 hwmon sensor. > When device tree is not enabled, stub functions will kick > in. > > Tested on the Gateway Cambria GW2358-4. > > Signed-off-by: Linus Walleij Applied to hwmon-next.

Re: [PATCH 1/2] hwmon: (ad741x) Add DT bindings for Analog Devices AD741x

2019-02-25 Thread Guenter Roeck
On Mon, Jan 28, 2019 at 10:06:36PM +0100, Linus Walleij wrote: > This adds device tree bindings for Analog Devices AD741x > as found in Gateway routers. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Linus Walleij > Reviewed-by: Rob Herring Applied to hwmon-next. Thanks, Guenter > --- >

Re: [PATCH V3 2/2] hwmon: pwm-fan: Add optional regulator support

2019-02-23 Thread Guenter Roeck
On Fri, Feb 22, 2019 at 02:45:24PM +0100, Stefan Wahren wrote: > This adds optional regulator support to the pwm-fan driver. This is > necessary for pwm fans which are powered by a switchable supply. > > Signed-off-by: Stefan Wahren Applied to hwmon-next. Thanks, Guenter > --- >

Re: [PATCH V3 1/2] dt-bindings: hwmon: Add optional regulator support to pwm-fan

2019-02-23 Thread Guenter Roeck
On Fri, Feb 22, 2019 at 02:45:23PM +0100, Stefan Wahren wrote: > This adds an optional regulator support (e.g. switchable supply) to the > pwm fan binding. > > Signed-off-by: Stefan Wahren > Reviewed-by: Rob Herring Applied to hwmon-next. Thanks, Guenter > --- >

Re: tmp102 hwmon accessing temp1_input, max, max_hyst

2019-02-21 Thread Guenter Roeck
On Fri, Feb 22, 2019 at 12:32:08AM +0530, Vinay Simha B N wrote: > On Fri, Feb 22, 2019 at 12:18 AM Guenter Roeck wrote: > > > > On Thu, Feb 21, 2019 at 11:46:32PM +0530, Vinay Simha B N wrote: > > > guenter, > > > > > > i want to use these

Re: tmp102 hwmon accessing temp1_input, max, max_hyst

2019-02-21 Thread Guenter Roeck
handling for the tmp102. That should be handled in the tmp102 driver, which would then read the alert bit and report the status as temp1_alarm. Thanks, Guenter > > On Thu, Feb 21, 2019 at 11:25 PM Guenter Roeck wrote: > > > > On Thu, Feb 21, 2019 at 08:21:09PM +0530, Vinay Simha B N

Re: tmp102 hwmon accessing temp1_input, max, max_hyst

2019-02-21 Thread Guenter Roeck
On Thu, Feb 21, 2019 at 08:21:09PM +0530, Vinay Simha B N wrote: > hi, > > could you please suggest, how to export_symbol the tmp102 temp1_input, max > and max_hyst values to another kernel driver? > > We can acess the values > from filp_open("/sys/class/hwmon/hwmon1/temp1_input", O_RDONLY, 0);

Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75

2019-02-21 Thread Guenter Roeck
On 2/20/19 9:22 AM, Jagan Teki wrote: On Tue, Feb 12, 2019 at 5:08 PM Jagan Teki wrote: Add missing dt-binding documentation for lm75 hwmon sensor. Signed-off-by: Jagan Teki --- Changes for v2: - Add all compatible nodes available in lm75. .../devicetree/bindings/hwmon/lm75.txt|

Re: [PATCH 11/11] hwmon/coretemp: Support multi-die/package

2019-02-19 Thread Guenter Roeck
on these systems. Signed-off-by: Zhang Rui Signed-off-by: Len Brown Cc: linux...@vger.kernel.org Cc: linux-hwmon@vger.kernel.org Signed-off-by: Len Brown Acked-by: Guenter Roeck --- drivers/hwmon/coretemp.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH 11/11] hwmon/coretemp: Support multi-die/package

2019-02-19 Thread Guenter Roeck
on these systems. Signed-off-by: Zhang Rui Signed-off-by: Len Brown Cc: linux...@vger.kernel.org Cc: linux-hwmon@vger.kernel.org Signed-off-by: Len Brown Acked-by: Guenter Roeck I assume this will be pushed together with the rest of the series. Thanks, Guenter --- drivers/hwmon/coretemp.c | 9

Re: [PATCH v2 hwmon] hwmon: (pmbus) Fix driver info initialization in probe routine

2019-02-18 Thread Guenter Roeck
On 2/18/19 11:54 AM, Vadim Pasternak wrote: Fix tps53679_probe() by using dynamically allocated "pmbus_driver_info" structure instead of static. Usage of static structures causes overwritten of the field "vrm_version", in case the system is equipped with several tps53679 devices with the

Re: query for hwmon: (mlxreg-fan) patch

2019-02-18 Thread Guenter Roeck
On 2/18/19 12:07 PM, Vadim Pasternak wrote: Hi Guenter, I would like to ask you about the way of sending the patch for drivers/hwmon/mlxreg-fan.c. This patch makes use of new "capability" register, but required commit "platform_data/mlxreg: Add capability field to core platform data" from

Re: [PATCH v1 hwmon] hwmon: (pmbus) Fix driver info initialization in probe routine

2019-02-18 Thread Guenter Roeck
Hi, On Sun, Feb 17, 2019 at 05:41:55PM +, Vadim Pasternak wrote: > Fix tps53679_probe() by using dynamically allocated "pmbus_driver_info" > structure instead of static. Usage of static structures causes > overwritten of the field "vrm_version", in case the system is equipped > with several

[GIT PULL] hwmon fixes for hwmon-for-v5.0-rc7

2019-02-12 Thread Guenter Roeck
-27 18:55:49 -0800) hwmon fix for v5.0-rc7 Fix fan detection for NCT6793D. Guenter Roeck (1): hwmon: (nct6775) Fix fan6 detection for NCT6793D drivers/hwmon

Re: [PATCH] hwmon: (f71882fg) Mark expected switch fall-through

2019-02-12 Thread Guenter Roeck
On Mon, Feb 11, 2019 at 04:07:38PM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/hwmon/f71882fg.c: In function ‘f71882fg_probe’: >

Re: [PATCH] hwmon: (ad7418) Catch I2C errors

2019-02-12 Thread Guenter Roeck
On Thu, Feb 07, 2019 at 03:50:36PM -0600, Brandon Maier wrote: > If there is an i2c failure, the ad7416 reports its temperature as 0C. > Return an error code so users can properly detect errors. > > Signed-off-by: Brandon Maier Applied to hwmon-next. Thanks, Guenter > --- > Tested on an

[PATCH] hwmon: (ntc_thermistor) Convert to new hwmon API

2019-02-12 Thread Guenter Roeck
Use devm_hwmon_device_register_with_info() instead of devm_hwmon_device_register_with_groups() to register the hwmon device to simplify the code and make it easier to maintain. As part of this change, thermal device registration is moved into the hwmon core. Signed-off-by: Guenter Roeck

Re: [PATCH V3 3/6] thermal: Register hwmon in thermal_zone_of_sensor_register_param()

2019-02-12 Thread Guenter Roeck
On 2/12/19 12:52 AM, Geert Uytterhoeven wrote: Hi all, On Mon, Feb 11, 2019 at 9:43 PM Marek Vasut wrote: On 2/6/19 12:24 AM, Eduardo Valentin wrote: On Mon, Jan 28, 2019 at 01:10:11PM +0100, Marek Vasut wrote: On 1/15/19 1:35 AM, Marek Vasut wrote: On 12/22/18 3:19 AM, Marek Vasut wrote:

Re: coretemp driver change on dual-die/package systems

2019-02-11 Thread Guenter Roeck
On 2/11/19 1:46 AM, Zhang Rui wrote: Hi, Jean and Guenter, Per the Intel Software Developer's Manual, which you can found at www.i ntel.com/sdm, when CPUID.1F is present, it is preferred over CPUID.B. New dual-die/package systems will see this difference:    CPUID.0B enumerates the CPUs on

<    1   2   3   4   5   6   7   8   9   10   >