Re: [PATCH] pmbus: added possibility to change timeout for device update

2017-11-02 Thread Romain Porte
On 02/11/2017 14:58, Guenter Roeck wrote: NACK, I'd rather drop the caching entirely, and possibly convert the driver to regmap for caching non-volatile registers. I need to familiarize myself with regmap then, it looks like a nice abstraction to have. Do you think I can propose an intermedia

[PATCH] pmbus: added possibility to change timeout for device update

2017-11-02 Thread Romain Porte
By default the time before really updating a device is hardcoded to one second in the pmbus_core.c file (HZ). This patch proposes a new configuration entry that allows to tune the timeout value before updating a device. It defaults to one second in order to stay compatible with the previous behavio

Re: [1/2] pmbus: added tps544c20 driver with trimming support

2017-10-23 Thread Romain Porte
On 21/10/2017 18:20, Guenter Roeck wrote: This should be part of device programming in manufacturing, just like, say, current calibration. It should not be user programmable, even less so runtime programmable. On top of that, we definitely don't want to make STORE_USER_ALL available to user space

Re: [1/2] pmbus: added tps544c20 driver with trimming support

2017-10-23 Thread Romain Porte
On 21/10/2017 18:20, Guenter Roeck wrote: This should be part of device programming in manufacturing, just like, say, current calibration. It should not be user programmable, even less so runtime programmable. On top of that, we definitely don't want to make STORE_USER_ALL available to user space

[PATCH 2/2] pmbus: removed tps544c20 from generic pmbus driver

2017-10-20 Thread Romain Porte
Since there is a new driver proposed with enhanced features we need to remove support for tps544c20 from the generic pmbus driver. --- drivers/hwmon/pmbus/pmbus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hwmon/pmbus/pmbus.c b/drivers/hwmon/pmbus/pmbus.c index 7718e58dbda5..aeea5c

[PATCH 0/2] pmbus: Add MFR-specific commands for TPS544C20

2017-10-20 Thread Romain Porte
Hello, This patchset provides a new driver for tps544c20 component with enhanced features by using 2 new sysfs entries. The added features are VREF_TRIM (MFR-specific) and STORE_USER_ALL commands for voltage fine-tuning. Since the driver has new features compared to the generic pmbus driver it can

[PATCH 1/2] pmbus: added tps544c20 driver with trimming support

2017-10-20 Thread Romain Porte
0_id[] = { + {"tps544c20", 0}, + {} +}; + +MODULE_DEVICE_TABLE(i2c, tps544c20_id); + +/* This is the driver that will be inserted */ +static struct i2c_driver tps544c20_driver = { + .driver = { + .name = "tps544c20", + }, + .probe =