[PATCH v2 1/2] hwmon: (occ) Move common code to a separate module

2019-04-10 Thread Jean Delvare
Instead of duplicating the common code into the 2 (binary) drivers, move the common code to a separate module. This is cleaner. Signed-off-by: Jean Delvare Cc: Eddie James Cc: Guenter Roeck --- Eddie, can you please give it a try and confirm it works? Note: I kept the module names as they were

Re: [PATCH v2 1/2] hwmon: (occ) Move common code to a separate module

2019-04-10 Thread Eddie James
On 4/10/19 5:47 AM, Jean Delvare wrote: Instead of duplicating the common code into the 2 (binary) drivers, move the common code to a separate module. This is cleaner. Signed-off-by: Jean Delvare Cc: Eddie James Cc: Guenter Roeck --- Eddie, can you please give it a try and confirm it works?

Re: [PATCH v2 1/2] hwmon: (occ) Move common code to a separate module

2019-04-10 Thread Guenter Roeck
Jean, On Wed, Apr 10, 2019 at 12:47:26PM +0200, Jean Delvare wrote: > Instead of duplicating the common code into the 2 (binary) drivers, > move the common code to a separate module. This is cleaner. > > Signed-off-by: Jean Delvare > Cc: Eddie James > Cc: Guenter Roeck what is the parent rele

Re: [PATCH v2 1/2] hwmon: (occ) Move common code to a separate module

2019-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2019 at 11:21:47AM -0700, Guenter Roeck wrote: > Jean, > > On Wed, Apr 10, 2019 at 12:47:26PM +0200, Jean Delvare wrote: > > Instead of duplicating the common code into the 2 (binary) drivers, > > move the common code to a separate module. This is cleaner. > > > > Signed-off-by: J

Re: [PATCH v2 1/2] hwmon: (occ) Move common code to a separate module

2019-04-11 Thread Jean Delvare
On Wed, 10 Apr 2019 13:02:32 -0500, Eddie James wrote: > On 4/10/19 5:47 AM, Jean Delvare wrote: > > Instead of duplicating the common code into the 2 (binary) drivers, > > move the common code to a separate module. This is cleaner. > > > > Signed-off-by: Jean Delvare > > Cc: Eddie James > > Cc: