Re: [RFC 2/4] mfd: add Gateworks System Controller core driver

2018-02-28 Thread Tim Harvey
On Tue, Feb 27, 2018 at 6:00 PM, Randy Dunlap wrote: > On 02/27/2018 05:21 PM, Tim Harvey wrote: >> The Gateworks System Controller (GSC) is an I2C slave controller >> implemented with an MSP430 micro-controller whose firmware embeds the >> following features: >> - I/O

Re: [RFC 2/4] mfd: add Gateworks System Controller core driver

2018-02-28 Thread Andrew Lunn
> + dev_err(>dev, ">> 0x%02x %d\n", reg, ret); > + return ret; > + } > + dev_dbg(>dev, ">> 0x%02x=0x%02x (%d)\n", reg, val, retry); > + > +return 0; Hi Tim There appears to be a few spaces vs tabs issues in this file. Andrew -- To unsubscribe from

Re: [RFC 2/4] mfd: add Gateworks System Controller core driver

2018-02-27 Thread Randy Dunlap
On 02/27/2018 05:21 PM, Tim Harvey wrote: > The Gateworks System Controller (GSC) is an I2C slave controller > implemented with an MSP430 micro-controller whose firmware embeds the > following features: > - I/O expander (16 GPIO's) using PCA955x protocol > - Real Time Clock using DS1672 protocol

[RFC 2/4] mfd: add Gateworks System Controller core driver

2018-02-27 Thread Tim Harvey
The Gateworks System Controller (GSC) is an I2C slave controller implemented with an MSP430 micro-controller whose firmware embeds the following features: - I/O expander (16 GPIO's) using PCA955x protocol - Real Time Clock using DS1672 protocol - User EEPROM using AT24 protocol - HWMON using