Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-08 Thread Bjorn Helgaas
On Wed, Nov 07, 2018 at 05:40:14PM -0800, Guenter Roeck wrote: > On 11/7/18 3:14 PM, Bjorn Helgaas wrote: > > > > > > > > There is no INT3401 on any newer atom or core platforms, so you can't > > > enumerate on this device. We don't control what ACPI device is present > > > on a system. It

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Guenter Roeck
On 11/7/18 3:14 PM, Bjorn Helgaas wrote: There is no INT3401 on any newer atom or core platforms, so you can't enumerate on this device. We don't control what ACPI device is present on a system. It depends on what the other non-Linux OS is using. Sure, you can't *force* OEMs to supply a

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Srinivas Pandruvada
On Wed, 2018-11-07 at 15:30 -0800, Srinivas Pandruvada wrote: > [...] > > > Sure, you can't *force* OEMs to supply a given ACPI device, but you > > can certainly say "if you want this functionality, supply INT3401 > > devices." That's what you do with PNP0A03 (PCI host bridges), for > > example.

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Srinivas Pandruvada
[...] > Sure, you can't *force* OEMs to supply a given ACPI device, but you > can certainly say "if you want this functionality, supply INT3401 > devices." That's what you do with PNP0A03 (PCI host bridges), for > example. If an OEM doesn't supply PNP0A03 devices, the system can > boot just

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Bjorn Helgaas
On Wed, Nov 07, 2018 at 02:42:00PM -0800, Srinivas Pandruvada wrote: > On Wed, 2018-11-07 at 15:31 -0600, Bjorn Helgaas wrote: > > On Wed, Nov 07, 2018 at 11:15:37AM -0800, Srinivas Pandruvada wrote: > > > On Tue, 2018-11-06 at 17:20 -0600, Bjorn Helgaas wrote: > > > > [+cc Sumeet, Srinivas for

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Srinivas Pandruvada
On Wed, 2018-11-07 at 15:31 -0600, Bjorn Helgaas wrote: > On Wed, Nov 07, 2018 at 11:15:37AM -0800, Srinivas Pandruvada wrote: > > On Tue, 2018-11-06 at 17:20 -0600, Bjorn Helgaas wrote: > > > [+cc Sumeet, Srinivas for INT3401 questions below] > > > [Beginning of thread: > > > > > > >

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Bjorn Helgaas
On Wed, Nov 07, 2018 at 11:15:37AM -0800, Srinivas Pandruvada wrote: > On Tue, 2018-11-06 at 17:20 -0600, Bjorn Helgaas wrote: > > [+cc Sumeet, Srinivas for INT3401 questions below] > > [Beginning of thread: > > > https://lore.kernel.org/linux-pci/20181102181055.130531-1-brian.wo...@amd.com/ > >

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Woods, Brian
On Wed, Nov 07, 2018 at 05:07:07PM +0100, Borislav Petkov wrote: > Thanks for explaining. > > So I don't know about temp sensors - I'm talking about amd_nb which is > something... well, I explained already what it is in my previous mail so > I won't repeat myself. > > Anyway, if there is such a

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Srinivas Pandruvada
On Tue, 2018-11-06 at 17:20 -0600, Bjorn Helgaas wrote: > [+cc Sumeet, Srinivas for INT3401 questions below] > [Beginning of thread: > https://lore.kernel.org/linux-pci/20181102181055.130531-1-brian.wo...@amd.com/ > ] > > On Tue, Nov 06, 2018 at 11:00:59PM +0100, Borislav Petkov wrote: > > On

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Borislav Petkov
On Wed, Nov 07, 2018 at 11:10:44AM -0600, Bjorn Helgaas wrote: > No, the idea was more that that temp monitoring, e.g., k10temp, could > be independent of amd_nb. > > But I can tell this idea isn't going anywhere, so let's just forget > that I stuck my neck out and let it die on the vine :) No

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Bjorn Helgaas
On Wed, Nov 07, 2018 at 05:51:22AM -0800, Guenter Roeck wrote: > On 11/7/18 1:18 AM, Borislav Petkov wrote: > > On Tue, Nov 06, 2018 at 05:20:41PM -0600, Bjorn Helgaas wrote: > > > Or maybe even drivers/acpi/thermal.c, which claims every Thermal Zone > > > (ACPI 6.2, sec 11), would be sufficient.

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Bjorn Helgaas
On Wed, Nov 07, 2018 at 05:07:07PM +0100, Borislav Petkov wrote: > On Wed, Nov 07, 2018 at 07:38:56AM -0600, Bjorn Helgaas wrote: > > Firmware supplies ACPI namespace. The namespace contains an abstract > > description of the platform, including devices. Devices are > > identified by PNP IDs,

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Borislav Petkov
On Wed, Nov 07, 2018 at 07:38:56AM -0600, Bjorn Helgaas wrote: > Firmware supplies ACPI namespace. The namespace contains an abstract > description of the platform, including devices. Devices are > identified by PNP IDs, which are analogous to PCI vendor/device IDs, > except that a device may

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Guenter Roeck
On 11/7/18 1:18 AM, Borislav Petkov wrote: On Tue, Nov 06, 2018 at 05:20:41PM -0600, Bjorn Helgaas wrote: Or maybe even drivers/acpi/thermal.c, which claims every Thermal Zone (ACPI 6.2, sec 11), would be sufficient. I don't know what the relationship between hwmon and other thermal stuff,

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Bjorn Helgaas
On Wed, Nov 07, 2018 at 10:18:38AM +0100, Borislav Petkov wrote: > On Tue, Nov 06, 2018 at 05:20:41PM -0600, Bjorn Helgaas wrote: > > Or maybe even drivers/acpi/thermal.c, which claims every Thermal Zone > > (ACPI 6.2, sec 11), would be sufficient. I don't know what the > > relationship between

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-07 Thread Borislav Petkov
On Tue, Nov 06, 2018 at 05:20:41PM -0600, Bjorn Helgaas wrote: > Or maybe even drivers/acpi/thermal.c, which claims every Thermal Zone > (ACPI 6.2, sec 11), would be sufficient. I don't know what the > relationship between hwmon and other thermal stuff, e.g., > Documentation/thermal/sysfs-api.txt

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-06 Thread Bjorn Helgaas
[+cc Sumeet, Srinivas for INT3401 questions below] [Beginning of thread: https://lore.kernel.org/linux-pci/20181102181055.130531-1-brian.wo...@amd.com/] On Tue, Nov 06, 2018 at 11:00:59PM +0100, Borislav Petkov wrote: > On Tue, Nov 06, 2018 at 03:42:56PM -0600, Bjorn Helgaas wrote: > > This isn't

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-06 Thread Borislav Petkov
On Tue, Nov 06, 2018 at 03:42:56PM -0600, Bjorn Helgaas wrote: > This isn't some complicated new device where the programming model > changed on the new CPU. This is a thermometer that was already > supported. ACPI provides plenty of functionality that could be used > to support this

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-06 Thread Bjorn Helgaas
On Mon, Nov 05, 2018 at 10:56:50PM +0100, Borislav Petkov wrote: > On Mon, Nov 05, 2018 at 03:45:37PM -0600, Bjorn Helgaas wrote: > > amd_nb.c prevents us from achieving that goal. These patches don't > > add new functionality; they merely describe minor topographical > > differences in new

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-06 Thread Borislav Petkov
On Mon, Nov 05, 2018 at 11:32:16PM +, Woods, Brian wrote: > Your understanding is correct. It's more so that the following DF/SMN > interface gets mapped correctly. > /* >* If there are more PCI root devices than data fabric/ >* system management

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-05 Thread Woods, Brian
On Mon, Nov 05, 2018 at 10:42:33PM +0100, Borislav Petkov wrote: > Yes please. Because this is the usual kernel coding style of calling a > function (or a loop which has some result in this case) and testing that > result immediately after the function call. Done. > You say "correct" as there is

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-05 Thread Bjorn Helgaas
[+cc Takashi, Andy, Colin, Myron for potential distro impact] [Beginning of thread: https://lore.kernel.org/linux-pci/20181102181055.130531-1-brian.wo...@amd.com/] On Sat, Nov 03, 2018 at 12:29:48AM +0100, Borislav Petkov wrote: > On Fri, Nov 02, 2018 at 02:59:25PM -0500, Bjorn Helgaas wrote: >

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-05 Thread Borislav Petkov
On Mon, Nov 05, 2018 at 08:33:34PM +, Woods, Brian wrote: > I think having them togeter is cleaner. If you aren't finding any > misc IDs, I highly doubt you'll find any root IDs. There shouldn't > be much of a difference in how fast the function exits, either way. > If you want it the other

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-05 Thread Borislav Petkov
On Fri, Nov 02, 2018 at 06:11:07PM +, Woods, Brian wrote: > Add support for new processors which have multiple PCI root complexes > per data fabric/SMN interface. Please write out abbreviations. I believe it is only you and I who know what SMN means. :) > The interfaces per root complex are

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-02 Thread Borislav Petkov
On Fri, Nov 02, 2018 at 02:59:25PM -0500, Bjorn Helgaas wrote: > This isn't my code, and I'm not really objecting to these changes, but > from where I sit, the fact that you need this sort of vendor-specific > topology discovery is a little bit ugly and seems like something of a > maintenance

Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies

2018-11-02 Thread Bjorn Helgaas
On Fri, Nov 02, 2018 at 06:11:07PM +, Woods, Brian wrote: > Add support for new processors which have multiple PCI root complexes > per data fabric/SMN interface. The interfaces per root complex are > redundant and should be skipped. This makes sure the DF/SMN interfaces > get accessed via