[PATCH v2] hwmon: (amc6821) sign extension temperature

2016-11-18 Thread Matt Weber
From: Jared Bents Converts the unsigned temperature values from the i2c read to be sign extended as defined in the datasheet so that negative temperatures are properly read. Signed-off-by: Jared Bents Signed-off-by: Matt Weber

Re: [PATCH] hwmon: (amc6821) sign extension temperature

2016-11-18 Thread Guenter Roeck
On Fri, Nov 18, 2016 at 03:28:30PM -0600, Matthew Weber wrote: > Guenter, > > On Thu, Nov 17, 2016 at 4:18 PM, Guenter Roeck wrote: > > > > On Thu, Nov 17, 2016 at 02:08:41PM -0600, Jared Bents wrote: > > > On Wed, Nov 16, 2016 at 4:51 PM, Guenter Roeck

Re: [PATCH] hwmon: (amc6821) sign extension temperature

2016-11-18 Thread Matthew Weber
Guenter, On Thu, Nov 17, 2016 at 4:18 PM, Guenter Roeck wrote: > > On Thu, Nov 17, 2016 at 02:08:41PM -0600, Jared Bents wrote: > > On Wed, Nov 16, 2016 at 4:51 PM, Guenter Roeck wrote: > > > On Wed, Nov 16, 2016 at 04:23:53PM -0600, Matt Weber wrote: > >

Re: [PATCH v2 2/3] hwmon: ltc2990: add devicetree binding

2016-11-18 Thread Tom Levens
Hi Rob, Thanks for taking the time to look at this patch. On Fri, 18 Nov 2016, Rob Herring wrote: On Thu, Nov 17, 2016 at 01:10:15PM +0100, Tom Levens wrote: Add a devicetree binding for the ltc2990 hwmon driver. Signed-off-by: Tom Levens ---

Re: [PATCH v2 2/3] hwmon: ltc2990: add devicetree binding

2016-11-18 Thread Rob Herring
On Thu, Nov 17, 2016 at 01:10:15PM +0100, Tom Levens wrote: > Add a devicetree binding for the ltc2990 hwmon driver. > > Signed-off-by: Tom Levens > --- > .../devicetree/bindings/hwmon/ltc2990.txt | 28 > > 1 files changed, 28 insertions(+),

Re: [PATCH v2 1/3] hwmon: ltc2990: refactor value conversion

2016-11-18 Thread Guenter Roeck
On 11/18/2016 06:09 AM, Guenter Roeck wrote: The register map wraps at 0x0F, so I only sent you the first 16 bytes. But the fully expanded form is: 0 1 2 3 4 5 6 7 8 9 a b c d e f 00: 00 00 00 00 01 90 07 d0 2c cd 7d 80 7c 29 20 00 10: 00 00 00 00 01 90 07 d0 2c cd 7d 80

Re: [PATCH v2 3/3] hwmon: ltc2990: support all measurement modes

2016-11-18 Thread Guenter Roeck
On 11/18/2016 04:23 AM, Tom Levens wrote: On Fri, 18 Nov 2016, Guenter Roeck wrote: On Thu, Nov 17, 2016 at 11:25:30PM +, Tom Levens wrote: On 17 Nov 2016, at 22:54, Guenter Roeck wrote: On Thu, Nov 17, 2016 at 08:52:12PM +0100, Mike Looijmans wrote: On

Re: [PATCH v2 1/3] hwmon: ltc2990: refactor value conversion

2016-11-18 Thread Guenter Roeck
On 11/18/2016 12:18 AM, Tom Levens wrote: Hi Guenter, On Thu, 17 Nov 2016, Guenter Roeck wrote: On 11/17/2016 08:23 AM, Tom Levens wrote: Hi Guenter, Thanks for taking the time to review the patch. On Thu, 17 Nov 2016, Guenter Roeck wrote: > Hi Tom, > > On 11/17/2016 04:10 AM, Tom

Re: [PATCH v2 3/3] hwmon: ltc2990: support all measurement modes

2016-11-18 Thread Tom Levens
On Fri, 18 Nov 2016, Guenter Roeck wrote: On Thu, Nov 17, 2016 at 11:25:30PM +, Tom Levens wrote: On 17 Nov 2016, at 22:54, Guenter Roeck wrote: On Thu, Nov 17, 2016 at 08:52:12PM +0100, Mike Looijmans wrote: On 17-11-2016 19:56, Guenter Roeck wrote: On Thu, Nov

Re: [PATCH v2 1/3] hwmon: ltc2990: refactor value conversion

2016-11-18 Thread Tom Levens
Hi Guenter, On Thu, 17 Nov 2016, Guenter Roeck wrote: On 11/17/2016 08:23 AM, Tom Levens wrote: Hi Guenter, Thanks for taking the time to review the patch. On Thu, 17 Nov 2016, Guenter Roeck wrote: > Hi Tom, > > On 11/17/2016 04:10 AM, Tom Levens wrote: > > Conversion from raw