Re: [PATCH net-next v2 1/2] net: Add sysfs atttributes for max_mtu min_mtu

2024-04-24 Thread Jakub Kicinski
On Wed, 24 Apr 2024 03:33:37 -0700 Shradha Gupta wrote: > Add sysfs attributes to read max_mtu and min_mtu value for > network devices Absolutely pointless. You posted v1, dumping this as a driver specific value, even tho it's already reported by the core... And you can't even produce a

Re: [PATCH 8/9] drivers/media/*: Convert from tasklet to BH workqueue

2024-04-24 Thread Allen Pais
> On Apr 24, 2024, at 2:12 AM, Hans Verkuil wrote: > > On 27/03/2024 17:03, Allen Pais wrote: >> The only generic interface to execute asynchronously in the BH context is >> tasklet; however, it's marked deprecated and has some design flaws. To >> replace tasklets, BH workqueue support was

Re: [PATCH net-next v2 0/2] Add sysfs attributes for MANA

2024-04-24 Thread Jiri Pirko
Wed, Apr 24, 2024 at 12:32:54PM CEST, shradhagu...@linux.microsoft.com wrote: >These patches include adding sysfs attributes for improving >debuggability on MANA devices. > >The first patch consists on max_mtu, min_mtu attributes that are >implemented generically for all devices > >The second

[PATCH net-next v2 2/2] net: mana: Add new device attributes for mana

2024-04-24 Thread Shradha Gupta
Add new device attributes to read num_ports and max_num_msix setting for MANA device. Signed-off-by: Shradha Gupta --- Changes in v2 * Used the suggested method(v1 dicsussion) to implement sysfs device parameters for MANA device * Implemented attributes max_mtu and min_mtu generically for

[PATCH net-next v2 1/2] net: Add sysfs atttributes for max_mtu min_mtu

2024-04-24 Thread Shradha Gupta
Add sysfs attributes to read max_mtu and min_mtu value for network devices Signed-off-by: Shradha Gupta --- Changes in v2: * Created a new patch for generic attributes --- Documentation/ABI/testing/sysfs-class-net | 16 net/core/net-sysfs.c | 4 2

[PATCH net-next v2 0/2] Add sysfs attributes for MANA

2024-04-24 Thread Shradha Gupta
These patches include adding sysfs attributes for improving debuggability on MANA devices. The first patch consists on max_mtu, min_mtu attributes that are implemented generically for all devices The second patch has mana specific attributes max_num_msix and num_ports Shradha Gupta (2): net:

Re: [PATCH 8/9] drivers/media/*: Convert from tasklet to BH workqueue

2024-04-24 Thread Hans Verkuil
On 27/03/2024 17:03, Allen Pais wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behaves similarly to regular