Re: [PATCH net-next] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-15 Thread Shradha Gupta
On Mon, Jul 15, 2024 at 06:45:51AM -0700, Jakub Kicinski wrote: > On Sun, 14 Jul 2024 20:40:20 -0700 Shradha Gupta wrote: > > + if (ring->rx_jumbo_pending) { > > + netdev_err(ndev, "%s: rx_jumbo_pending not supported\n", > > __func__); > > + return -EINVAL; > > + } > > +

Re: [PATCH net-next] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-15 Thread Shradha Gupta
On Mon, Jul 15, 2024 at 02:28:42PM +0100, Simon Horman wrote: > On Sun, Jul 14, 2024 at 08:40:20PM -0700, Shradha Gupta wrote: > > Currently the values of WQs for RX and TX queues for MANA devices > > are hardcoded to default sizes. > > Allow configuring these values for MANA devices as ringparam >

Re: [PATCH net-next] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-15 Thread Shradha Gupta
On Mon, Jul 15, 2024 at 06:42:16AM +0200, Zhu Yanjun wrote: > ??? 2024/7/15 5:40, Shradha Gupta ??: > >Currently the values of WQs for RX and TX queues for MANA devices > >are hardcoded to default sizes. > >Allow configuring these values for MANA devices as ringparam > >configuration(get/set) t

Re: [RFC PATCH net-next v6 01/14] af_vsock: generalize vsock_dgram_recvmsg() to all transports

2024-07-15 Thread Amery Hung
On Mon, Jul 15, 2024 at 1:02 AM Luigi Leonardi wrote: > > Hi Amery, Bobby > > > From: Bobby Eshleman > > > > This commit drops the transport->dgram_dequeue callback and makes > > vsock_dgram_recvmsg() generic to all transports. > > > > To make this possible, two transport-level changes are introd

Re: [RFC PATCH net-next v6 03/14] af_vsock: support multi-transport datagrams

2024-07-15 Thread Amery Hung
On Mon, Jul 15, 2024 at 1:25 AM Arseniy Krasnov wrote: > > Hi! Sorry, i was not in cc, so I'll reply in this way :) Ope. I will copy you in the next version. > > +static const struct vsock_transport * > +vsock_dgram_lookup_transport(unsigned int cid, __u8 flags) > +{ > + const struct vsock

Re: [PATCH net-next] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-15 Thread Jakub Kicinski
On Sun, 14 Jul 2024 20:40:20 -0700 Shradha Gupta wrote: > + if (ring->rx_jumbo_pending) { > + netdev_err(ndev, "%s: rx_jumbo_pending not supported\n", > __func__); > + return -EINVAL; > + } > + if (ring->rx_mini_pending) { > + netdev_err(ndev, "%s: r

Re: [PATCH net-next] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-15 Thread Simon Horman
On Sun, Jul 14, 2024 at 08:40:20PM -0700, Shradha Gupta wrote: > Currently the values of WQs for RX and TX queues for MANA devices > are hardcoded to default sizes. > Allow configuring these values for MANA devices as ringparam > configuration(get/set) through ethtool_ops. > > Signed-off-by: Shrad

Re: [RFC PATCH net-next v6 03/14] af_vsock: support multi-transport datagrams

2024-07-15 Thread Arseniy Krasnov
Hi! Sorry, i was not in cc, so I'll reply in this way :) +static const struct vsock_transport * +vsock_dgram_lookup_transport(unsigned int cid, __u8 flags) +{ + const struct vsock_transport *transport; + + transport = vsock_connectible_lookup_transport(cid, flags); + if (transpor

Re: [RFC PATCH net-next v6 01/14] af_vsock: generalize vsock_dgram_recvmsg() to all transports

2024-07-15 Thread Luigi Leonardi
Hi Amery, Bobby > From: Bobby Eshleman > > This commit drops the transport->dgram_dequeue callback and makes > vsock_dgram_recvmsg() generic to all transports. > > To make this possible, two transport-level changes are introduced: > - transport in the receiving path now stores the cid and port in