+ madev = NULL;
ret = auxiliary_device_add(adev);
if (ret)
goto add_fail;
Reviewed-by: Przemek Kitszel
On 6/24/24 05:21, Ma Ke wrote:
When auxiliary_device_add() returns error and then calls
auxiliary_device_uninit(), callback function adev_release
I would add () after function name
calls kfree(madev) to free memory. We shouldn't call kfree(padev)
there is no `padev` in the patch :)
"to free
scripts/checkpatch.pl | 19 +++
1 file changed, 19 insertions(+)
Reviewed-by: Przemek Kitszel
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 25fdb7fda112..6924731110d8 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -70
+
net/ethtool/ioctl.c | 7 +++
2 files changed, 20 insertions(+)
Reviewed-by: Przemek Kitszel
On 10/26/23 01:40, Justin Stitt wrote:
Add some warnings for using ethtool_sprintf() where a simple
ethtool_puts() would suffice.
The two cases are:
1) Use ethtool_sprintf() with just two arguments:
| ethtool_sprintf(&data, driver[i].name);
or
2) Use ethtool_sprintf() with a standalone "%
On 10/26/23 01:40, Justin Stitt wrote:
This patch converts some basic cases of ethtool_sprintf() to
ethtool_puts().
The conversions are used in cases where ethtool_sprintf() was being used
with just two arguments:
| ethtool_sprintf(&data, buffer[i].name);
or when it's used with format stri
