Re: [PATCH net, 1/3] net: mana: Fix TX CQE error handling

2023-09-28 Thread Simon Horman
ted packets, so > replace the WARN_ONCE to ratelimited error logging, because we don't > need stack trace here. > > Cc: sta...@vger.kernel.org > Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network > Adapter (MANA)") > Signed-off-by: Haiyang Zhang Reviewed-by: Simon Horman

Re: [PATCH net, 2/3] net: mana: Fix the tso_bytes calculation

2023-09-28 Thread Simon Horman
unters for > easier troubleshooting") > Signed-off-by: Haiyang Zhang Reviewed-by: Simon Horman

Re: [PATCH net, 1/3] net: mana: Fix TX CQE error handling

2023-09-28 Thread Simon Horman
On Fri, Sep 29, 2023 at 07:47:57AM +0200, Simon Horman wrote: > On Sat, Sep 23, 2023 at 06:31:45PM -0700, Haiyang Zhang wrote: > > For an unknown TX CQE error type (probably from a newer hardware), > > still free the SKB, update the queue tail, etc., otherwise the > > acc

Re: [PATCH net, 3/3] net: mana: Fix oversized sge0 for GSO packets

2023-09-29 Thread Simon Horman
On Sat, Sep 23, 2023 at 06:31:47PM -0700, Haiyang Zhang wrote: > Handle the case when GSO SKB linear length is too large. > > MANA NIC requires GSO packets to put only the header part to SGE0, > otherwise the TX queue may stop at the HW level. > > So, use 2 SGEs for the skb linear part which cont

Re: [PATCH net, 1/3] net: mana: Fix TX CQE error handling

2023-09-30 Thread Simon Horman
On Fri, Sep 29, 2023 at 03:51:48PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Simon Horman > > Sent: Friday, September 29, 2023 1:51 AM > > To: Haiyang Zhang > > Cc: linux-hyperv@vger.kernel.org; net...@vger.kernel.org; D

Re: [PATCH net, 3/3] net: mana: Fix oversized sge0 for GSO packets

2023-09-30 Thread Simon Horman
On Fri, Sep 29, 2023 at 04:11:15PM +, Haiyang Zhang wrote: ... > > > @@ -209,19 +281,6 @@ netdev_tx_t mana_start_xmit(struct sk_buff *skb, > > struct net_device *ndev) > > > pkg.wqe_req.client_data_unit = 0; > > > > > > pkg.wqe_req.num_sge = 1 + skb_shinfo(skb)->nr_frags; > > > - WARN_ON_

Re: [PATCH net-next v6] net: hv_netvsc: fix netvsc_send_completion to avoid multiple message length checks

2023-10-01 Thread Simon Horman
ak after a case match and then process > the complete() call. > The current code has not caused any known failures. But nonetheless, the > code should be corrected as a different ordering of the switch cases might > cause a length check to fail when it should not. > > Signed-off-by:

Re: [PATCH net,v2, 3/3] net: mana: Fix oversized sge0 for GSO packets

2023-10-03 Thread Simon Horman
linear part which contains more than the > packet header. > > Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network > Adapter (MANA)") > Signed-off-by: Haiyang Zhang > --- > v2: coding style updates suggested by Simon Horman Reviewed-by: Simon Horman

Re: [PATCH] hyperv: rndis_filter needs to select NLS

2023-10-03 Thread Simon Horman
: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests") > Signed-off-by: Randy Dunlap Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested

Re: [PATCH net-next v7] hv_netvsc: fix netvsc_send_completion to avoid multiple message length checks

2023-10-10 Thread Simon Horman
nia Sharma > > --- > Changes in v3: > * added return statement in default case as pointed by Michael Kelley. > Changes in v4: > * added fixes tag > * modified commit message to explain the issue fixed by patch. > Changes in v5: > * Dropped fixes tag as suggested by Simo

Re: [PATCH net,v4, 2/3] hv_netvsc: Fix race of register_netdevice_notifier and VF register

2023-11-12 Thread Simon Horman
On Fri, Nov 10, 2023 at 06:38:59AM -0800, Haiyang Zhang wrote: > If VF NIC is registered earlier, NETDEV_REGISTER event is replayed, > but NETDEV_POST_INIT is not. > > Move register_netdevice_notifier() earlier, so the call back > function is set before probing. > > Cc: sta...@vger.kernel.org > F

Re: [PATCH net,v4, 1/3] hv_netvsc: fix race of netvsc and VF register_netdevice

2023-11-12 Thread Simon Horman
: e04e7a7bbd4b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier > in netvsc_probe()") > Reported-by: Dexuan Cui > Signed-off-by: Haiyang Zhang > Reviewed-by: Wojciech Drewek Reviewed-by: Simon Horman

Re: [Patch v1 2/4] RDMA/mana_ib: create and process EQ events

2023-11-26 Thread Simon Horman
On Wed, Nov 22, 2023 at 07:10:08PM -0800, lon...@linuxonhyperv.com wrote: > From: Long Li > > Before the software can create an RDMA adapter handle with SoC, it needs to > create EQs for processing SoC events from RDMA device. Because MSI-X > vectors are shared between MANA Ethernet device and RD

Re: [Patch v2 3/3] RDMA/mana_ib: Add CQ interrupt support for RAW QP

2023-12-09 Thread Simon Horman
On Mon, Dec 04, 2023 at 03:02:59PM -0800, lon...@linuxonhyperv.com wrote: > From: Long Li > > At probing time, the MANA core code allocates EQs for supporting interrupts > on Ethernet queues. The same interrupt mechanisum is used by RAW QP. > > Use the same EQs for delivering interrupts on the C

Re: [PATCH] net: mana: select PAGE_POOL

2023-12-18 Thread Simon Horman
make[1]: *** [/home/yury/work/linux/Makefile:234: __sub-make] Error 2 > make[1]: Leaving directory '/home/yury/work/build-linux-x86_64' > make: *** [Makefile:234: __sub-make] Error 2 > > So we need to select it explicitly. > > Signed-off-by: Yury Norov Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested

Re: [PATCH net 1/1] hv_netvsc: Calculate correct ring size when PAGE_SIZE is not 4 Kbytes

2024-01-22 Thread Simon Horman
On Mon, Jan 22, 2024 at 08:20:28AM -0800, mhkelle...@gmail.com wrote: > From: Michael Kelley > > Current code in netvsc_drv_init() incorrectly assumes that PAGE_SIZE > is 4 Kbytes, which is wrong on ARM64 with 16K or 64K page size. As a > result, the default VMBus ring buffer size on ARM64 with 6

Re: [PATCH net 1/1] hv_netvsc: Calculate correct ring size when PAGE_SIZE is not 4 Kbytes

2024-01-24 Thread Simon Horman
On Tue, Jan 23, 2024 at 05:13:12PM +, Michael Kelley wrote: > From: Simon Horman @ 2024-01-22 20:49 UTC (permalink / raw) > > > > On Mon, Jan 22, 2024 at 08:20:28AM -0800, mhkelle...@gmail.com wrote: > > > From: Michael Kelley > > > > > > Current cod

Re: [PATCH V2 net] hv_netvsc: Fix race condition between netvsc_probe and netvsc_remove

2024-02-01 Thread Simon Horman
x27/0x40 [hv_vmbus] > > Cc: sta...@vger.kernel.org > Fixes: ac5047671758 ("hv_netvsc: Disable NAPI before closing the VMBus > channel") > Signed-off-by: Souradeep Chakrabarti > Reviewed-by: Dexuan Cui > Reviewed-by: Haiyang Zhang Reviewed-by: Simon Horman

Re: [PATCH net-next] net: mana: Use mana_cleanup_port_context() for rxq cleanup

2024-06-15 Thread Simon Horman
adha Gupta Thanks for following-up with this clean-up, much appreciated. Reviewed-by: Simon Horman

Re: [PATCH net-next] net: mana: Implement get_ringparam/set_ringparam for mana

2024-07-15 Thread Simon Horman
On Sun, Jul 14, 2024 at 08:40:20PM -0700, Shradha Gupta wrote: > Currently the values of WQs for RX and TX queues for MANA devices > are hardcoded to default sizes. > Allow configuring these values for MANA devices as ringparam > configuration(get/set) through ethtool_ops. > > Signed-off-by: Shrad

Re: [PATCH v2 net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

2024-08-09 Thread Simon Horman
On Wed, Aug 07, 2024 at 04:17:06PM -0700, lon...@linuxonhyperv.com wrote: > From: Long Li > > After napi_complete_done() is called when NAPI is polling in the current > process context, another NAPI may be scheduled and start running in > softirq on another CPU and may ring the doorbell before th