Re: [PATCH 0/3] ethtool: Add ethtool_puts()

2023-10-26 Thread Joe Perches
On Thu, 2023-10-26 at 10:49 -0700, Kees Cook wrote: > On Thu, Oct 26, 2023 at 09:33:17AM -0700, Joe Perches wrote: > > On Thu, 2023-10-26 at 08:47 -0700, Kees Cook wrote: > > > On Wed, Oct 25, 2023 at 11:40:31PM +, Justin Stitt wrote: > > > > @replace_2_args@ > > > > identifier BUF; > > > >

Re: [PATCH 0/3] ethtool: Add ethtool_puts()

2023-10-26 Thread Kees Cook
On Thu, Oct 26, 2023 at 09:33:17AM -0700, Joe Perches wrote: > On Thu, 2023-10-26 at 08:47 -0700, Kees Cook wrote: > > On Wed, Oct 25, 2023 at 11:40:31PM +, Justin Stitt wrote: > > > @replace_2_args@ > > > identifier BUF; > > > expression VAR; > > > @@ > > > > > > - ethtool_sprintf > >

Re: [PATCH 0/3] ethtool: Add ethtool_puts()

2023-10-26 Thread Joe Perches
On Thu, 2023-10-26 at 08:47 -0700, Kees Cook wrote: > On Wed, Oct 25, 2023 at 11:40:31PM +, Justin Stitt wrote: > > @replace_2_args@ > > identifier BUF; > > expression VAR; > > @@ > > > > - ethtool_sprintf > > + ethtool_puts > > (, VAR) > > I think cocci will do a better

Re: [PATCH 0/3] ethtool: Add ethtool_puts()

2023-10-26 Thread Kees Cook
On Wed, Oct 25, 2023 at 11:40:31PM +, Justin Stitt wrote: > @replace_2_args@ > identifier BUF; > expression VAR; > @@ > > - ethtool_sprintf > + ethtool_puts > (, VAR) I think cocci will do a better job at line folding if we adjust this rule like I had to adjust the next

[PATCH 0/3] ethtool: Add ethtool_puts()

2023-10-25 Thread Justin Stitt
Hi, This series aims to implement ethtool_puts() and send out a wave 1 of conversions from ethtool_sprintf(). There's also a checkpatch patch included to check for the cases listed below. This was sparked from recent discussion here [1] The conversions are used in cases where ethtool_sprintf()