RE: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-12-04 Thread Souradeep Chakrabarti
ernel.org; Paul Rosswurm > >Subject: Re: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ >affinity on HT cores > >[You don't often get email from yury.no...@gmail.com. Learn why this is >important at https://aka.ms/LearnAboutSenderIdentification ] > >On Thu, Nov 30, 2023 a

Re: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-30 Thread Yury Norov
r.kernel.org; net...@vger.kernel.org; > > > >linux-ker...@vger.kernel.org; > > > >linux-r...@vger.kernel.org; Souradeep Chakrabarti > > > >; Paul Rosswurm > > > >Subject: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ > > > >affin

Re: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-30 Thread Souradeep Chakrabarti
cai.huoq...@linux.dev; > > >ssen...@linux.microsoft.com; vkuzn...@redhat.com; t...@linutronix.de; > > >linux- > > >hyp...@vger.kernel.org; net...@vger.kernel.org; > > >linux-ker...@vger.kernel.org; > > >linux-r...@vger.kernel.org; Souradeep Chakrabarti > > &g

Re: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-29 Thread Yury Norov
rnel.org; net...@vger.kernel.org; linux-ker...@vger.kernel.org; > >linux-r...@vger.kernel.org; Souradeep Chakrabarti > >; Paul Rosswurm > >Subject: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ > >affinity on > >HT cores > > > >On Tue, 21 N

Re: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-29 Thread Jakub Kicinski
On Wed, 29 Nov 2023 14:17:39 -0800 Souradeep Chakrabarti wrote: > On Mon, Nov 27, 2023 at 10:06:39AM -0800, Jakub Kicinski wrote: > > On Mon, 27 Nov 2023 09:36:38 + Souradeep Chakrabarti wrote: > > > easier to keep things inside the mana driver code here > > > > Easier for who? Upstream

Re: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-29 Thread Souradeep Chakrabarti
On Mon, Nov 27, 2023 at 10:06:39AM -0800, Jakub Kicinski wrote: > On Mon, 27 Nov 2023 09:36:38 + Souradeep Chakrabarti wrote: > > easier to keep things inside the mana driver code here > > Easier for who? Upstream we care about consistency and maintainability > across all drivers. I am

Re: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-27 Thread Florian Fainelli
Subject: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores On Tue, 21 Nov 2023 05:54:37 -0800 Souradeep Chakrabarti wrote: Existing MANA design assigns IRQ to every CPUs, including sibling hyper-threads in a core. This causes multiple IRQs to work on same CPU

Re: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-27 Thread Jakub Kicinski
On Mon, 27 Nov 2023 09:36:38 + Souradeep Chakrabarti wrote: > easier to keep things inside the mana driver code here Easier for who? Upstream we care about consistency and maintainability across all drivers.

Re: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-27 Thread Zhu Yanjun
Subject: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores On Tue, 21 Nov 2023 05:54:37 -0800 Souradeep Chakrabarti wrote: Existing MANA design assigns IRQ to every CPUs, including sibling hyper-threads in a core. This causes multiple IRQs to work on same CPU and may

RE: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-27 Thread Souradeep Chakrabarti
urm >Subject: [EXTERNAL] Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity >on >HT cores > >On Tue, 21 Nov 2023 05:54:37 -0800 Souradeep Chakrabarti wrote: >> Existing MANA design assigns IRQ to every CPUs, including sibling >> hyper-threads in a core. This caus

Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-21 Thread Jakub Kicinski
On Tue, 21 Nov 2023 05:54:37 -0800 Souradeep Chakrabarti wrote: > Existing MANA design assigns IRQ to every CPUs, including sibling > hyper-threads > in a core. This causes multiple IRQs to work on same CPU and may reduce the > network > performance with RSS. > > Improve the performance by

Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-21 Thread kernel test robot
://lore.kernel.org/r/1700574877-6037-1-git-send-email-schakrabarti%40linux.microsoft.com patch subject: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231122/202311220507.k0uewcr0-...@intel.com/config) compiler

RE: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-21 Thread Michael Kelley
From: Souradeep Chakrabarti Sent: Tuesday, November 21, 2023 5:55 AM > > Existing MANA design assigns IRQ to every CPUs, including sibling > hyper-threads "assigns IRQs to every CPU" > in a core. This causes multiple IRQs to work on same CPU and may reduce the > network "This may cause

RE: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-21 Thread Haiyang Zhang
> -Original Message- > From: Souradeep Chakrabarti > Sent: Tuesday, November 21, 2023 8:55 AM > + /* for each interrupt find the cpu of a particular > + * sibling set and if it belongs to the specific numa > + * then assign irq to it and clear the cpu bit from > +

[PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores

2023-11-21 Thread Souradeep Chakrabarti
Existing MANA design assigns IRQ to every CPUs, including sibling hyper-threads in a core. This causes multiple IRQs to work on same CPU and may reduce the network performance with RSS. Improve the performance by adhering the configuration for RSS, which assigns IRQ on HT cores. Signed-off-by: