Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-22 Thread Shradha Gupta
On Fri, Apr 19, 2024 at 08:51:02PM +0200, Andrew Lunn wrote: > On Fri, Apr 19, 2024 at 09:59:26AM -0700, Shradha Gupta wrote: > > On Thu, Apr 18, 2024 at 08:42:59PM +0200, Andrew Lunn wrote: > > > > >From an RDMA perspective this is all available from other APIs already > > > > at least and I

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-19 Thread Andrew Lunn
On Fri, Apr 19, 2024 at 09:59:26AM -0700, Shradha Gupta wrote: > On Thu, Apr 18, 2024 at 08:42:59PM +0200, Andrew Lunn wrote: > > > >From an RDMA perspective this is all available from other APIs already > > > at least and I wouldn't want to see new sysfs unless there is a netdev > > >

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-19 Thread Shradha Gupta
On Thu, Apr 18, 2024 at 08:42:59PM +0200, Andrew Lunn wrote: > > >From an RDMA perspective this is all available from other APIs already > > at least and I wouldn't want to see new sysfs unless there is a netdev > > justification. > > It is unlikely there is a netdev justification. Configuration

RE: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-18 Thread Haiyang Zhang
Abeni > ; Ajay Sharma ; Leon > Romanovsky ; Thomas Gleixner ; > Sebastian Andrzej Siewior ; KY Srinivasan > ; Haiyang Zhang ; Wei Liu > ; Dexuan Cui ; Long Li > ; Michael Kelley ; Shradha > Gupta ; Yury Norov ; > Konstantin Taranov ; Souradeep Chakrabarti > >

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-18 Thread Andrew Lunn
> >From an RDMA perspective this is all available from other APIs already > at least and I wouldn't want to see new sysfs unless there is a netdev > justification. It is unlikely there is a netdev justification. Configuration happens via netlink, not sysfs. Andrew

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-18 Thread Jason Gunthorpe
On Wed, Apr 17, 2024 at 11:01:08PM -0700, Shradha Gupta wrote: > > > > > +static ssize_t mana_attr_show(struct device *dev, > > > > > + struct device_attribute *attr, char *buf) > > > > > +{ > > > > > + struct pci_dev *pdev = to_pci_dev(dev); > > > > > + struct

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-18 Thread Shradha Gupta
On Tue, Apr 16, 2024 at 08:09:35PM +0200, Andrew Lunn wrote: > On Tue, Apr 16, 2024 at 06:27:04AM +0200, Zhu Yanjun wrote: > > ??? 2024/4/15 18:13, Jason Gunthorpe ??: > > > On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: > > > > Add new device attributes to view multiport,

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-17 Thread Shradha Gupta
On Tue, Apr 16, 2024 at 06:27:04AM +0200, Zhu Yanjun wrote: > ??? 2024/4/15 18:13, Jason Gunthorpe ??: > >On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: > >>Add new device attributes to view multiport, msix, and adapter MTU > >>setting for MANA device. > >> > >>Signed-off-by:

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-16 Thread Andrew Lunn
On Tue, Apr 16, 2024 at 06:27:04AM +0200, Zhu Yanjun wrote: > 在 2024/4/15 18:13, Jason Gunthorpe 写道: > > On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: > > > Add new device attributes to view multiport, msix, and adapter MTU > > > setting for MANA device. > > > > > >

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-15 Thread Zhu Yanjun
在 2024/4/15 18:13, Jason Gunthorpe 写道: On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: Add new device attributes to view multiport, msix, and adapter MTU setting for MANA device. Signed-off-by: Shradha Gupta --- .../net/ethernet/microsoft/mana/gdma_main.c | 74

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-15 Thread Shradha Gupta
On Mon, Apr 15, 2024 at 09:38:32AM -0700, Saurabh Singh Sengar wrote: > On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: > > Add new device attributes to view multiport, msix, and adapter MTU > > setting for MANA device. > > > > Signed-off-by: Shradha Gupta > > --- > >

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-15 Thread Shradha Gupta
On Mon, Apr 15, 2024 at 01:13:05PM -0300, Jason Gunthorpe wrote: > On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: > > Add new device attributes to view multiport, msix, and adapter MTU > > setting for MANA device. > > > > Signed-off-by: Shradha Gupta > > --- > >

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-15 Thread Saurabh Singh Sengar
On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: > Add new device attributes to view multiport, msix, and adapter MTU > setting for MANA device. > > Signed-off-by: Shradha Gupta > --- > .../net/ethernet/microsoft/mana/gdma_main.c | 74 +++ >

Re: [PATCH net-next] net: mana: Add new device attributes for mana

2024-04-15 Thread Jason Gunthorpe
On Mon, Apr 15, 2024 at 02:49:49AM -0700, Shradha Gupta wrote: > Add new device attributes to view multiport, msix, and adapter MTU > setting for MANA device. > > Signed-off-by: Shradha Gupta > --- > .../net/ethernet/microsoft/mana/gdma_main.c | 74 +++ >

[PATCH net-next] net: mana: Add new device attributes for mana

2024-04-15 Thread Shradha Gupta
Add new device attributes to view multiport, msix, and adapter MTU setting for MANA device. Signed-off-by: Shradha Gupta --- .../net/ethernet/microsoft/mana/gdma_main.c | 74 +++ include/net/mana/gdma.h | 9 +++ 2 files changed, 83 insertions(+) diff