Re: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-21 Thread Wei Liu
On Fri, Jun 21, 2024 at 04:03:27AM -0700, Saurabh Singh Sengar wrote: > On Fri, Jun 21, 2024 at 06:19:05AM +, Wei Liu wrote: > > On Fri, Jun 21, 2024 at 03:15:19AM +, Michael Kelley wrote: > > > From: Wei Liu Sent: Thursday, June 20, 2024 6:48 PM > > > > > > > > The intent of the code

Re: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-21 Thread Wei Liu
On Fri, Jun 21, 2024 at 06:41:04PM +, Dexuan Cui wrote: > From: Jake Oshins > Sent: Friday, June 21, 2024 9:51 AM > > [...] > >On Fri, Jun 21, 2024 at 06:19:05AM +, Wei Liu wrote: > > On Fri, Jun 21, 2024 at 03:15:19AM +, Michael Kelley wrote: > > > From: Wei Liu

RE: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-21 Thread Dexuan Cui
From: Jake Oshins Sent: Friday, June 21, 2024 9:51 AM > [...] >On Fri, Jun 21, 2024 at 06:19:05AM +, Wei Liu wrote: > On Fri, Jun 21, 2024 at 03:15:19AM +, Michael Kelley wrote: > > From: Wei Liu Sent: Thursday, June 20, 2024 > > 6:48 PM > > > > > > The

Re: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-21 Thread Saurabh Singh Sengar
On Fri, Jun 21, 2024 at 06:19:05AM +, Wei Liu wrote: > On Fri, Jun 21, 2024 at 03:15:19AM +, Michael Kelley wrote: > > From: Wei Liu Sent: Thursday, June 20, 2024 6:48 PM > > > > > > The intent of the code snippet is to always return 0 for both fields. > > > The check is wrong though.

Re: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-21 Thread Wei Liu
On Fri, Jun 21, 2024 at 03:15:19AM +, Michael Kelley wrote: > From: Wei Liu Sent: Thursday, June 20, 2024 6:48 PM > > > > The intent of the code snippet is to always return 0 for both fields. > > The check is wrong though. Fix that. > > > > This is discovered by this call in VFIO: > > > >

RE: [PATCH] PCI: hv: fix reading of PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN

2024-06-20 Thread Michael Kelley
From: Wei Liu Sent: Thursday, June 20, 2024 6:48 PM > > The intent of the code snippet is to always return 0 for both fields. > The check is wrong though. Fix that. > > This is discovered by this call in VFIO: > > pci_read_config_byte(vdev->pdev, PCI_INTERRUPT_PIN, ); > > The old code