RE: [EXTERNAL] Re: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-31 Thread Shradha Gupta
linux-hyperv@vger.kernel.org; net...@vger.kernel.org; linux-ker...@vger.kernel.org; Shradha Gupta ; sta...@vger.kernel.org Subject: [EXTERNAL] Re: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed On Tue, 30 Jan 2024 22:09:57 -0800 Shradha Gupta wrote: > This patch ap

Re: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-31 Thread Jakub Kicinski
On Tue, 30 Jan 2024 22:09:57 -0800 Shradha Gupta wrote: > This patch applies to net, which is missed in the subject. I will fix > this in the new version of the patch. Thanks $ git checkout net/main [...] $ git am raw Applying: hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

RE: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-31 Thread Haiyang Zhang
t; hyp...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Shradha Gupta ; > sta...@vger.kernel.org > Subject: RE: [PATCH] hv_netvsc:Register VF in netvsc_probe if > NET_DEVICE_REGISTER missed > > > From: Haiyang Zhang > > Sent: Wednesday, Janu

RE: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-31 Thread Dexuan Cui
> From: Haiyang Zhang > Sent: Wednesday, January 31, 2024 8:46 AM > [...] > > From: Shradha Gupta > > Sent: Wednesday, January 31, 2024 2:54 AM > > > [...] > > > > + netvsc_prepare_bonding(vf_netdev); > > > > + netvsc_register_vf(vf_netdev, VF_REG_IN_PROBE); > > > > +

RE: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-31 Thread Haiyang Zhang
perv@vger.kernel.org; > net...@vger.kernel.org; linux-ker...@vger.kernel.org; Shradha Gupta > ; sta...@vger.kernel.org > Subject: Re: [PATCH] hv_netvsc:Register VF in netvsc_probe if > NET_DEVICE_REGISTER missed > > On Tue, Jan 30, 2024 at 08:13:21PM +, Dexuan Cui wrote: > > &g

Re: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-30 Thread Shradha Gupta
On Tue, Jan 30, 2024 at 08:13:21PM +, Dexuan Cui wrote: > > From: Shradha Gupta > > Sent: Monday, January 29, 2024 11:19 PM > > [...] > > If hv_netvsc driver is removed and reloaded, the NET_DEVICE_REGISTER > > s/removed/unloaded/ > unloaded looks more accurate to me :-) > > > [...] > > Tes

Re: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-30 Thread Shradha Gupta
On Tue, Jan 30, 2024 at 06:29:14PM -0800, Jakub Kicinski wrote: > On Mon, 29 Jan 2024 23:18:55 -0800 Shradha Gupta wrote: > > If hv_netvsc driver is removed and reloaded, the NET_DEVICE_REGISTER > > handler cannot perform VF register successfully as the register call > > is received before netvsc_p

Re: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-30 Thread Jakub Kicinski
On Mon, 29 Jan 2024 23:18:55 -0800 Shradha Gupta wrote: > If hv_netvsc driver is removed and reloaded, the NET_DEVICE_REGISTER > handler cannot perform VF register successfully as the register call > is received before netvsc_probe is finished. This is because we > register register_netdevice_notif

RE: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-30 Thread Dexuan Cui
> From: Haiyang Zhang > Sent: Tuesday, January 30, 2024 2:05 PM > [...] > > > @@ -2205,8 +2209,11 @@ static int netvsc_vf_join(struct net_device > > > *vf_netdev, > > > ndev->name, ret); > > > goto upper_link_failed; > > > } > > > - > > > - schedule_delayed_work(&n

RE: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-30 Thread Haiyang Zhang
> -Original Message- > From: Dexuan Cui > Sent: Tuesday, January 30, 2024 3:13 PM > To: Shradha Gupta ; KY Srinivasan > > > @@ -2205,8 +2209,11 @@ static int netvsc_vf_join(struct net_device > > *vf_netdev, > >ndev->name, ret); > > goto upper_link_

RE: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-30 Thread Dexuan Cui
> From: Shradha Gupta > Sent: Monday, January 29, 2024 11:19 PM > [...] > If hv_netvsc driver is removed and reloaded, the NET_DEVICE_REGISTER s/removed/unloaded/ unloaded looks more accurate to me :-) > [...] > Tested-on: Ubuntu22 > Testcases: LISA testsuites > verify_reload_hyperv_mo

RE: [PATCH] hv_netvsc:Register VF in netvsc_probe if NET_DEVICE_REGISTER missed

2024-01-30 Thread Haiyang Zhang
> -Original Message- > From: Shradha Gupta > Sent: Tuesday, January 30, 2024 2:19 AM > To: KY Srinivasan ; Haiyang Zhang > ; Wei Liu ; Dexuan Cui > ; David S. Miller ; Eric > Dumazet ; Jakub Kicinski ; Paolo > Abeni ; Wojciech Drewek ; > linux-hyperv@vger.kernel.org; net...@vger.kernel.