RE: [PATCH net] net: mana: Fix Rx DMA datasize and skb_over_panic

2024-04-02 Thread Haiyang Zhang
...@microsoft.com; h...@kernel.org; > t...@linutronix.de; shradhagu...@linux.microsoft.com; linux- > ker...@vger.kernel.org; sta...@vger.kernel.org > Subject: Re: [PATCH net] net: mana: Fix Rx DMA datasize and > skb_over_panic > > On Tue, 2 Apr 2024 01:23:08 + Dexuan Cui wrote: >

Re: [PATCH net] net: mana: Fix Rx DMA datasize and skb_over_panic

2024-04-01 Thread Jakub Kicinski
On Tue, 2 Apr 2024 01:23:08 + Dexuan Cui wrote: > > > I suggest the Fixes tag should be updated. Otherwise the fix > > > looks good to me. > > > > Thanks for the suggestion. I actually thought about this before > > submission. > > I was worried about someone back ports the jumbo frame featur

RE: [PATCH net] net: mana: Fix Rx DMA datasize and skb_over_panic

2024-04-01 Thread Dexuan Cui
> From: Haiyang Zhang > Sent: Monday, April 1, 2024 4:21 PM > > [...] > > I suggest the Fixes tag should be updated. Otherwise the fix > > looks good to me. > > Thanks for the suggestion. I actually thought about this before > submission. > I was worried about someone back ports the jumbo frame f

RE: [PATCH net] net: mana: Fix Rx DMA datasize and skb_over_panic

2024-04-01 Thread Haiyang Zhang
...@microsoft.com; h...@kernel.org; > t...@linutronix.de; shradhagu...@linux.microsoft.com; linux- > ker...@vger.kernel.org; sta...@vger.kernel.org > Subject: RE: [PATCH net] net: mana: Fix Rx DMA datasize and > skb_over_panic > > > From: LKML haiyangz On Behalf Of Haiyang Zhang > > Sen

RE: [PATCH net] net: mana: Fix Rx DMA datasize and skb_over_panic

2024-03-29 Thread Dexuan Cui
> From: LKML haiyangz On Behalf Of Haiyang Zhang > Sent: Friday, March 29, 2024 2:37 PM > [...] > mana_get_rxbuf_cfg() aligns the RX buffer's DMA datasize to be > multiple of 64. So a packet slightly bigger than mtu+14, say 1536, > can be received and cause skb_over_panic. > > Sample dmesg: > [ 5