Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-05 Thread Greg KH
On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: > +/* Define connection identifier type. */ > +union hv_connection_id { > + __u32 asu32; > + struct { > + __u32 id:24; > + __u32 reserved:8; Meta-commment, I don't see anywhere you are properly checking

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-04 Thread Greg KH
On Wed, Oct 04, 2023 at 11:16:46AM -0700, Nuno Das Neves wrote: > On 10/4/2023 10:50 AM, Greg KH wrote: > > On Wed, Oct 04, 2023 at 05:36:32PM +, Dexuan Cui wrote: > > > > From: Greg KH > > > > Sent: Tuesday, October 3, 2023 11:10 PM > > > > [...] > > > > On Tue, Oct 03, 2023 at 04:37:01PM -07

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-04 Thread Wei Liu
On Wed, Oct 04, 2023 at 08:11:13AM +0200, Greg KH wrote: > On Tue, Oct 03, 2023 at 11:29:42PM +, Wei Liu wrote: > > > > > > diff --git a/include/uapi/hyperv/hvgdk.h > > > > > > b/include/uapi/hyperv/hvgdk.h > > > > > > new file mode 100644 > > > > > > index ..9bcbb7d902b2 > > > > >

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-04 Thread Nuno Das Neves
On 10/4/2023 10:50 AM, Greg KH wrote: On Wed, Oct 04, 2023 at 05:36:32PM +, Dexuan Cui wrote: From: Greg KH Sent: Tuesday, October 3, 2023 11:10 PM [...] On Tue, Oct 03, 2023 at 04:37:01PM -0700, Nuno Das Neves wrote: On 9/30/2023 11:19 PM, Greg KH wrote: On Sat, Sep 30, 2023 at 10:01:58P

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-04 Thread Wei Liu
Hi Greg On Wed, Oct 04, 2023 at 08:11:13AM +0200, Greg KH wrote: > On Tue, Oct 03, 2023 at 11:29:42PM +, Wei Liu wrote: > > > > > > diff --git a/include/uapi/hyperv/hvgdk.h > > > > > > b/include/uapi/hyperv/hvgdk.h > > > > > > new file mode 100644 > > > > > > index ..9bcbb7d902b2

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-04 Thread Greg KH
On Wed, Oct 04, 2023 at 05:36:32PM +, Dexuan Cui wrote: > > From: Greg KH > > Sent: Tuesday, October 3, 2023 11:10 PM > > [...] > > On Tue, Oct 03, 2023 at 04:37:01PM -0700, Nuno Das Neves wrote: > > > On 9/30/2023 11:19 PM, Greg KH wrote: > > > > On Sat, Sep 30, 2023 at 10:01:58PM +, Wei

RE: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-04 Thread Dexuan Cui
> From: Greg KH > Sent: Tuesday, October 3, 2023 11:10 PM > [...] > On Tue, Oct 03, 2023 at 04:37:01PM -0700, Nuno Das Neves wrote: > > On 9/30/2023 11:19 PM, Greg KH wrote: > > > On Sat, Sep 30, 2023 at 10:01:58PM +, Wei Liu wrote: > > > > On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wro

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-03 Thread Greg KH
On Tue, Oct 03, 2023 at 11:29:42PM +, Wei Liu wrote: > > > > > diff --git a/include/uapi/hyperv/hvgdk.h b/include/uapi/hyperv/hvgdk.h > > > > > new file mode 100644 > > > > > index ..9bcbb7d902b2 > > > > > --- /dev/null > > > > > +++ b/include/uapi/hyperv/hvgdk.h > > > > > @@ -0,0 +

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-03 Thread Greg KH
On Tue, Oct 03, 2023 at 04:37:01PM -0700, Nuno Das Neves wrote: > On 9/30/2023 11:19 PM, Greg KH wrote: > > On Sat, Sep 30, 2023 at 10:01:58PM +, Wei Liu wrote: > > > On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote: > > > > On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote:

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-03 Thread Nuno Das Neves
On 9/30/2023 11:19 PM, Greg KH wrote: On Sat, Sep 30, 2023 at 10:01:58PM +, Wei Liu wrote: On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote: On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: +/* Define connection identifier type. */ +union hv_connection_id { + __

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-03 Thread Wei Liu
On Sun, Oct 01, 2023 at 08:19:27AM +0200, Greg KH wrote: > On Sat, Sep 30, 2023 at 10:01:58PM +, Wei Liu wrote: > > On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote: > > > On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: > > > > These must be in uapi because they will be u

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-09-30 Thread Greg KH
On Sat, Sep 30, 2023 at 10:01:58PM +, Wei Liu wrote: > On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote: > > On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: > > > These must be in uapi because they will be used in the mshv ioctl API. > > > > > > Version numbers for each

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-09-30 Thread Wei Liu
On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote: > On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: > > These must be in uapi because they will be used in the mshv ioctl API. > > > > Version numbers for each file: > > hvhdk.h 25212 > > hvhdk_mini.h25294 >

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-09-30 Thread kernel test robot
Hi Nuno, kernel test robot noticed the following build errors: [auto build test ERROR on arnd-asm-generic/master] [also build test ERROR on arm64/for-next/core linus/master v6.6-rc3 next-20230929] [cannot apply to tip/x86/core] [If your patch is applied to the wrong git tree, kindly drop us a no

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-09-29 Thread Greg KH
On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: > These must be in uapi because they will be used in the mshv ioctl API. > > Version numbers for each file: > hvhdk.h 25212 > hvhdk_mini.h 25294 > hvgdk.h 25125 > hvgdk_mini.h 25294 what are version numb