Re: [PATCH 01/24] mtd/maps/pismo: remove dangling pointer and a leak

2010-03-21 Thread David Woodhouse
On Sat, 2010-03-20 at 15:41 +, Russell King wrote: Thanks. Acked-by: Russell King rmk+ker...@arm.linux.org.uk David, are you going to pick this up? http://git.infradead.org/mtd-2.6.git/commitdiff/395b2288 Thanks. -- David WoodhouseOpen Source

Re: [PATCH 12/24] media/video: fix dangling pointers

2010-03-21 Thread Wolfram Sang
Hello Hans, Fix I2C-drivers which missed setting clientdata to NULL before freeing the structure it points to. Also fix drivers which do this _after_ the structure was freed already. I feel I am missing something here. Why does clientdata have to be set to NULL when we are tearing down

i2c interface bugs in dvb drivers

2010-03-21 Thread matthieu castet
Hi, some dvb driver that export a i2c interface contains some mistakes because they mainly used by driver (frontend, tuner) wrote for them. But the i2c interface is exposed to everybody. One mistake is expect msg[i].addr with 8 bits address instead of 7 bits address. This make them use eeprom

i2c probing

2010-03-21 Thread matthieu castet
Hi, Do you know why there is 2 methods of probing i2c [1] and [2], with different quirks for eeprom. Why can't they be merged together ? Thanks Matthieu PS : please keep me in CC [1] i2c_detect_address /* Make sure the address is valid */ if (addr 0x03 || addr 0x77) {

Re: [PATCH 12/24] media/video: fix dangling pointers

2010-03-21 Thread Hans Verkuil
On Sunday 21 March 2010 15:14:17 Mark Brown wrote: On Sun, Mar 21, 2010 at 02:46:55PM +0100, Jean Delvare wrote: On Sat, 20 Mar 2010 23:02:49 +0100, Hans Verkuil wrote: I feel I am missing something here. Why does clientdata have to be set to NULL when we are tearing down the device